Re: [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES

[Mike Westerhof <mike@mwester.net>]

On 2/8/2011 11:29 AM, Tom Rini wrote:
> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
>> This reduces amount of tasks for bootstrap-image from around 3400 to
>> around 1600 for jlime.
>>
>> Signed-off-by: Filip Zyzniewski<filip.zyzniewski@gmail.com>
> 
> Can some of the other distro folks chime in here?

Er, yes.  The commit message lacks information on how this affects other
distros.

I'm just guessing, but I expect that this commit will require that
distros expecting bluetooth and wifi support will need to ensure that
the correct set of features are defined.  Is that a correct assumption?

-Mike (mwester)


>> ---
>>   recipes/tasks/task-base.bb |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
>> index 32d871d..c8d6df7 100644
>> --- a/recipes/tasks/task-base.bb
>> +++ b/recipes/tasks/task-base.bb
>> @@ -1,5 +1,5 @@
>>   DESCRIPTION = "Merge machine and distro options to create a basic
>> machine task/package"
>> -PR = "r92"
>> +PR = "r93"
>>
>>   inherit task
>>
>> @@ -31,8 +31,8 @@ PACKAGES = ' \
>>               ${@base_contains("MACHINE_FEATURES", "redboot",
>> "task-base-redboot", "",d)} \
>>               ${@base_contains("MACHINE_FEATURES", "apex",
>> "task-base-apex", "",d)} \
>>               \
>> -            task-base-bluetooth \
>> -            task-base-wifi \
>> +            ${@base_contains("MACHINE_FEATURES", "bluetooth",
>> "task-base-bluetooth", "",d)} \
>> +            ${@base_contains("MACHINE_FEATURES", "wifi",
>> "task-base-wifi", "",d)} \
>>               \
>>               ${@base_contains("DISTRO_FEATURES", "cramfs",
>> "task-base-cramfs", "", d)} \
>>               ${@base_contains("DISTRO_FEATURES", "ipsec",
>> "task-base-ipsec", "", d)} \
> 
>