From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES
Date: Tue, 08 Feb 2011 19:23:12 +0100 [thread overview]
Message-ID: <iis1mg$tj9$1@dough.gmane.org> (raw)
In-Reply-To: <4D517D6C.3070604@mentor.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08-02-11 18:29, Tom Rini wrote:
> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
>> This reduces amount of tasks for bootstrap-image from around 3400 to
>> around 1600 for jlime.
>>
>> Signed-off-by: Filip Zyzniewski<filip.zyzniewski@gmail.com>
>
> Can some of the other distro folks chime in here?
Yeah, this patch is wrong, since task-base is supposed to drag in bt and
wifi when it's available which includes usb, pci, serial, etc.
>
>> ---
>> recipes/tasks/task-base.bb | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
>> index 32d871d..c8d6df7 100644
>> --- a/recipes/tasks/task-base.bb
>> +++ b/recipes/tasks/task-base.bb
>> @@ -1,5 +1,5 @@
>> DESCRIPTION = "Merge machine and distro options to create a basic
>> machine task/package"
>> -PR = "r92"
>> +PR = "r93"
>>
>> inherit task
>>
>> @@ -31,8 +31,8 @@ PACKAGES = ' \
>> ${@base_contains("MACHINE_FEATURES", "redboot",
>> "task-base-redboot", "",d)} \
>> ${@base_contains("MACHINE_FEATURES", "apex",
>> "task-base-apex", "",d)} \
>> \
>> - task-base-bluetooth \
>> - task-base-wifi \
>> + ${@base_contains("MACHINE_FEATURES", "bluetooth",
>> "task-base-bluetooth", "",d)} \
>> + ${@base_contains("MACHINE_FEATURES", "wifi",
>> "task-base-wifi", "",d)} \
>> \
>> ${@base_contains("DISTRO_FEATURES", "cramfs",
>> "task-base-cramfs", "", d)} \
>> ${@base_contains("DISTRO_FEATURES", "ipsec",
>> "task-base-ipsec", "", d)} \
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFNUYoQMkyGM64RGpERAuFAAJ9Y5jiml8NdBJpg5XmD7b8BlwjjFQCfXL8H
xuKrNII4OscMLUu/S2dAejQ=
=j2V5
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-02-08 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 22:13 [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES Filip Zyzniewski
2011-02-08 17:29 ` Tom Rini
2011-02-08 18:16 ` Mike Westerhof
2011-02-08 18:23 ` Koen Kooi [this message]
2011-02-08 20:39 ` Filip Zyzniewski
2011-02-08 21:04 ` Koen Kooi
2011-02-08 21:22 ` Filip Zyzniewski
2011-02-08 21:25 ` Tom Rini
2011-02-08 21:30 ` Tom Rini
2011-02-09 9:17 ` Filip Zyzniewski
2011-02-08 20:59 ` Douglas Royds
2011-02-08 21:08 ` Eric Bénard
2011-02-08 22:16 ` Koen Kooi
2011-02-08 22:18 ` Eric Bénard
2011-02-09 6:05 ` Filip Zyzniewski
2011-02-09 9:39 ` Marcin Juszkiewicz
2011-02-09 12:59 ` Filip Zyzniewski
2011-02-09 13:28 ` Koen Kooi
2011-02-09 13:43 ` Filip Zyzniewski
2011-02-09 15:01 ` Tom Rini
2011-02-09 15:22 ` Phil Blundell
2011-02-09 15:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iis1mg$tj9$1@dough.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.