Re: [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES

[Tom Rini <tom_rini@mentor.com>]

On 02/09/2011 06:28 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 09-02-11 13:59, Filip Zyzniewski wrote:
>> On 2/9/11, Marcin Juszkiewicz<marcin@juszkiewicz.com.pl>  wrote:
>>
>>> This change is bogus. You just remove building of BT/Wifi support for
>>> "bitbake
>>> bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead
>>> and
>>> then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution
>>> config
>>> file.
>>
>> The whole point of this patch is to make task-base honour features.
>> Without this change bluez (and in consequence avahi, gstreamer, gtk, x
>> libs) gets built regardless of features setting.
>
> That's the whole point of task-base, to get things built. You can then
> use machine_features to install them by default or not.
>
> Again, noone is forcing you to use task-base, so no need to break it for
> everyone else like your patch is doing.

But it's also kinda annoying when you opt out of task-base.

So let me put on the apparently stupid hat today.  Looking at task-base 
today.  PACKAGES always has task-base-{wifi,bluetooth}.  task-base will 
RDEPEND on it iff DISTRO and MACHINE set the appropriate feature.  Then 
in task-base-extended RDEPENDS we have logic to do the common $bus I/O 
thing I was talking about.

So... wouldn't making the patch be DISTRO_FEATURES rather than 
MACHINE_FEATURES be what people want?

-- 
Tom Rini
Mentor Graphics Corporation