* [PATCH] evas: disable cpu neon support for palmpre machine @ 2011-02-08 21:17 Simon Busch 2011-02-08 21:39 ` Tom Rini 0 siblings, 1 reply; 12+ messages in thread From: Simon Busch @ 2011-02-08 21:17 UTC (permalink / raw) To: openembedded-devel Neon support in evas is currently broken for the palmpre machine. If we enable neon support evas causes alignment trap errors and lets the device freeze in the end. This should be reverted after the bug in evas code is found and fixed. Signed-off-by: Simon Busch <morphis@gravedo.de> --- recipes/efl1/evas.inc | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc index eb64d7a..ad30eba 100644 --- a/recipes/efl1/evas.inc +++ b/recipes/efl1/evas.inc @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native libpng-native jpeg-na inherit efl BBCLASSEXTEND = "native" -INC_PR = "r0" +INC_PR = "r1" FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" python populate_packages_prepend () { @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" # Disabled for now, see http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" +# Neon support for evas is broken on palmpre currently (causes the device to freeze) +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" + # common options EVAS_OECONF = " \ --x-includes=${STAGING_INCDIR}/X11 \ -- 1.7.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-08 21:17 [PATCH] evas: disable cpu neon support for palmpre machine Simon Busch @ 2011-02-08 21:39 ` Tom Rini 2011-02-09 18:16 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2011-02-08 21:39 UTC (permalink / raw) To: openembedded-devel On 02/08/2011 02:17 PM, Simon Busch wrote: > Neon support in evas is currently broken for the palmpre machine. If we enable neon > support evas causes alignment trap errors and lets the device freeze in the end. This > should be reverted after the bug in evas code is found and fixed. > > Signed-off-by: Simon Busch<morphis@gravedo.de> > --- > recipes/efl1/evas.inc | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc > index eb64d7a..ad30eba 100644 > --- a/recipes/efl1/evas.inc > +++ b/recipes/efl1/evas.inc > @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native libpng-native jpeg-na > inherit efl > > BBCLASSEXTEND = "native" > -INC_PR = "r0" > +INC_PR = "r1" > FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" > > python populate_packages_prepend () { > @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" > # Disabled for now, see http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 > #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" > > +# Neon support for evas is broken on palmpre currently (causes the device to freeze) > +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" > + > # common options > EVAS_OECONF = " \ > --x-includes=${STAGING_INCDIR}/X11 \ Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above yours to be uncommented and as a --disable? -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-08 21:39 ` Tom Rini @ 2011-02-09 18:16 ` Khem Raj 2011-02-09 18:24 ` Koen Kooi 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2011-02-09 18:16 UTC (permalink / raw) To: openembedded-devel On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini <tom_rini@mentor.com> wrote: > On 02/08/2011 02:17 PM, Simon Busch wrote: >> >> Neon support in evas is currently broken for the palmpre machine. If we >> enable neon >> support evas causes alignment trap errors and lets the device freeze in >> the end. This >> should be reverted after the bug in evas code is found and fixed. >> >> Signed-off-by: Simon Busch<morphis@gravedo.de> >> --- >> recipes/efl1/evas.inc | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >> index eb64d7a..ad30eba 100644 >> --- a/recipes/efl1/evas.inc >> +++ b/recipes/efl1/evas.inc >> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native >> libpng-native jpeg-na >> inherit efl >> >> BBCLASSEXTEND = "native" >> -INC_PR = "r0" >> +INC_PR = "r1" >> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >> >> python populate_packages_prepend () { >> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >> # Disabled for now, see >> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >> >> +# Neon support for evas is broken on palmpre currently (causes the device >> to freeze) >> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >> + >> # common options >> EVAS_OECONF = " \ >> --x-includes=${STAGING_INCDIR}/X11 \ > > Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above yours to > be uncommented and as a --disable? that would disable neon for all armv7a machines probably not what is needed here. The patch seems ok but I think it will make this recipe machine specific if it already is not on the other hand punishing all armv7 will keep the recipe still generic > > -- > Tom Rini > Mentor Graphics Corporation > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 18:16 ` Khem Raj @ 2011-02-09 18:24 ` Koen Kooi 2011-02-09 19:31 ` Simon Busch 0 siblings, 1 reply; 12+ messages in thread From: Koen Kooi @ 2011-02-09 18:24 UTC (permalink / raw) To: openembedded-devel -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09-02-11 19:16, Khem Raj wrote: > On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini <tom_rini@mentor.com> wrote: >> On 02/08/2011 02:17 PM, Simon Busch wrote: >>> >>> Neon support in evas is currently broken for the palmpre machine. If we >>> enable neon >>> support evas causes alignment trap errors and lets the device freeze in >>> the end. This >>> should be reverted after the bug in evas code is found and fixed. >>> >>> Signed-off-by: Simon Busch<morphis@gravedo.de> >>> --- >>> recipes/efl1/evas.inc | 5 ++++- >>> 1 files changed, 4 insertions(+), 1 deletions(-) >>> >>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>> index eb64d7a..ad30eba 100644 >>> --- a/recipes/efl1/evas.inc >>> +++ b/recipes/efl1/evas.inc >>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native >>> libpng-native jpeg-na >>> inherit efl >>> >>> BBCLASSEXTEND = "native" >>> -INC_PR = "r0" >>> +INC_PR = "r1" >>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>> >>> python populate_packages_prepend () { >>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>> # Disabled for now, see >>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>> >>> +# Neon support for evas is broken on palmpre currently (causes the device >>> to freeze) >>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>> + >>> # common options >>> EVAS_OECONF = " \ >>> --x-includes=${STAGING_INCDIR}/X11 \ >> >> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above yours to >> be uncommented and as a --disable? > > that would disable neon for all armv7a machines probably not what is > needed here. Actually, that was how I did it :) The NEON code that was added doesn't build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not enabling it. If it builds and works with gcc 4.3.x nowadays we should enable it and find out why the palmpre breaks. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNUtvMMkyGM64RGpERApZsAKCqED8JCVCdRqPtGfZ8gAZ+uCk0swCcD96s 9LMHSgBQMcskY+N/zSOAvc4= =lI+a -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 18:24 ` Koen Kooi @ 2011-02-09 19:31 ` Simon Busch 2011-02-09 19:45 ` Tom Rini 0 siblings, 1 reply; 12+ messages in thread From: Simon Busch @ 2011-02-09 19:31 UTC (permalink / raw) To: openembedded-devel On 02/09/11 at 07:24pm, Koen Kooi wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > On 09-02-11 19:16, Khem Raj wrote: > > On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini <tom_rini@mentor.com> wrote: > >> On 02/08/2011 02:17 PM, Simon Busch wrote: > >>> > >>> Neon support in evas is currently broken for the palmpre machine. If we > >>> enable neon > >>> support evas causes alignment trap errors and lets the device freeze in > >>> the end. This > >>> should be reverted after the bug in evas code is found and fixed. > >>> > >>> Signed-off-by: Simon Busch<morphis@gravedo.de> > >>> --- > >>> recipes/efl1/evas.inc | 5 ++++- > >>> 1 files changed, 4 insertions(+), 1 deletions(-) > >>> > >>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc > >>> index eb64d7a..ad30eba 100644 > >>> --- a/recipes/efl1/evas.inc > >>> +++ b/recipes/efl1/evas.inc > >>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native > >>> libpng-native jpeg-na > >>> inherit efl > >>> > >>> BBCLASSEXTEND = "native" > >>> -INC_PR = "r0" > >>> +INC_PR = "r1" > >>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" > >>> > >>> python populate_packages_prepend () { > >>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" > >>> # Disabled for now, see > >>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 > >>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" > >>> > >>> +# Neon support for evas is broken on palmpre currently (causes the device > >>> to freeze) > >>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" > >>> + > >>> # common options > >>> EVAS_OECONF = " \ > >>> --x-includes=${STAGING_INCDIR}/X11 \ > >> > >> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above yours to > >> be uncommented and as a --disable? > > > > that would disable neon for all armv7a machines probably not what is > > needed here. > Actually, that was how I did it :) The NEON code that was added doesn't > build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not > enabling it. If it builds and works with gcc 4.3.x nowadays we should > enable it and find out why the palmpre breaks. Evas builds fine these days with neon support enabled but it enables it by default. I really need to find the cause of the breakage on the palmpre but don't have too much time to debug it so this is a interim solution only until the bug is found and fixed. regards, morphis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 19:31 ` Simon Busch @ 2011-02-09 19:45 ` Tom Rini 2011-02-09 20:44 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2011-02-09 19:45 UTC (permalink / raw) To: openembedded-devel On 02/09/2011 12:31 PM, Simon Busch wrote: > On 02/09/11 at 07:24pm, Koen Kooi wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 > >> On 09-02-11 19:16, Khem Raj wrote: >>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: >>>> On 02/08/2011 02:17 PM, Simon Busch wrote: >>>>> >>>>> Neon support in evas is currently broken for the palmpre machine. If we >>>>> enable neon >>>>> support evas causes alignment trap errors and lets the device freeze in >>>>> the end. This >>>>> should be reverted after the bug in evas code is found and fixed. >>>>> >>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> >>>>> --- >>>>> recipes/efl1/evas.inc | 5 ++++- >>>>> 1 files changed, 4 insertions(+), 1 deletions(-) >>>>> >>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>>>> index eb64d7a..ad30eba 100644 >>>>> --- a/recipes/efl1/evas.inc >>>>> +++ b/recipes/efl1/evas.inc >>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native libxext-native >>>>> libpng-native jpeg-na >>>>> inherit efl >>>>> >>>>> BBCLASSEXTEND = "native" >>>>> -INC_PR = "r0" >>>>> +INC_PR = "r1" >>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>>>> >>>>> python populate_packages_prepend () { >>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>>>> # Disabled for now, see >>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>>>> >>>>> +# Neon support for evas is broken on palmpre currently (causes the device >>>>> to freeze) >>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>>>> + >>>>> # common options >>>>> EVAS_OECONF = " \ >>>>> --x-includes=${STAGING_INCDIR}/X11 \ >>>> >>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above yours to >>>> be uncommented and as a --disable? >>> >>> that would disable neon for all armv7a machines probably not what is >>> needed here. > >> Actually, that was how I did it :) The NEON code that was added doesn't >> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not >> enabling it. If it builds and works with gcc 4.3.x nowadays we should >> enable it and find out why the palmpre breaks. > > Evas builds fine these days with neon support enabled but it enables it by > default. I really need to find the cause of the breakage on the palmpre but > don't have too much time to debug it so this is a interim solution only > until the bug is found and fixed. My only concern is that are we sure other armv7a targets aren't also having fatal problems? -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 19:45 ` Tom Rini @ 2011-02-09 20:44 ` Khem Raj 2011-02-09 23:45 ` Tom Rini 0 siblings, 1 reply; 12+ messages in thread From: Khem Raj @ 2011-02-09 20:44 UTC (permalink / raw) To: openembedded-devel On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini <tom_rini@mentor.com> wrote: > On 02/09/2011 12:31 PM, Simon Busch wrote: >> >> On 02/09/11 at 07:24pm, Koen Kooi wrote: >>> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >> >>> On 09-02-11 19:16, Khem Raj wrote: >>>> >>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: >>>>> >>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: >>>>>> >>>>>> Neon support in evas is currently broken for the palmpre machine. If >>>>>> we >>>>>> enable neon >>>>>> support evas causes alignment trap errors and lets the device freeze >>>>>> in >>>>>> the end. This >>>>>> should be reverted after the bug in evas code is found and fixed. >>>>>> >>>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> >>>>>> --- >>>>>> recipes/efl1/evas.inc | 5 ++++- >>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) >>>>>> >>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>>>>> index eb64d7a..ad30eba 100644 >>>>>> --- a/recipes/efl1/evas.inc >>>>>> +++ b/recipes/efl1/evas.inc >>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native >>>>>> libxext-native >>>>>> libpng-native jpeg-na >>>>>> inherit efl >>>>>> >>>>>> BBCLASSEXTEND = "native" >>>>>> -INC_PR = "r0" >>>>>> +INC_PR = "r1" >>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>>>>> >>>>>> python populate_packages_prepend () { >>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>>>>> # Disabled for now, see >>>>>> >>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>>>>> >>>>>> +# Neon support for evas is broken on palmpre currently (causes the >>>>>> device >>>>>> to freeze) >>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>>>>> + >>>>>> # common options >>>>>> EVAS_OECONF = " \ >>>>>> --x-includes=${STAGING_INCDIR}/X11 \ >>>>> >>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above >>>>> yours to >>>>> be uncommented and as a --disable? >>>> >>>> that would disable neon for all armv7a machines probably not what is >>>> needed here. >> >>> Actually, that was how I did it :) The NEON code that was added doesn't >>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not >>> enabling it. If it builds and works with gcc 4.3.x nowadays we should >>> enable it and find out why the palmpre breaks. >> >> Evas builds fine these days with neon support enabled but it enables it by >> default. I really need to find the cause of the breakage on the palmpre >> but >> don't have too much time to debug it so this is a interim solution only >> until the bug is found and fixed. that would be nice because once we add machine override it can become a common escape for other machines and changing this to be a machine specific recipe is not desired unless absolutely needed > > My only concern is that are we sure other armv7a targets aren't also having > fatal problems? we don't fix what we don't know is broken > > -- > Tom Rini > Mentor Graphics Corporation > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 20:44 ` Khem Raj @ 2011-02-09 23:45 ` Tom Rini 2011-02-23 9:54 ` Paul Menzel 0 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2011-02-09 23:45 UTC (permalink / raw) To: openembedded-devel On 02/09/2011 01:44 PM, Khem Raj wrote: > On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini<tom_rini@mentor.com> wrote: >> On 02/09/2011 12:31 PM, Simon Busch wrote: >>> >>> On 02/09/11 at 07:24pm, Koen Kooi wrote: >>>> >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA1 >>> >>>> On 09-02-11 19:16, Khem Raj wrote: >>>>> >>>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: >>>>>> >>>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: >>>>>>> >>>>>>> Neon support in evas is currently broken for the palmpre machine. If >>>>>>> we >>>>>>> enable neon >>>>>>> support evas causes alignment trap errors and lets the device freeze >>>>>>> in >>>>>>> the end. This >>>>>>> should be reverted after the bug in evas code is found and fixed. >>>>>>> >>>>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> >>>>>>> --- >>>>>>> recipes/efl1/evas.inc | 5 ++++- >>>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) >>>>>>> >>>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>>>>>> index eb64d7a..ad30eba 100644 >>>>>>> --- a/recipes/efl1/evas.inc >>>>>>> +++ b/recipes/efl1/evas.inc >>>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native >>>>>>> libxext-native >>>>>>> libpng-native jpeg-na >>>>>>> inherit efl >>>>>>> >>>>>>> BBCLASSEXTEND = "native" >>>>>>> -INC_PR = "r0" >>>>>>> +INC_PR = "r1" >>>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>>>>>> >>>>>>> python populate_packages_prepend () { >>>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>>>>>> # Disabled for now, see >>>>>>> >>>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>>>>>> >>>>>>> +# Neon support for evas is broken on palmpre currently (causes the >>>>>>> device >>>>>>> to freeze) >>>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>>>>>> + >>>>>>> # common options >>>>>>> EVAS_OECONF = " \ >>>>>>> --x-includes=${STAGING_INCDIR}/X11 \ >>>>>> >>>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above >>>>>> yours to >>>>>> be uncommented and as a --disable? >>>>> >>>>> that would disable neon for all armv7a machines probably not what is >>>>> needed here. >>> >>>> Actually, that was how I did it :) The NEON code that was added doesn't >>>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not >>>> enabling it. If it builds and works with gcc 4.3.x nowadays we should >>>> enable it and find out why the palmpre breaks. >>> >>> Evas builds fine these days with neon support enabled but it enables it by >>> default. I really need to find the cause of the breakage on the palmpre >>> but >>> don't have too much time to debug it so this is a interim solution only >>> until the bug is found and fixed. > > that would be nice because once we add machine override it can become > a common escape for other machines > and changing this to be a machine specific recipe is not desired > unless absolutely needed > >> >> My only concern is that are we sure other armv7a targets aren't also having >> fatal problems? > > we don't fix what we don't know is broken Right. But it sounds like it shouldn't be too hard to see if it is broken elsewhere :) -- Tom Rini Mentor Graphics Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-09 23:45 ` Tom Rini @ 2011-02-23 9:54 ` Paul Menzel 2011-02-24 5:33 ` Simon Busch 0 siblings, 1 reply; 12+ messages in thread From: Paul Menzel @ 2011-02-23 9:54 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3785 bytes --] Am Mittwoch, den 09.02.2011, 16:45 -0700 schrieb Tom Rini: > On 02/09/2011 01:44 PM, Khem Raj wrote: > > On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini<tom_rini@mentor.com> wrote: > >> On 02/09/2011 12:31 PM, Simon Busch wrote: > >>> > >>> On 02/09/11 at 07:24pm, Koen Kooi wrote: > >>>> > >>>> -----BEGIN PGP SIGNED MESSAGE----- > >>>> Hash: SHA1 > >>> > >>>> On 09-02-11 19:16, Khem Raj wrote: > >>>>> > >>>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: > >>>>>> > >>>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: > >>>>>>> > >>>>>>> Neon support in evas is currently broken for the palmpre machine. If > >>>>>>> we > >>>>>>> enable neon > >>>>>>> support evas causes alignment trap errors and lets the device freeze > >>>>>>> in > >>>>>>> the end. This > >>>>>>> should be reverted after the bug in evas code is found and fixed. > >>>>>>> > >>>>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> > >>>>>>> --- > >>>>>>> recipes/efl1/evas.inc | 5 ++++- > >>>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) > >>>>>>> > >>>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc > >>>>>>> index eb64d7a..ad30eba 100644 > >>>>>>> --- a/recipes/efl1/evas.inc > >>>>>>> +++ b/recipes/efl1/evas.inc > >>>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native > >>>>>>> libxext-native > >>>>>>> libpng-native jpeg-na > >>>>>>> inherit efl > >>>>>>> > >>>>>>> BBCLASSEXTEND = "native" > >>>>>>> -INC_PR = "r0" > >>>>>>> +INC_PR = "r1" > >>>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" > >>>>>>> > >>>>>>> python populate_packages_prepend () { > >>>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" > >>>>>>> # Disabled for now, see > >>>>>>> > >>>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 > >>>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" > >>>>>>> > >>>>>>> +# Neon support for evas is broken on palmpre currently (causes the device > >>>>>>> to freeze) > >>>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" > >>>>>>> + > >>>>>>> # common options > >>>>>>> EVAS_OECONF = " \ > >>>>>>> --x-includes=${STAGING_INCDIR}/X11 \ > >>>>>> > >>>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above > >>>>>> yours to > >>>>>> be uncommented and as a --disable? > >>>>> > >>>>> that would disable neon for all armv7a machines probably not what is > >>>>> needed here. > >>> > >>>> Actually, that was how I did it :) The NEON code that was added doesn't > >>>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not > >>>> enabling it. If it builds and works with gcc 4.3.x nowadays we should > >>>> enable it and find out why the palmpre breaks. > >>> > >>> Evas builds fine these days with neon support enabled but it enables it by > >>> default. I really need to find the cause of the breakage on the palmpre > >>> but don't have too much time to debug it so this is a interim solution only > >>> until the bug is found and fixed. > > > > that would be nice because once we add machine override it can become > > a common escape for other machines > > and changing this to be a machine specific recipe is not desired > > unless absolutely needed > > > >> > >> My only concern is that are we sure other armv7a targets aren't also having > >> fatal problems? > > > > we don't fix what we don't know is broken > > Right. But it sounds like it shouldn't be too hard to see if it is > broken elsewhere :) This patch [1] is superseded by Koen’s commit d6729be1 [2]. Thanks, Paul [1] http://patches.openembedded.org/patch/497/ [2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=d6729be1fd7f2e82e7535a854e2aae006aaec5ee [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-23 9:54 ` Paul Menzel @ 2011-02-24 5:33 ` Simon Busch 2011-02-24 8:14 ` Koen Kooi 0 siblings, 1 reply; 12+ messages in thread From: Simon Busch @ 2011-02-24 5:33 UTC (permalink / raw) To: openembedded-devel On 02/23/11 at 10:54am, Paul Menzel wrote: > Am Mittwoch, den 09.02.2011, 16:45 -0700 schrieb Tom Rini: > > On 02/09/2011 01:44 PM, Khem Raj wrote: > > > On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini<tom_rini@mentor.com> wrote: > > >> On 02/09/2011 12:31 PM, Simon Busch wrote: > > >>> > > >>> On 02/09/11 at 07:24pm, Koen Kooi wrote: > > >>>> > > >>>> -----BEGIN PGP SIGNED MESSAGE----- > > >>>> Hash: SHA1 > > >>> > > >>>> On 09-02-11 19:16, Khem Raj wrote: > > >>>>> > > >>>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: > > >>>>>> > > >>>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: > > >>>>>>> > > >>>>>>> Neon support in evas is currently broken for the palmpre machine. If > > >>>>>>> we > > >>>>>>> enable neon > > >>>>>>> support evas causes alignment trap errors and lets the device freeze > > >>>>>>> in > > >>>>>>> the end. This > > >>>>>>> should be reverted after the bug in evas code is found and fixed. > > >>>>>>> > > >>>>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> > > >>>>>>> --- > > >>>>>>> recipes/efl1/evas.inc | 5 ++++- > > >>>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) > > >>>>>>> > > >>>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc > > >>>>>>> index eb64d7a..ad30eba 100644 > > >>>>>>> --- a/recipes/efl1/evas.inc > > >>>>>>> +++ b/recipes/efl1/evas.inc > > >>>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native > > >>>>>>> libxext-native > > >>>>>>> libpng-native jpeg-na > > >>>>>>> inherit efl > > >>>>>>> > > >>>>>>> BBCLASSEXTEND = "native" > > >>>>>>> -INC_PR = "r0" > > >>>>>>> +INC_PR = "r1" > > >>>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" > > >>>>>>> > > >>>>>>> python populate_packages_prepend () { > > >>>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" > > >>>>>>> # Disabled for now, see > > >>>>>>> > > >>>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 > > >>>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" > > >>>>>>> > > >>>>>>> +# Neon support for evas is broken on palmpre currently (causes the device > > >>>>>>> to freeze) > > >>>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" > > >>>>>>> + > > >>>>>>> # common options > > >>>>>>> EVAS_OECONF = " \ > > >>>>>>> --x-includes=${STAGING_INCDIR}/X11 \ > > >>>>>> > > >>>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above > > >>>>>> yours to > > >>>>>> be uncommented and as a --disable? > > >>>>> > > >>>>> that would disable neon for all armv7a machines probably not what is > > >>>>> needed here. > > >>> > > >>>> Actually, that was how I did it :) The NEON code that was added doesn't > > >>>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not > > >>>> enabling it. If it builds and works with gcc 4.3.x nowadays we should > > >>>> enable it and find out why the palmpre breaks. > > >>> > > >>> Evas builds fine these days with neon support enabled but it enables it by > > >>> default. I really need to find the cause of the breakage on the palmpre > > >>> but don't have too much time to debug it so this is a interim solution only > > >>> until the bug is found and fixed. > > > > > > that would be nice because once we add machine override it can become > > > a common escape for other machines > > > and changing this to be a machine specific recipe is not desired > > > unless absolutely needed > > > > > >> > > >> My only concern is that are we sure other armv7a targets aren't also having > > >> fatal problems? > > > > > > we don't fix what we don't know is broken > > > > Right. But it sounds like it shouldn't be too hard to see if it is > > broken elsewhere :) > This patch [1] is superseded by Koen’s commit d6729be1 [2]. I already saw Koen's commit but nevertheless someone should try to find out why Neon makes such troubles on our arm targets. regards, SImon ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-24 5:33 ` Simon Busch @ 2011-02-24 8:14 ` Koen Kooi 2011-03-01 1:09 ` Khem Raj 0 siblings, 1 reply; 12+ messages in thread From: Koen Kooi @ 2011-02-24 8:14 UTC (permalink / raw) To: openembedded-devel -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 24-02-11 06:33, Simon Busch wrote: > On 02/23/11 at 10:54am, Paul Menzel wrote: >> Am Mittwoch, den 09.02.2011, 16:45 -0700 schrieb Tom Rini: >>> On 02/09/2011 01:44 PM, Khem Raj wrote: >>>> On Wed, Feb 9, 2011 at 11:45 AM, Tom Rini<tom_rini@mentor.com> wrote: >>>>> On 02/09/2011 12:31 PM, Simon Busch wrote: >>>>>> >>>>>> On 02/09/11 at 07:24pm, Koen Kooi wrote: >>>>>>> >>>>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>>>> Hash: SHA1 >>>>>> >>>>>>> On 09-02-11 19:16, Khem Raj wrote: >>>>>>>> >>>>>>>> On Tue, Feb 8, 2011 at 1:39 PM, Tom Rini<tom_rini@mentor.com> wrote: >>>>>>>>> >>>>>>>>> On 02/08/2011 02:17 PM, Simon Busch wrote: >>>>>>>>>> >>>>>>>>>> Neon support in evas is currently broken for the palmpre machine. If >>>>>>>>>> we >>>>>>>>>> enable neon >>>>>>>>>> support evas causes alignment trap errors and lets the device freeze >>>>>>>>>> in >>>>>>>>>> the end. This >>>>>>>>>> should be reverted after the bug in evas code is found and fixed. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Simon Busch<morphis@gravedo.de> >>>>>>>>>> --- >>>>>>>>>> recipes/efl1/evas.inc | 5 ++++- >>>>>>>>>> 1 files changed, 4 insertions(+), 1 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/recipes/efl1/evas.inc b/recipes/efl1/evas.inc >>>>>>>>>> index eb64d7a..ad30eba 100644 >>>>>>>>>> --- a/recipes/efl1/evas.inc >>>>>>>>>> +++ b/recipes/efl1/evas.inc >>>>>>>>>> @@ -7,7 +7,7 @@ DEPENDS_virtclass-native = "freetype-native >>>>>>>>>> libxext-native >>>>>>>>>> libpng-native jpeg-na >>>>>>>>>> inherit efl >>>>>>>>>> >>>>>>>>>> BBCLASSEXTEND = "native" >>>>>>>>>> -INC_PR = "r0" >>>>>>>>>> +INC_PR = "r1" >>>>>>>>>> FILESPATHPKG =. "${BPN}-${PV}:${BPN}:" >>>>>>>>>> >>>>>>>>>> python populate_packages_prepend () { >>>>>>>>>> @@ -83,6 +83,9 @@ EVAS_CPU_TWEAKS = "" >>>>>>>>>> # Disabled for now, see >>>>>>>>>> >>>>>>>>>> http://thread.gmane.org/gmane.comp.window-managers.enlightenment.devel/25194 >>>>>>>>>> #EVAS_CPU_TWEAKS_armv7a = "--enable-cpu-neon" >>>>>>>>>> >>>>>>>>>> +# Neon support for evas is broken on palmpre currently (causes the device >>>>>>>>>> to freeze) >>>>>>>>>> +EVAS_CPU_TWEAKS_palmpre = "--disable-cpu-neon" >>>>>>>>>> + >>>>>>>>>> # common options >>>>>>>>>> EVAS_OECONF = " \ >>>>>>>>>> --x-includes=${STAGING_INCDIR}/X11 \ >>>>>>>>> >>>>>>>>> Shouldn't this be changing the armv7a EVAS_CPU_TWEAKS that's above >>>>>>>>> yours to >>>>>>>>> be uncommented and as a --disable? >>>>>>>> >>>>>>>> that would disable neon for all armv7a machines probably not what is >>>>>>>> needed here. >>>>>> >>>>>>> Actually, that was how I did it :) The NEON code that was added doesn't >>>>>>> build with gcc 4.3.x and binutils 2.18.x, so I disabled it by not >>>>>>> enabling it. If it builds and works with gcc 4.3.x nowadays we should >>>>>>> enable it and find out why the palmpre breaks. >>>>>> >>>>>> Evas builds fine these days with neon support enabled but it enables it by >>>>>> default. I really need to find the cause of the breakage on the palmpre >>>>>> but don't have too much time to debug it so this is a interim solution only >>>>>> until the bug is found and fixed. >>>> >>>> that would be nice because once we add machine override it can become >>>> a common escape for other machines >>>> and changing this to be a machine specific recipe is not desired >>>> unless absolutely needed >>>> >>>>> >>>>> My only concern is that are we sure other armv7a targets aren't also having >>>>> fatal problems? >>>> >>>> we don't fix what we don't know is broken >>> >>> Right. But it sounds like it shouldn't be too hard to see if it is >>> broken elsewhere :) > >> This patch [1] is superseded by Koen’s commit d6729be1 [2]. > > I already saw Koen's commit but nevertheless someone should try to find out > why Neon makes such troubles on our arm targets. In my case, the ASM is written with gcc 4.5 and binutils 2.20 in mind, so the constraints are a bit different, resulting in misrendered buttons. I can't say what your problem with the palm is, probably a buggy kernel. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNZhNtMkyGM64RGpERAg/uAJ9pxS8OmICemCcYlbzVMgv8leE3TACgq94Z E4r6Df8nBJOdxstJbOyb+eA= =6KUG -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] evas: disable cpu neon support for palmpre machine 2011-02-24 8:14 ` Koen Kooi @ 2011-03-01 1:09 ` Khem Raj 0 siblings, 0 replies; 12+ messages in thread From: Khem Raj @ 2011-03-01 1:09 UTC (permalink / raw) To: openembedded-devel On (24/02/11 09:14), Koen Kooi wrote: > > I already saw Koen's commit but nevertheless someone should try to find out > > why Neon makes such troubles on our arm targets. > > In my case, the ASM is written with gcc 4.5 and binutils 2.20 in mind, > so the constraints are a bit different, resulting in misrendered buttons. > I can't say what your problem with the palm is, probably a buggy kernel. > hmm I can have a look at the code if you like. -- -Khem ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-03-01 1:10 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-08 21:17 [PATCH] evas: disable cpu neon support for palmpre machine Simon Busch 2011-02-08 21:39 ` Tom Rini 2011-02-09 18:16 ` Khem Raj 2011-02-09 18:24 ` Koen Kooi 2011-02-09 19:31 ` Simon Busch 2011-02-09 19:45 ` Tom Rini 2011-02-09 20:44 ` Khem Raj 2011-02-09 23:45 ` Tom Rini 2011-02-23 9:54 ` Paul Menzel 2011-02-24 5:33 ` Simon Busch 2011-02-24 8:14 ` Koen Kooi 2011-03-01 1:09 ` Khem Raj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.