Re: [PATCH 2/3] u-boot: add LIC_FILES_CHKSUM

[Darren Hart <dvhart@linux.intel.com>]

On 02/09/2011 02:58 PM, Ilya Yanok wrote:
> Hi Darren,
>
> 09.02.2011 20:38, Darren Hart wrote:
>>> +LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
>>> +
>>
>> From what I can tell u-boot.inc is only used by u-boot_git.bb which
>> already defines LIC_FILES_CHKSUM and the appropriate GPLv2+ LICENSE
>> variable.
>
> Well, that's true. Actually I'm adding my own U-Boot recipe but want to
> use u-boot.inc.


I figured, otherwise you would have hit a build failure with 
u-boot_git.bb (since it's CHKSUM was out of date and overwrote the one 
in .inc).


>> It seems to me the LICENSE and LIC_FILES_CHKSUM should be defined in the
>> same recipe as the SRC_URI. In this case, u-boot_git.bb. Is there a
>> motivating reason to add it to .inc? If so, we should also remove it
>
> My idea was that main COPYING file will be present in virtually any
> U-Boot version, so we want LIC_FILES_CHKSUM for this file to be in
> common include file.


True, but it may suffer from line-wrapping or other subtle changes which 
will break the CHKSUMs.


>> from u-boot_git.bb to avoid unnecessary duplication which leads to
>> confusion down the road.
>
> Yes, I think we should remove LIC_FILES_CHKSUM from u-boot_git.bb.
> Should I remove it and repost the patch?


I've sent a couple patches to address this and some other existing 
issues. You were CC'd and Richard has merged with master. This should 
get us to a state that works for all known usage, holler if they cause 
you any undue pain. :-)

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel