Re: [PATCH 3/3] u-boot: compile with -O2 on PowerPC

[Darren Hart <dvhart@linux.intel.com>]

On 02/09/2011 10:05 AM, Adrian Alonso wrote:
> I observe that with current gcc for powerpc uboot only builds with
> OPTFLAGS=-O2, unsetting or using other OPT level the build fails
> with undefined symbols.
>
> I override the OPTFLAGS in the dedicated recipe for uboot under
> meta-xilinx BSP
> but for powerpc targets in main meta layer Ilya approach does the work.

I see - shouldn't be reviewing patches with a head cold. I wonder if the 
-O2 would work with ARM as well. If so, we could just set OPTFLAGS to 
-O2 instead of '' for all architectures. I'd much prefer that if 
possible, I'll test on ARM.

--
Darren

>
> On Wed, Feb 9, 2011 at 11:42 AM, Darren Hart <dvhart@linux.intel.com
> <mailto:dvhart@linux.intel.com>> wrote:
>
>     On 02/08/2011 12:26 PM, Ilya Yanok wrote:
>
>         gcc on PowerPC is currently compiled with -Os optimization
>         disabled so
>         we have to use -O2 on PowerPC instead.
>
>         Signed-off-by: Ilya Yanok<yanok@emcraft.com
>         <mailto:yanok@emcraft.com>>
>         ---
>           meta/recipes-bsp/uboot/u-boot.inc |    7 ++++++-
>           1 files changed, 6 insertions(+), 1 deletions(-)
>
>         diff --git a/meta/recipes-bsp/uboot/u-boot.inc
>         b/meta/recipes-bsp/uboot/u-boot.inc
>         index 6492016..7694c77 100644
>         --- a/meta/recipes-bsp/uboot/u-boot.inc
>         +++ b/meta/recipes-bsp/uboot/u-boot.inc
>         @@ -22,7 +22,12 @@ do_compile () {
>                 unset CFLAGS
>                 unset CPPFLAGS
>                 oe_runmake ${UBOOT_MACHINE}
>         -       oe_runmake all
>         +       # -Os is disabled on PowerPC
>         +       if [ ${TARGET_ARCH} == "powerpc" ] ; then
>         +               oe_runmake OPTFLAGS=-O2 all
>         +       else
>         +               oe_runmake all
>         +       fi
>
>
>
>     This is already disabled in u-boot.inc with the following line:
>
>     # GCC 4.5.1 builds unusable binaries using -Os, remove it from OPTFLAGS
>     EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''"
>
>     Resetting OPTFLAGS to '' removes the -Os from the variable in the
>     Makefile. This isn't just a PowerPC problem, it also manifested on
>     ARM, I believe it is a GCC 4.5.1 issue.
>
>     --
>     Darren Hart
>     Intel Open Source Technology Center
>     Yocto Project - Linux Kernel
>
>     _______________________________________________
>     poky mailing list
>     poky@yoctoproject.org <mailto:poky@yoctoproject.org>
>     https://lists.yoctoproject.org/listinfo/poky
>
>


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel