From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed
Date: Wed, 16 Feb 2011 15:35:28 +0300 [thread overview]
Message-ID: <4D5BC490.4060809@ru.mvista.com> (raw)
In-Reply-To: <1297858285-7056-2-git-send-email-rnayak@ti.com>
Hello.
On 16.02.2011 15:11, Rajendra Nayak wrote:
> Add a hwmod state check in the _setup function
> to avoid setting up hwmods' for which clock
> lookup has failed.
> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
[...]
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index e282e35..cd9dcde 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -1362,6 +1362,12 @@ static int _setup(struct omap_hwmod *oh, void *data)
> int i, r;
> u8 postsetup_state;
>
> + if (oh->_state != _HWMOD_STATE_CLKS_INITED) {
> + WARN(1, "omap_hwmod: %s: _setup failed as one or more"
You forgot space bafore " -- "moreclock" will be printed.
> + "clock lookups' have failed\n", oh->name);
Why there's apostrophe here?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed
Date: Wed, 16 Feb 2011 15:35:28 +0300 [thread overview]
Message-ID: <4D5BC490.4060809@ru.mvista.com> (raw)
In-Reply-To: <1297858285-7056-2-git-send-email-rnayak@ti.com>
Hello.
On 16.02.2011 15:11, Rajendra Nayak wrote:
> Add a hwmod state check in the _setup function
> to avoid setting up hwmods' for which clock
> lookup has failed.
> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
[...]
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index e282e35..cd9dcde 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -1362,6 +1362,12 @@ static int _setup(struct omap_hwmod *oh, void *data)
> int i, r;
> u8 postsetup_state;
>
> + if (oh->_state != _HWMOD_STATE_CLKS_INITED) {
> + WARN(1, "omap_hwmod: %s: _setup failed as one or more"
You forgot space bafore " -- "moreclock" will be printed.
> + "clock lookups' have failed\n", oh->name);
Why there's apostrophe here?
WBR, Sergei
next prev parent reply other threads:[~2011-02-16 12:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 12:11 [PATCH 0/3] OMAP2+ hwmod fixes Rajendra Nayak
2011-02-16 12:11 ` Rajendra Nayak
2011-02-16 12:11 ` [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed Rajendra Nayak
2011-02-16 12:11 ` Rajendra Nayak
2011-02-16 12:11 ` [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns Rajendra Nayak
2011-02-16 12:11 ` Rajendra Nayak
2011-02-16 12:11 ` [PATCH 3/3] OMAP2+: hwmod: Do not break iterator fn's if one fails Rajendra Nayak
2011-02-16 12:11 ` Rajendra Nayak
2011-02-18 14:51 ` [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns Cousson, Benoit
2011-02-18 14:51 ` Cousson, Benoit
2011-02-16 12:35 ` Sergei Shtylyov [this message]
2011-02-16 12:35 ` [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed Sergei Shtylyov
2011-02-18 17:34 ` Cousson, Benoit
2011-02-18 17:34 ` Cousson, Benoit
2011-02-16 13:07 ` [PATCH 0/3] OMAP2+ hwmod fixes Cousson, Benoit
2011-02-16 13:07 ` Cousson, Benoit
2011-02-16 13:43 ` Rajendra Nayak
2011-02-16 13:43 ` Rajendra Nayak
2011-02-18 14:44 ` Cousson, Benoit
2011-02-18 14:44 ` Cousson, Benoit
2011-02-21 16:55 ` Paul Walmsley
2011-02-21 16:55 ` Paul Walmsley
2011-02-22 13:11 ` Rajendra Nayak
2011-02-22 13:11 ` Rajendra Nayak
2011-02-22 19:09 ` Paul Walmsley
2011-02-22 19:09 ` Paul Walmsley
2011-02-23 10:05 ` Rajendra Nayak
2011-02-23 10:05 ` Rajendra Nayak
2011-03-01 16:57 ` Cousson, Benoit
2011-03-01 16:57 ` Cousson, Benoit
2011-03-03 6:08 ` Paul Walmsley
2011-03-03 6:08 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5BC490.4060809@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.