All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Nayak, Rajendra" <rnayak@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"paul@pwsan.com" <paul@pwsan.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/3] OMAP2+ hwmod fixes
Date: Wed, 16 Feb 2011 14:07:28 +0100	[thread overview]
Message-ID: <4D5BCC10.2060301@ti.com> (raw)
In-Reply-To: <1297858285-7056-1-git-send-email-rnayak@ti.com>

Hi Rajendra,

On 2/16/2011 1:11 PM, Nayak, Rajendra wrote:
> This series fixes some hwmod api return values
> and also adds some state checks.
> The hwmod iterator functions are made to
> continue and not break if one of the
> callback functions ends up with an error.

By doing that, you change the behavior of this function.
I'm not sure I fully understand why.
Could you elaborate on the use case?

To avoid that behavior in the past, I was just returning
0 in case of failure to avoid stopping the iteration.
It looks like you do not want to stop the iteration but still
retrieve the error.
I do not see in this series what you plan to do with the
error at the end of the iteration.

Thanks,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] OMAP2+ hwmod fixes
Date: Wed, 16 Feb 2011 14:07:28 +0100	[thread overview]
Message-ID: <4D5BCC10.2060301@ti.com> (raw)
In-Reply-To: <1297858285-7056-1-git-send-email-rnayak@ti.com>

Hi Rajendra,

On 2/16/2011 1:11 PM, Nayak, Rajendra wrote:
> This series fixes some hwmod api return values
> and also adds some state checks.
> The hwmod iterator functions are made to
> continue and not break if one of the
> callback functions ends up with an error.

By doing that, you change the behavior of this function.
I'm not sure I fully understand why.
Could you elaborate on the use case?

To avoid that behavior in the past, I was just returning
0 in case of failure to avoid stopping the iteration.
It looks like you do not want to stop the iteration but still
retrieve the error.
I do not see in this series what you plan to do with the
error at the end of the iteration.

Thanks,
Benoit

  parent reply	other threads:[~2011-02-16 13:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16 12:11 [PATCH 0/3] OMAP2+ hwmod fixes Rajendra Nayak
2011-02-16 12:11 ` Rajendra Nayak
2011-02-16 12:11 ` [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed Rajendra Nayak
2011-02-16 12:11   ` Rajendra Nayak
2011-02-16 12:11   ` [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns Rajendra Nayak
2011-02-16 12:11     ` Rajendra Nayak
2011-02-16 12:11     ` [PATCH 3/3] OMAP2+: hwmod: Do not break iterator fn's if one fails Rajendra Nayak
2011-02-16 12:11       ` Rajendra Nayak
2011-02-18 14:51     ` [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns Cousson, Benoit
2011-02-18 14:51       ` Cousson, Benoit
2011-02-16 12:35   ` [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed Sergei Shtylyov
2011-02-16 12:35     ` Sergei Shtylyov
2011-02-18 17:34   ` Cousson, Benoit
2011-02-18 17:34     ` Cousson, Benoit
2011-02-16 13:07 ` Cousson, Benoit [this message]
2011-02-16 13:07   ` [PATCH 0/3] OMAP2+ hwmod fixes Cousson, Benoit
2011-02-16 13:43   ` Rajendra Nayak
2011-02-16 13:43     ` Rajendra Nayak
2011-02-18 14:44     ` Cousson, Benoit
2011-02-18 14:44       ` Cousson, Benoit
2011-02-21 16:55       ` Paul Walmsley
2011-02-21 16:55         ` Paul Walmsley
2011-02-22 13:11         ` Rajendra Nayak
2011-02-22 13:11           ` Rajendra Nayak
2011-02-22 19:09           ` Paul Walmsley
2011-02-22 19:09             ` Paul Walmsley
2011-02-23 10:05             ` Rajendra Nayak
2011-02-23 10:05               ` Rajendra Nayak
2011-03-01 16:57               ` Cousson, Benoit
2011-03-01 16:57                 ` Cousson, Benoit
2011-03-03  6:08                 ` Paul Walmsley
2011-03-03  6:08                   ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5BCC10.2060301@ti.com \
    --to=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.