[PATCH v2] oestats-client: only send report when task has failed

[PATCH v2] oestats-client: only send report when task has failed

[Eric Bénard]

actual behaviour is to send a report for *each* task runned by bitbake
this is ok for one personnal oestat server but doesn't scale well when
dozen of peoples are running test builders which all send reports to
the OE's infrastructure.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
v2: cleaner way to handle the problem as per pb & Jay2 suggestion

 classes/oestats-client.bbclass |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/classes/oestats-client.bbclass b/classes/oestats-client.bbclass
index 4233d4a..f9ac88f 100644
--- a/classes/oestats-client.bbclass
+++ b/classes/oestats-client.bbclass
@@ -202,8 +202,10 @@ python oestats_eventhandler () {
 		oestats_stop(server, e.data, e.getFailures())
 	elif getName(e) == 'TaskStarted':
 		bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
-	elif getName(e) == 'TaskSucceeded':
-		oestats_task(server, e.data, e.task, 'Succeeded')
+	# Temporary disable sending sucess report as this generates to much trafic
+	# for the oestat server
+	# elif getName(e) == 'TaskSucceeded':
+	#	oestats_task(server, e.data, e.task, 'Succeeded')
 	elif getName(e) == 'TaskFailed':
 		oestats_task(server, e.data, e.task, 'Failed')
 }
-- 
1.7.0.4

Re: [PATCH v2] oestats-client: only send report when task has failed

[Yury Bushmelev]

2011/2/18 Eric Bénard <eric@eukrea.com>:
> actual behaviour is to send a report for *each* task runned by bitbake
> this is ok for one personnal oestat server but doesn't scale well when
> dozen of peoples are running test builders which all send reports to
> the OE's infrastructure.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>

I'm Ack'ing it as temporary solution to keep oestats server running..

Acked-by: Yury Bushmelev <jay4mail@gmail.com>

> ---
> v2: cleaner way to handle the problem as per pb & Jay2 suggestion
>
>  classes/oestats-client.bbclass |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/classes/oestats-client.bbclass b/classes/oestats-client.bbclass
> index 4233d4a..f9ac88f 100644
> --- a/classes/oestats-client.bbclass
> +++ b/classes/oestats-client.bbclass
> @@ -202,8 +202,10 @@ python oestats_eventhandler () {
>                oestats_stop(server, e.data, e.getFailures())
>        elif getName(e) == 'TaskStarted':
>                bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
> -       elif getName(e) == 'TaskSucceeded':
> -               oestats_task(server, e.data, e.task, 'Succeeded')
> +       # Temporary disable sending sucess report as this generates to much trafic
> +       # for the oestat server
> +       # elif getName(e) == 'TaskSucceeded':
> +       #       oestats_task(server, e.data, e.task, 'Succeeded')
>        elif getName(e) == 'TaskFailed':
>                oestats_task(server, e.data, e.task, 'Failed')
>  }
> --
> 1.7.0.4

-- 
Yury Bushmelev

Re: [PATCH v2] oestats-client: only send report when task has failed

[Khem Raj]

On Fri, Feb 18, 2011 at 2:58 AM, Eric Bénard <eric@eukrea.com> wrote:
> actual behaviour is to send a report for *each* task runned by bitbake
> this is ok for one personnal oestat server but doesn't scale well when
> dozen of peoples are running test builders which all send reports to
> the OE's infrastructure.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> v2: cleaner way to handle the problem as per pb & Jay2 suggestion
>
>  classes/oestats-client.bbclass |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/classes/oestats-client.bbclass b/classes/oestats-client.bbclass
> index 4233d4a..f9ac88f 100644
> --- a/classes/oestats-client.bbclass
> +++ b/classes/oestats-client.bbclass
> @@ -202,8 +202,10 @@ python oestats_eventhandler () {
>                oestats_stop(server, e.data, e.getFailures())
>        elif getName(e) == 'TaskStarted':
>                bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
> -       elif getName(e) == 'TaskSucceeded':
> -               oestats_task(server, e.data, e.task, 'Succeeded')
> +       # Temporary disable sending sucess report as this generates to much trafic
> +       # for the oestat server
> +       # elif getName(e) == 'TaskSucceeded':
> +       #       oestats_task(server, e.data, e.task, 'Succeeded')
>        elif getName(e) == 'TaskFailed':
>                oestats_task(server, e.data, e.task, 'Failed')
>  }


will this mean that only failed packages show up on tinderbox ?
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH v2] oestats-client: only send report when task has failed

[Eric Bénard]

Hi Khem,

On 18/02/2011 16:35, Khem Raj wrote:
> On Fri, Feb 18, 2011 at 2:58 AM, Eric Bénard<eric@eukrea.com>  wrote:
>> actual behaviour is to send a report for *each* task runned by bitbake
>> this is ok for one personnal oestat server but doesn't scale well when
>> dozen of peoples are running test builders which all send reports to
>> the OE's infrastructure.
>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>
>> ---
>> v2: cleaner way to handle the problem as per pb&  Jay2 suggestion
>>
>>   classes/oestats-client.bbclass |    6 ++++--
>>   1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/classes/oestats-client.bbclass b/classes/oestats-client.bbclass
>> index 4233d4a..f9ac88f 100644
>> --- a/classes/oestats-client.bbclass
>> +++ b/classes/oestats-client.bbclass
>> @@ -202,8 +202,10 @@ python oestats_eventhandler () {
>>                 oestats_stop(server, e.data, e.getFailures())
>>         elif getName(e) == 'TaskStarted':
>>                 bb.data.setVar('OESTATS_STAMP', repr(time.time()), e.data)
>> -       elif getName(e) == 'TaskSucceeded':
>> -               oestats_task(server, e.data, e.task, 'Succeeded')
>> +       # Temporary disable sending sucess report as this generates to much trafic
>> +       # for the oestat server
>> +       # elif getName(e) == 'TaskSucceeded':
>> +       #       oestats_task(server, e.data, e.task, 'Succeeded')
>>         elif getName(e) == 'TaskFailed':
>>                 oestats_task(server, e.data, e.task, 'Failed')
>>   }
>
>
> will this mean that only failed packages show up on tinderbox ?

exactly. this is a temporary solution and I think this is better than no more 
having tinderbox running.

Eric