All of lore.kernel.org
 help / color / mirror / Atom feed
* git and BB_NO_NETWORK
@ 2011-02-23 15:19 Gary Thomas
  2011-02-23 23:57 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Gary Thomas @ 2011-02-23 15:19 UTC (permalink / raw)
  To: Poky

This is related to bug #752

Richard has made some changes which nearly fixes that bug, except
for the mtd-utils_1.4.1.bb recipe.  The problem with this recipe
is that it specifies a git tag, not a fixed revision.  The fetcher
fails in this case as it has to interrogate the git tree to find
the tag and that's not allowed because of BB_NO_NETWORK=1

I tried to move this to a fixed revision which corresponds to tag v1.4.1
like this:

diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
index 5e6db0e..2c4e276 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
@@ -6,11 +6,12 @@ LICENSE = "GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
                      file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"

-SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=v${PV} \
+SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git \
                 file://add-exclusion-to-mkfs-jffs2-git-2.patch;patch=1"

  S = "${WORKDIR}/git/"

+PV = "1.4.1${SRCPV}"
  PR = "r1"

  EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"

I also added this to my fixed-revisions.inc
SRCREV_pn-mtd-utils ??= "3c3674a6e1d3f59554b0ff68ca59be2fd4134e0c"

Finally, I had to move recipes-devtools/mtd/mtd-utils-1.4.1/add-exclusion-to-mkfs-jffs2-git-2.patch
to recipes-devtools/mtd/mtd-utils or else it could not be found.

Is there an easier way to solve these issues?  Once I understand the whole process, I can
propose a patch.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: git and BB_NO_NETWORK
  2011-02-23 15:19 git and BB_NO_NETWORK Gary Thomas
@ 2011-02-23 23:57 ` Richard Purdie
  2011-02-24  0:29   ` Gary Thomas
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2011-02-23 23:57 UTC (permalink / raw)
  To: Gary Thomas; +Cc: Poky

On Wed, 2011-02-23 at 08:19 -0700, Gary Thomas wrote:
> This is related to bug #752
> 
> Richard has made some changes which nearly fixes that bug, except
> for the mtd-utils_1.4.1.bb recipe.  The problem with this recipe
> is that it specifies a git tag, not a fixed revision.  The fetcher
> fails in this case as it has to interrogate the git tree to find
> the tag and that's not allowed because of BB_NO_NETWORK=1
> 
> I tried to move this to a fixed revision which corresponds to tag v1.4.1
> like this:
> 
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
> index 5e6db0e..2c4e276 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
> @@ -6,11 +6,12 @@ LICENSE = "GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>                       file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"
> 
> -SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=v${PV} \
> +SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git \
>                  file://add-exclusion-to-mkfs-jffs2-git-2.patch;patch=1"
> 
>   S = "${WORKDIR}/git/"
> 
> +PV = "1.4.1${SRCPV}"
>   PR = "r1"
> 
>   EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> 
> I also added this to my fixed-revisions.inc
> SRCREV_pn-mtd-utils ??= "3c3674a6e1d3f59554b0ff68ca59be2fd4134e0c"
> 
> Finally, I had to move recipes-devtools/mtd/mtd-utils-1.4.1/add-exclusion-to-mkfs-jffs2-git-2.patch
> to recipes-devtools/mtd/mtd-utils or else it could not be found.
> 
> Is there an easier way to solve these issues?  Once I understand the whole process, I can
> propose a patch.

I think these issues were discussed and resolved in the bugzilla?

http://bugzilla.pokylinux.org/show_bug.cgi?id=752

In future please try and keep the discussions in one place, not both, or
state on the bugzilla you're moving it to email.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git and BB_NO_NETWORK
  2011-02-23 23:57 ` Richard Purdie
@ 2011-02-24  0:29   ` Gary Thomas
  0 siblings, 0 replies; 3+ messages in thread
From: Gary Thomas @ 2011-02-24  0:29 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Poky

On 02/23/2011 04:57 PM, Richard Purdie wrote:
> On Wed, 2011-02-23 at 08:19 -0700, Gary Thomas wrote:
>> This is related to bug #752
>>
>> Richard has made some changes which nearly fixes that bug, except
>> for the mtd-utils_1.4.1.bb recipe.  The problem with this recipe
>> is that it specifies a git tag, not a fixed revision.  The fetcher
>> fails in this case as it has to interrogate the git tree to find
>> the tag and that's not allowed because of BB_NO_NETWORK=1
>>
>> I tried to move this to a fixed revision which corresponds to tag v1.4.1
>> like this:
>>
>> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> index 5e6db0e..2c4e276 100644
>> --- a/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.4.1.bb
>> @@ -6,11 +6,12 @@ LICENSE = "GPLv2+"
>>    LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>                        file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"
>>
>> -SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=v${PV} \
>> +SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git \
>>                   file://add-exclusion-to-mkfs-jffs2-git-2.patch;patch=1"
>>
>>    S = "${WORKDIR}/git/"
>>
>> +PV = "1.4.1${SRCPV}"
>>    PR = "r1"
>>
>>    EXTRA_OEMAKE = "'CC=${CC}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>>
>> I also added this to my fixed-revisions.inc
>> SRCREV_pn-mtd-utils ??= "3c3674a6e1d3f59554b0ff68ca59be2fd4134e0c"
>>
>> Finally, I had to move recipes-devtools/mtd/mtd-utils-1.4.1/add-exclusion-to-mkfs-jffs2-git-2.patch
>> to recipes-devtools/mtd/mtd-utils or else it could not be found.
>>
>> Is there an easier way to solve these issues?  Once I understand the whole process, I can
>> propose a patch.
>
> I think these issues were discussed and resolved in the bugzilla?
>
> http://bugzilla.pokylinux.org/show_bug.cgi?id=752
>
> In future please try and keep the discussions in one place, not both, or
> state on the bugzilla you're moving it to email.

Of course.  Actually, it was the other way around, I first
send this to the list in case someone other than you (overworked,
I'm sure) had an idea.  I copied it to the bug just for reference.

Both bugs #752 & 753 seem to be taken care of now.

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-24  0:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 15:19 git and BB_NO_NETWORK Gary Thomas
2011-02-23 23:57 ` Richard Purdie
2011-02-24  0:29   ` Gary Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.