All of lore.kernel.org
 help / color / mirror / Atom feed
* [Printing-architecture] Qt only CPD.
@ 2011-02-26  4:00 Hal V. Engel
  2011-02-26 13:02 ` Till Kamppeter
  0 siblings, 1 reply; 6+ messages in thread
From: Hal V. Engel @ 2011-02-26  4:00 UTC (permalink / raw)
  To: Till Kamppeter, Printing-architecture, Lars Uebernickel

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Till expressed some concerns about how much effort it would take to convert the 
KDE CPD to a pure Qt app.  Just to let eveyone know I have now removed all KDE 
calls from the core CPD code and I have a working Qt only CPD on my system. 

There is still some stuff that needs to be done.   The view-dialog test app 
code still has some KDE widgets (KCmdLineArgs and KAboutData) that I will 
remove tomorrow and the build will need to have kde references removed.   I 
will need to clean everything up as well but it actaully took less effort than 
I had thought to remove the KDE specific widgets from the CPD core code.

Hal    

[-- Attachment #2: Type: text/html, Size: 1715 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Printing-architecture] Qt only CPD.
  2011-02-26  4:00 [Printing-architecture] Qt only CPD Hal V. Engel
@ 2011-02-26 13:02 ` Till Kamppeter
  2011-02-26 16:16   ` Hal V. Engel
  0 siblings, 1 reply; 6+ messages in thread
From: Till Kamppeter @ 2011-02-26 13:02 UTC (permalink / raw)
  To: Hal V. Engel; +Cc: Printing-architecture, Lars Uebernickel

Great news. Please commit it to the BZR. You can already commit the 
changes on the core CPD. And after you finished the test app, commit 
these changes, too.

    Till

On 02/26/2011 05:00 AM, Hal V. Engel wrote:
> Till expressed some concerns about how much effort it would take to
> convert the KDE CPD to a pure Qt app. Just to let eveyone know I have
> now removed all KDE calls from the core CPD code and I have a working Qt
> only CPD on my system.
>
>
> There is still some stuff that needs to be done. The view-dialog test
> app code still has some KDE widgets (KCmdLineArgs and KAboutData) that I
> will remove tomorrow and the build will need to have kde references
> removed. I will need to clean everything up as well but it actaully took
> less effort than I had thought to remove the KDE specific widgets from
> the CPD core code.
>
>
> Hal
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Printing-architecture] Qt only CPD.
  2011-02-26 13:02 ` Till Kamppeter
@ 2011-02-26 16:16   ` Hal V. Engel
  2011-02-26 18:48     ` Till Kamppeter
  0 siblings, 1 reply; 6+ messages in thread
From: Hal V. Engel @ 2011-02-26 16:16 UTC (permalink / raw)
  To: Till Kamppeter, Lars Uebernickel; +Cc: Printing-architecture

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

On Saturday, February 26, 2011 05:02:47 AM Till Kamppeter wrote:
> Great news. Please commit it to the BZR. You can already commit the
> changes on the core CPD. And after you finished the test app, commit
> these changes, too.
> 
>     Till

Till & Lars,

I already have the test app using Qt calls only at this point since it only 
took about 1/2 hour to do.  Since I have not used BZR before I will spend some 
time getting a handle on what I need to do and then commit the changes after 
doing a little clean up on the code.  I will also see what I can do to clean 
up the build over the next day or two and then commit those changes.

Is there a todo document/list some place that covers what work is needed for 
the Qt CPD?  Or is this something that we need to work out as things are 
getting underway?    

Hal

> 
> On 02/26/2011 05:00 AM, Hal V. Engel wrote:
> > Till expressed some concerns about how much effort it would take to
> > convert the KDE CPD to a pure Qt app. Just to let eveyone know I have
> > now removed all KDE calls from the core CPD code and I have a working Qt
> > only CPD on my system.
> > 
> > 
> > There is still some stuff that needs to be done. The view-dialog test
> > app code still has some KDE widgets (KCmdLineArgs and KAboutData) that I
> > will remove tomorrow and the build will need to have kde references
> > removed. I will need to clean everything up as well but it actaully took
> > less effort than I had thought to remove the KDE specific widgets from
> > the CPD core code.
> > 
> > 
> > Hal

[-- Attachment #2: Type: text/html, Size: 6818 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Printing-architecture] Qt only CPD.
  2011-02-26 16:16   ` Hal V. Engel
@ 2011-02-26 18:48     ` Till Kamppeter
  2011-02-26 21:40       ` Hal V. Engel
  0 siblings, 1 reply; 6+ messages in thread
From: Till Kamppeter @ 2011-02-26 18:48 UTC (permalink / raw)
  To: Hal V. Engel; +Cc: Printing-architecture, Lars Uebernickel

On 02/26/2011 05:16 PM, Hal V. Engel wrote:
> I already have the test app using Qt calls only at this point since it
> only took about 1/2 hour to do. Since I have not used BZR before I will
> spend some time getting a handle on what I need to do and then commit
> the changes after doing a little clean up on the code. I will also see
> what I can do to clean up the build over the next day or two and then
> commit those changes.

A short introduction for using BZR you find here:

https://www.linuxfoundation.org/collaborate/workgroups/openprinting/database/instructionsforcontributors

> Is there a todo document/list some place that covers what work is needed
> for the Qt CPD? Or is this something that we need to work out as things
> are getting underway?

Here you find the TODO list of the whole project:

https://www.linuxfoundation.org/collaborate/workgroups/openprinting/plan-completion-common-printing-dialog

    Till

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Printing-architecture] Qt only CPD.
  2011-02-26 18:48     ` Till Kamppeter
@ 2011-02-26 21:40       ` Hal V. Engel
  2011-02-26 21:49         ` Till Kamppeter
  0 siblings, 1 reply; 6+ messages in thread
From: Hal V. Engel @ 2011-02-26 21:40 UTC (permalink / raw)
  To: Till Kamppeter; +Cc: Printing-architecture, Lars Uebernickel

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

On Saturday, February 26, 2011 10:48:55 AM Till Kamppeter wrote:
> On 02/26/2011 05:16 PM, Hal V. Engel wrote:
> > I already have the test app using Qt calls only at this point since it
> > only took about 1/2 hour to do. Since I have not used BZR before I will
> > spend some time getting a handle on what I need to do and then commit
> > the changes after doing a little clean up on the code. I will also see
> > what I can do to clean up the build over the next day or two and then
> > commit those changes.
> 
> A short introduction for using BZR you find here:
> 
> https://www.linuxfoundation.org/collaborate/workgroups/openprinting/databas
> e/instructionsforcontributors
> 
> > Is there a todo document/list some place that covers what work is needed
> > for the Qt CPD? Or is this something that we need to work out as things
> > are getting underway?
> 
> Here you find the TODO list of the whole project:
> 
> https://www.linuxfoundation.org/collaborate/workgroups/openprinting/plan-co
> mpletion-common-printing-dialog
> 
>     Till

Thanks that helped.  I think I commited my current changes.  At least the 
messages I got looked like it worked.  But it does not apear to show up in the 
web interface to the repository.  But perhaps that needs some time to sync up.  
Please feel free to give the dialog a test run if it actually made it into the 
repository.  The dialog looks and behaves just like the original version for 
the most part.  Things related to this that still need to be done:

1.  I did not do much with the cmake setup as I am far from an expert on how 
cmake does things and I wanted to get the rest of this checked in.  So this 
still needs to be modified to remove kde references.

2.  I had to add some icon files that where apparently included in KDE.  An 
application resource needs to be created for these and the code modified to use 
the resource instead of the files.

3. The directory should probably be renamed from kde4-dialog to qt4-dialog.

Hal

[-- Attachment #2: Type: text/html, Size: 7352 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Printing-architecture] Qt only CPD.
  2011-02-26 21:40       ` Hal V. Engel
@ 2011-02-26 21:49         ` Till Kamppeter
  0 siblings, 0 replies; 6+ messages in thread
From: Till Kamppeter @ 2011-02-26 21:49 UTC (permalink / raw)
  To: Hal V. Engel; +Cc: Printing-architecture, Lars Uebernickel

On 02/26/2011 10:40 PM, Hal V. Engel wrote:
> Thanks that helped. I think I commited my current changes. At least the
> messages I got looked like it worked. But it does not apear to show up
> in the web interface to the repository. But perhaps that needs some time
> to sync up.

Up to now nothing arrived. Did you use "bzr push ..." or the Patch Queue 
Manager (PQM)? Note that the requests send to the patch queue manager 
are not applied immediately, but by a cron job. Perhaps you only got 
confirmation of the submission and not of the actual application of your 
changes.

> Please feel free to give the dialog a test run if it
> actually made it into the repository. The dialog looks and behaves just
> like the original version for the most part. Things related to this that
> still need to be done:
>

I will try the dialog a soon as I find it on the BZR.

>
> 1. I did not do much with the cmake setup as I am far from an expert on
> how cmake does things and I wanted to get the rest of this checked in.
> So this still needs to be modified to remove kde references.
>
>
> 2. I had to add some icon files that where apparently included in KDE.
> An application resource needs to be created for these and the code
> modified to use the resource instead of the files.
>
>
> 3. The directory should probably be renamed from kde4-dialog to qt4-dialog.

Can you please do these corrections to complete the change to Qt-only? I 
do not know, but is cmake KDE-specific or can it also be used for a 
non-KDE application like the pure Qt CPD?

    Till

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-26 21:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-26  4:00 [Printing-architecture] Qt only CPD Hal V. Engel
2011-02-26 13:02 ` Till Kamppeter
2011-02-26 16:16   ` Hal V. Engel
2011-02-26 18:48     ` Till Kamppeter
2011-02-26 21:40       ` Hal V. Engel
2011-02-26 21:49         ` Till Kamppeter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.