All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org,
	ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: EXYNOS4: Adds Samsung NURI board support
Date: Mon, 28 Feb 2011 17:14:01 +0900	[thread overview]
Message-ID: <4D6B5949.8020606@samsung.com> (raw)
In-Reply-To: <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com>

Dear Kukjin Kim,

2011-02-28 오후 4:42, Kukjin Kim 쓴 글:
> Minkyu Kang wrote:
>>
>> This patch adds Samsung NURI board support.
>>
>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> This patch is base on next-exynos4 branch at kgene tree.
>>
>>  arch/arm/configs/exynos4_defconfig |    1 +
>>  arch/arm/mach-exynos4/Kconfig      |   15 +++
>>  arch/arm/mach-exynos4/Makefile     |    1 +
>>  arch/arm/mach-exynos4/mach-nuri.c  |  233
>> ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 250 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/mach-exynos4/mach-nuri.c
>>
> 
>> +enum fixed_regulator_id {
>> +	FIXED_REG_ID_MMC = 0,
> 
> 	FIXED_REG_ID_MMC,
> 
> (snip)
> 
>> +static struct platform_device emmc_fixed_voltage = {
>> +	.name			= "reg-fixed-voltage",
>> +	.id			= FIXED_REG_ID_MMC,
> 
> Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?
> 

I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on.
So use enum values for avoid the hard coding.

Thanks.
Minkyu Kang.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: mk7.kang@samsung.com (Minkyu Kang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS4: Adds Samsung NURI board support
Date: Mon, 28 Feb 2011 17:14:01 +0900	[thread overview]
Message-ID: <4D6B5949.8020606@samsung.com> (raw)
In-Reply-To: <002301cbd71b$1969bd00$4c3d3700$%kim@samsung.com>

Dear Kukjin Kim,

2011-02-28 ?? 4:42, Kukjin Kim ? ?:
> Minkyu Kang wrote:
>>
>> This patch adds Samsung NURI board support.
>>
>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> This patch is base on next-exynos4 branch at kgene tree.
>>
>>  arch/arm/configs/exynos4_defconfig |    1 +
>>  arch/arm/mach-exynos4/Kconfig      |   15 +++
>>  arch/arm/mach-exynos4/Makefile     |    1 +
>>  arch/arm/mach-exynos4/mach-nuri.c  |  233
>> ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 250 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/mach-exynos4/mach-nuri.c
>>
> 
>> +enum fixed_regulator_id {
>> +	FIXED_REG_ID_MMC = 0,
> 
> 	FIXED_REG_ID_MMC,
> 
> (snip)
> 
>> +static struct platform_device emmc_fixed_voltage = {
>> +	.name			= "reg-fixed-voltage",
>> +	.id			= FIXED_REG_ID_MMC,
> 
> Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?
> 

I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on.
So use enum values for avoid the hard coding.

Thanks.
Minkyu Kang.

  reply	other threads:[~2011-02-28  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25  8:43 [PATCH] ARM: EXYNOS4: Adds Samsung NURI board support Minkyu Kang
2011-02-25  8:43 ` Minkyu Kang
2011-02-28  7:42 ` Kukjin Kim
2011-02-28  7:42   ` Kukjin Kim
2011-02-28  8:14   ` Minkyu Kang [this message]
2011-02-28  8:14     ` Minkyu Kang
2011-02-28  8:26     ` Kukjin Kim
2011-02-28  8:26       ` Kukjin Kim
2011-02-28 11:20       ` Kukjin Kim
2011-02-28 11:20         ` Kukjin Kim
2011-03-04  7:28       ` Kukjin Kim
2011-03-04  7:28         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6B5949.8020606@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.