All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Jingdong <jingdong.lu@windriver.com>
To: Nitin A Kamble <nitin.a.kamble@intel.com>
Cc: poky@yoctoproject.org, Khem, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6
Date: Wed, 9 Mar 2011 17:45:26 +0800	[thread overview]
Message-ID: <4D774C36.3090807@windriver.com> (raw)
In-Reply-To: <33b26ba051fa171e480bce3a1e4497a619241176.1299633840.git.nitin.a.kamble@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

On 03/09/2011 09:26 AM, Nitin A Kamble wrote:
>   .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++
>   meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-
>   2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 6cc11e2..2d214af 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -1,5 +1,8 @@
>   require gcc-configure-common.inc
>
> +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden',
> +'${CXXFLAGS}', d)}"
> +
I think it should be

CXXFLAGS*:=*  "${@oe_filter_out('-fvisibility-inlines-hidden',
'${CXXFLAGS}', d)}"

otherwise it will give the following error log.
NOTE: Error expanding variable CXXFLAGS###############################################################                                 | ETA:  00:00:00
ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself!

It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error.

>   EXTRA_OECONF_PATHS = " \
>       --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \
>       --with-gxx-include-dir=${includedir}/c++/ \
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> index 093f9bf..c1e680d 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> @@ -1,4 +1,4 @@
> -PR = "r2"
> +PR = "r3"
>
>   require gcc-${PV}.inc
>   require gcc-configure-runtime.inc


-- 
Lu Jingdong
jingdong.lu@windriver.com
China, Wind River


[-- Attachment #2: Type: text/html, Size: 2475 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Lu Jingdong <jingdong.lu@windriver.com>
To: Nitin A Kamble <nitin.a.kamble@intel.com>
Cc: poky@yoctoproject.org, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6
Date: Wed, 9 Mar 2011 17:45:26 +0800	[thread overview]
Message-ID: <4D774C36.3090807@windriver.com> (raw)
In-Reply-To: <33b26ba051fa171e480bce3a1e4497a619241176.1299633840.git.nitin.a.kamble@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

On 03/09/2011 09:26 AM, Nitin A Kamble wrote:
>   .../recipes-devtools/gcc/gcc-configure-runtime.inc |    3 +++
>   meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb     |    2 +-
>   2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 6cc11e2..2d214af 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -1,5 +1,8 @@
>   require gcc-configure-common.inc
>
> +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden',
> +'${CXXFLAGS}', d)}"
> +
I think it should be

CXXFLAGS*:=*  "${@oe_filter_out('-fvisibility-inlines-hidden',
'${CXXFLAGS}', d)}"

otherwise it will give the following error log.
NOTE: Error expanding variable CXXFLAGS###############################################################                                 | ETA:  00:00:00
ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself!

It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error.

>   EXTRA_OECONF_PATHS = " \
>       --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \
>       --with-gxx-include-dir=${includedir}/c++/ \
> diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> index 093f9bf..c1e680d 100644
> --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb
> @@ -1,4 +1,4 @@
> -PR = "r2"
> +PR = "r3"
>
>   require gcc-${PV}.inc
>   require gcc-configure-runtime.inc


-- 
Lu Jingdong
jingdong.lu@windriver.com
China, Wind River


[-- Attachment #2: Type: text/html, Size: 2475 bytes --]

  parent reply	other threads:[~2011-03-09 12:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09  1:26 [PATCH 0/1] a bugfix for gcc-runtime recipe Nitin A Kamble
2011-03-09  1:26 ` Nitin A Kamble
2011-03-09  1:26 ` [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 Nitin A Kamble
2011-03-09  1:26   ` Nitin A Kamble
2011-03-09  4:54   ` Khem Raj
2011-03-09  4:54     ` Khem Raj
2011-03-09 19:58     ` Richard Purdie
2011-03-09 19:58       ` [OE-core] " Richard Purdie
2011-03-09 21:18       ` [poky] " Khem Raj
2011-03-09 21:18         ` [OE-core] " Khem Raj
2011-03-09  9:45   ` Lu Jingdong [this message]
2011-03-09  9:45     ` Lu Jingdong
2011-03-09 21:31     ` Kamble, Nitin A
  -- strict thread matches above, loose matches on Subject: below --
2011-03-07 16:55 [PATCH 0/1] fix a LSB test issue Nitin A Kamble
2011-03-07 16:55 ` [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 Nitin A Kamble
2011-03-07 16:55   ` Nitin A Kamble
2011-03-07 17:14   ` Khem Raj
2011-03-08 21:21     ` Kamble, Nitin A
2011-03-08  1:00   ` Lu Jingdong
2011-03-08 15:49     ` Kamble, Nitin A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D774C36.3090807@windriver.com \
    --to=jingdong.lu@windriver.com \
    --cc=nitin.a.kamble@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.