* [PATCH 0/1] a bugfix for gcc-runtime recipe
@ 2011-03-09 1:26 ` Nitin A Kamble
0 siblings, 0 replies; 19+ messages in thread
From: Nitin A Kamble @ 2011-03-09 1:26 UTC (permalink / raw)
To: poky, openembedded-core; +Cc: Jingdong Lu
From: Nitin A Kamble <nitin.a.kamble@intel.com>
More details in the commit email.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: nitin/misc
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Thanks,
Nitin A Kamble <nitin.a.kamble@intel.com>
---
Nitin A Kamble (1):
gcc-runtime: fix LSB library checks for libstdc++.so.6
.../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++
meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +-
2 files changed, 4 insertions(+), 1 deletions(-)
--
1.7.3.4
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 0/1] a bugfix for gcc-runtime recipe @ 2011-03-09 1:26 ` Nitin A Kamble 0 siblings, 0 replies; 19+ messages in thread From: Nitin A Kamble @ 2011-03-09 1:26 UTC (permalink / raw) To: poky, openembedded-core From: Nitin A Kamble <nitin.a.kamble@intel.com> More details in the commit email. Pull URL: git://git.pokylinux.org/poky-contrib.git Branch: nitin/misc Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc Thanks, Nitin A Kamble <nitin.a.kamble@intel.com> --- Nitin A Kamble (1): gcc-runtime: fix LSB library checks for libstdc++.so.6 .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) -- 1.7.3.4 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 1:26 ` Nitin A Kamble @ 2011-03-09 1:26 ` Nitin A Kamble -1 siblings, 0 replies; 19+ messages in thread From: Nitin A Kamble @ 2011-03-09 1:26 UTC (permalink / raw) To: poky, openembedded-core; +Cc: Jingdong Lu From: Nitin A Kamble <nitin.a.kamble@intel.com> [YOCTO #795] When we run library check of LSB on qemux86 and qemuppc, we got some failures about 'libstdc++.so.6'. Test environment: Platform: Qemu-x86, Qemu-ppc lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) Library check of LSB: 4.1.0-1 The error log: Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, char*) const ... found that some weak symbols ('W') change into local ('t') during link time and be stripped. According to compiling log, the option "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak symbols change into local. see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc index 6cc11e2..2d214af 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc @@ -1,5 +1,8 @@ require gcc-configure-common.inc +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', +'${CXXFLAGS}', d)}" + EXTRA_OECONF_PATHS = " \ --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ --with-gxx-include-dir=${includedir}/c++/ \ diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-09 1:26 ` Nitin A Kamble 0 siblings, 0 replies; 19+ messages in thread From: Nitin A Kamble @ 2011-03-09 1:26 UTC (permalink / raw) To: poky, openembedded-core From: Nitin A Kamble <nitin.a.kamble@intel.com> [YOCTO #795] When we run library check of LSB on qemux86 and qemuppc, we got some failures about 'libstdc++.so.6'. Test environment: Platform: Qemu-x86, Qemu-ppc lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) Library check of LSB: 4.1.0-1 The error log: Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, char*) const ... found that some weak symbols ('W') change into local ('t') during link time and be stripped. According to compiling log, the option "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak symbols change into local. see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc index 6cc11e2..2d214af 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc @@ -1,5 +1,8 @@ require gcc-configure-common.inc +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', +'${CXXFLAGS}', d)}" + EXTRA_OECONF_PATHS = " \ --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ --with-gxx-include-dir=${includedir}/c++/ \ diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 1:26 ` Nitin A Kamble @ 2011-03-09 4:54 ` Khem Raj -1 siblings, 0 replies; 19+ messages in thread From: Khem Raj @ 2011-03-09 4:54 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky, Jingdong Lu, openembedded-core On 3/8/2011 5:26 PM, Nitin A Kamble wrote: > From: Nitin A Kamble<nitin.a.kamble@intel.com> > > [YOCTO #795] > > When we run library check of LSB on qemux86 and qemuppc, we got some failures > about 'libstdc++.so.6'. > > Test environment: > Platform: Qemu-x86, Qemu-ppc > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) > Library check of LSB: 4.1.0-1 > > The error log: > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, > char*) const > ... > > found that some weak symbols ('W') change into local ('t') during link time > and be stripped. According to compiling log, the option > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak > symbols change into local. > > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. > > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> > Signed-off-by: Khem Raj<raj.khem@gmail.com> thank you. Applied it to openembedded-core ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-09 4:54 ` Khem Raj 0 siblings, 0 replies; 19+ messages in thread From: Khem Raj @ 2011-03-09 4:54 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky, openembedded-core On 3/8/2011 5:26 PM, Nitin A Kamble wrote: > From: Nitin A Kamble<nitin.a.kamble@intel.com> > > [YOCTO #795] > > When we run library check of LSB on qemux86 and qemuppc, we got some failures > about 'libstdc++.so.6'. > > Test environment: > Platform: Qemu-x86, Qemu-ppc > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) > Library check of LSB: 4.1.0-1 > > The error log: > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, > char*) const > ... > > found that some weak symbols ('W') change into local ('t') during link time > and be stripped. According to compiling log, the option > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak > symbols change into local. > > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. > > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> > Signed-off-by: Khem Raj<raj.khem@gmail.com> thank you. Applied it to openembedded-core ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 4:54 ` Khem Raj @ 2011-03-09 19:58 ` Richard Purdie -1 siblings, 0 replies; 19+ messages in thread From: Richard Purdie @ 2011-03-09 19:58 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: Jingdong Lu, poky On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote: > On 3/8/2011 5:26 PM, Nitin A Kamble wrote: > > From: Nitin A Kamble<nitin.a.kamble@intel.com> > > > > [YOCTO #795] > > > > When we run library check of LSB on qemux86 and qemuppc, we got some failures > > about 'libstdc++.so.6'. > > > > Test environment: > > Platform: Qemu-x86, Qemu-ppc > > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) > > Library check of LSB: 4.1.0-1 > > > > The error log: > > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 > > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, > > char*) const > > ... > > > > found that some weak symbols ('W') change into local ('t') during link time > > and be stripped. According to compiling log, the option > > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak > > symbols change into local. > > > > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. > > > > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> > > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> > > Signed-off-by: Khem Raj<raj.khem@gmail.com> > > thank you. Applied it to openembedded-core This raises some questions about how the pull model works as I'd been holding off the python RDEPENDS change until I'd had time to check something out yet you've applied it. I haven't had the time to be able to make any informed feedback on the patch yet whether it was ok or not and being able to give any informed feedback takes time. My basic concern that that the RDEPENDS shouldn't be having that effect on native packages and it if it, we probably have a bug somewhere else that likely needs fixing. So the question is whether we are going truly for the pull model, who are the people top of tree, what code review applies to patches from those people, how absence might get handled and so forth. As an illustration, it would have been much more useful for me if someone had pulled the individual patches together into a single git branch and presented that. This helps me as it highlights the outstanding patches and is what Saul does with many of the Yocto patches. I'm aware there are a few patches pending review and I'm thinking the best approach may be some kind of staging/-next type branch where we keep these as we review and then either accept, reject or ask for improvements. One other thing I noticed is that Khem merged a patch known to be broken and then a fixup for it several commits later. I don't like to do that for known breakage since it means things are not bisectable and in that case I'd have squashed the changes with an update to the commit message about the change. Its not a major issue but something to keep in mind going forwards. Cheers, Richard ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [OE-core] [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-09 19:58 ` Richard Purdie 0 siblings, 0 replies; 19+ messages in thread From: Richard Purdie @ 2011-03-09 19:58 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: poky On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote: > On 3/8/2011 5:26 PM, Nitin A Kamble wrote: > > From: Nitin A Kamble<nitin.a.kamble@intel.com> > > > > [YOCTO #795] > > > > When we run library check of LSB on qemux86 and qemuppc, we got some failures > > about 'libstdc++.so.6'. > > > > Test environment: > > Platform: Qemu-x86, Qemu-ppc > > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) > > Library check of LSB: 4.1.0-1 > > > > The error log: > > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 > > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, > > char*) const > > ... > > > > found that some weak symbols ('W') change into local ('t') during link time > > and be stripped. According to compiling log, the option > > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak > > symbols change into local. > > > > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. > > > > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> > > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> > > Signed-off-by: Khem Raj<raj.khem@gmail.com> > > thank you. Applied it to openembedded-core This raises some questions about how the pull model works as I'd been holding off the python RDEPENDS change until I'd had time to check something out yet you've applied it. I haven't had the time to be able to make any informed feedback on the patch yet whether it was ok or not and being able to give any informed feedback takes time. My basic concern that that the RDEPENDS shouldn't be having that effect on native packages and it if it, we probably have a bug somewhere else that likely needs fixing. So the question is whether we are going truly for the pull model, who are the people top of tree, what code review applies to patches from those people, how absence might get handled and so forth. As an illustration, it would have been much more useful for me if someone had pulled the individual patches together into a single git branch and presented that. This helps me as it highlights the outstanding patches and is what Saul does with many of the Yocto patches. I'm aware there are a few patches pending review and I'm thinking the best approach may be some kind of staging/-next type branch where we keep these as we review and then either accept, reject or ask for improvements. One other thing I noticed is that Khem merged a patch known to be broken and then a fixup for it several commits later. I don't like to do that for known breakage since it means things are not bisectable and in that case I'd have squashed the changes with an update to the commit message about the change. Its not a major issue but something to keep in mind going forwards. Cheers, Richard ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [poky] [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 19:58 ` [OE-core] " Richard Purdie @ 2011-03-09 21:18 ` Khem Raj -1 siblings, 0 replies; 19+ messages in thread From: Khem Raj @ 2011-03-09 21:18 UTC (permalink / raw) To: Richard Purdie; +Cc: poky, Patches and discussions about the oe-core layer On Wed, Mar 9, 2011 at 11:58 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote: >> On 3/8/2011 5:26 PM, Nitin A Kamble wrote: >> > From: Nitin A Kamble<nitin.a.kamble@intel.com> >> > >> > [YOCTO #795] >> > >> > When we run library check of LSB on qemux86 and qemuppc, we got some failures >> > about 'libstdc++.so.6'. >> > >> > Test environment: >> > Platform: Qemu-x86, Qemu-ppc >> > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) >> > Library check of LSB: 4.1.0-1 >> > >> > The error log: >> > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 >> > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, >> > char*) const >> > ... >> > >> > found that some weak symbols ('W') change into local ('t') during link time >> > and be stripped. According to compiling log, the option >> > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak >> > symbols change into local. >> > >> > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. >> > >> > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> >> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> >> > Signed-off-by: Khem Raj<raj.khem@gmail.com> >> >> thank you. Applied it to openembedded-core > > This raises some questions about how the pull model works as I'd been > holding off the python RDEPENDS change until I'd had time to check > something out yet you've applied it. I haven't had the time to be able > to make any informed feedback on the patch yet whether it was ok or not > and being able to give any informed feedback takes time. > > My basic concern that that the RDEPENDS shouldn't be having that effect > on native packages and it if it, we probably have a bug somewhere else > that likely needs fixing. > > So the question is whether we are going truly for the pull model, who > are the people top of tree, what code review applies to patches from > those people, how absence might get handled and so forth. > > As an illustration, it would have been much more useful for me if > someone had pulled the individual patches together into a single git > branch and presented that. Yes thats probably better This helps me as it highlights the > outstanding patches and is what Saul does with many of the Yocto > patches. > > I'm aware there are a few patches pending review and I'm thinking the > best approach may be some kind of staging/-next type branch where we > keep these as we review and then either accept, reject or ask for > improvements. > usually if a patch has reviews that needs retouching it. It should go back through the same cycle it went first time which was my assumption here which obviously was not case here. the patches to oe-core from yocto I assumed were proposed through the branch to pull from and I think is a good way to prune errors as patches move into oe-core > One other thing I noticed is that Khem merged a patch known to be broken > and then a fixup for it several commits later. I don't like to do that > for known breakage since it means things are not bisectable and in that > case I'd have squashed the changes with an update to the commit message > about the change. Its not a major issue but something to keep in mind > going forwards. Yes bisection is important. I guess I assumed too much even though I was verifying We need to have openembedded-core-contrib setup for people who do not have possibility to use yocto-contrib ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [OE-core] [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-09 21:18 ` Khem Raj 0 siblings, 0 replies; 19+ messages in thread From: Khem Raj @ 2011-03-09 21:18 UTC (permalink / raw) To: Richard Purdie; +Cc: poky, Patches and discussions about the oe-core layer On Wed, Mar 9, 2011 at 11:58 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Tue, 2011-03-08 at 20:54 -0800, Khem Raj wrote: >> On 3/8/2011 5:26 PM, Nitin A Kamble wrote: >> > From: Nitin A Kamble<nitin.a.kamble@intel.com> >> > >> > [YOCTO #795] >> > >> > When we run library check of LSB on qemux86 and qemuppc, we got some failures >> > about 'libstdc++.so.6'. >> > >> > Test environment: >> > Platform: Qemu-x86, Qemu-ppc >> > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) >> > Library check of LSB: 4.1.0-1 >> > >> > The error log: >> > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 >> > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, >> > char*) const >> > ... >> > >> > found that some weak symbols ('W') change into local ('t') during link time >> > and be stripped. According to compiling log, the option >> > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak >> > symbols change into local. >> > >> > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. >> > >> > Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com> >> > Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com> >> > Signed-off-by: Khem Raj<raj.khem@gmail.com> >> >> thank you. Applied it to openembedded-core > > This raises some questions about how the pull model works as I'd been > holding off the python RDEPENDS change until I'd had time to check > something out yet you've applied it. I haven't had the time to be able > to make any informed feedback on the patch yet whether it was ok or not > and being able to give any informed feedback takes time. > > My basic concern that that the RDEPENDS shouldn't be having that effect > on native packages and it if it, we probably have a bug somewhere else > that likely needs fixing. > > So the question is whether we are going truly for the pull model, who > are the people top of tree, what code review applies to patches from > those people, how absence might get handled and so forth. > > As an illustration, it would have been much more useful for me if > someone had pulled the individual patches together into a single git > branch and presented that. Yes thats probably better This helps me as it highlights the > outstanding patches and is what Saul does with many of the Yocto > patches. > > I'm aware there are a few patches pending review and I'm thinking the > best approach may be some kind of staging/-next type branch where we > keep these as we review and then either accept, reject or ask for > improvements. > usually if a patch has reviews that needs retouching it. It should go back through the same cycle it went first time which was my assumption here which obviously was not case here. the patches to oe-core from yocto I assumed were proposed through the branch to pull from and I think is a good way to prune errors as patches move into oe-core > One other thing I noticed is that Khem merged a patch known to be broken > and then a fixup for it several commits later. I don't like to do that > for known breakage since it means things are not bisectable and in that > case I'd have squashed the changes with an update to the commit message > about the change. Its not a major issue but something to keep in mind > going forwards. Yes bisection is important. I guess I assumed too much even though I was verifying We need to have openembedded-core-contrib setup for people who do not have possibility to use yocto-contrib ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 1:26 ` Nitin A Kamble @ 2011-03-09 9:45 ` Lu Jingdong -1 siblings, 0 replies; 19+ messages in thread From: Lu Jingdong @ 2011-03-09 9:45 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky, Khem, openembedded-core [-- Attachment #1: Type: text/plain, Size: 1739 bytes --] On 03/09/2011 09:26 AM, Nitin A Kamble wrote: > .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > index 6cc11e2..2d214af 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > @@ -1,5 +1,8 @@ > require gcc-configure-common.inc > > +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', > +'${CXXFLAGS}', d)}" > + I think it should be CXXFLAGS*:=* "${@oe_filter_out('-fvisibility-inlines-hidden', '${CXXFLAGS}', d)}" otherwise it will give the following error log. NOTE: Error expanding variable CXXFLAGS############################################################### | ETA: 00:00:00 ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself! It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error. > EXTRA_OECONF_PATHS = " \ > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > --with-gxx-include-dir=${includedir}/c++/ \ > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > index 093f9bf..c1e680d 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc -- Lu Jingdong jingdong.lu@windriver.com China, Wind River [-- Attachment #2: Type: text/html, Size: 2475 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-09 9:45 ` Lu Jingdong 0 siblings, 0 replies; 19+ messages in thread From: Lu Jingdong @ 2011-03-09 9:45 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky, openembedded-core [-- Attachment #1: Type: text/plain, Size: 1739 bytes --] On 03/09/2011 09:26 AM, Nitin A Kamble wrote: > .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > index 6cc11e2..2d214af 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > @@ -1,5 +1,8 @@ > require gcc-configure-common.inc > > +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', > +'${CXXFLAGS}', d)}" > + I think it should be CXXFLAGS*:=* "${@oe_filter_out('-fvisibility-inlines-hidden', '${CXXFLAGS}', d)}" otherwise it will give the following error log. NOTE: Error expanding variable CXXFLAGS############################################################### | ETA: 00:00:00 ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself! It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error. > EXTRA_OECONF_PATHS = " \ > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > --with-gxx-include-dir=${includedir}/c++/ \ > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > index 093f9bf..c1e680d 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc -- Lu Jingdong jingdong.lu@windriver.com China, Wind River [-- Attachment #2: Type: text/html, Size: 2475 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-09 9:45 ` Lu Jingdong (?) @ 2011-03-09 21:31 ` Kamble, Nitin A -1 siblings, 0 replies; 19+ messages in thread From: Kamble, Nitin A @ 2011-03-09 21:31 UTC (permalink / raw) To: Lu Jingdong Cc: poky@yoctoproject.org, openembedded-core@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 2274 bytes --] From: Lu Jingdong [mailto:jingdong.lu@windriver.com] Sent: Wednesday, March 09, 2011 1:45 AM To: Kamble, Nitin A Cc: poky@yoctoproject.org; openembedded-core@lists.openembedded.org; Khem Raj Subject: Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 On 03/09/2011 09:26 AM, Nitin A Kamble wrote: .../recipes-devtools/gcc/gcc-configure-runtime.inc | 3 +++ meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc index 6cc11e2..2d214af 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc @@ -1,5 +1,8 @@ require gcc-configure-common.inc +CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', +'${CXXFLAGS}', d)}" + I think it should be CXXFLAGS := "${@oe_filter_out('-fvisibility-inlines-hidden', '${CXXFLAGS}', d)}" This is correct. I also saw the bellow error and I have tested with := only. But missed merging the change back to the commit before pushing. Sorry about that. Thanks, Nitin otherwise it will give the following error log. NOTE: Error expanding variable CXXFLAGS############################################################### | ETA: 00:00:00 ERROR: Error parsing xxx.../xxx.bb: variable CXXFLAGS references itself! It is ok in python, but bitbake/lib/bb/data_smart.py will check it and it will cause error. EXTRA_OECONF_PATHS = " \ --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ --with-gxx-include-dir=${includedir}/c++/ \ diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc -- Lu Jingdong jingdong.lu@windriver.com<mailto:jingdong.lu@windriver.com> China, Wind River [-- Attachment #2: Type: text/html, Size: 7640 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/1] fix a LSB test issue
@ 2011-03-07 16:55 Nitin A Kamble
2011-03-07 16:55 ` Nitin A Kamble
0 siblings, 1 reply; 19+ messages in thread
From: Nitin A Kamble @ 2011-03-07 16:55 UTC (permalink / raw)
To: poky, openembedded-core; +Cc: Jingdong Lu
From: Nitin A Kamble <nitin.a.kamble@intel.com>
More details in the commit email.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: nitin/misc
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Thanks,
Nitin A Kamble <nitin.a.kamble@intel.com>
---
Nitin A Kamble (1):
gcc-runtime: fix LSB library checks for libstdc++.so.6
meta/conf/bitbake.conf | 2 +-
meta/conf/distro/include/poky-eglibc.inc | 2 +-
meta/conf/distro/include/poky-glibc.inc | 2 +-
meta/conf/distro/include/poky-uclibc.inc | 2 +-
.../recipes-devtools/gcc/gcc-configure-runtime.inc | 1 +
meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +-
6 files changed, 6 insertions(+), 5 deletions(-)
--
1.7.3.4
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-07 16:55 [PATCH 0/1] fix a LSB test issue Nitin A Kamble @ 2011-03-07 16:55 ` Nitin A Kamble 0 siblings, 0 replies; 19+ messages in thread From: Nitin A Kamble @ 2011-03-07 16:55 UTC (permalink / raw) To: poky, openembedded-core; +Cc: Jingdong Lu From: Nitin A Kamble <nitin.a.kamble@intel.com> [YOCTO #795] When we run library check of LSB on qemux86 and qemuppc, we got some failures about 'libstdc++.so.6'. Test environment: Platform: Qemu-x86, Qemu-ppc lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) Library check of LSB: 4.1.0-1 The error log: Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, char*) const ... found that some weak symbols ('W') change into local ('t') during link time and be stripped. According to compiling log, the option "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak symbols change into local. see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> --- meta/conf/bitbake.conf | 2 +- meta/conf/distro/include/poky-eglibc.inc | 2 +- meta/conf/distro/include/poky-glibc.inc | 2 +- meta/conf/distro/include/poky-uclibc.inc | 2 +- .../recipes-devtools/gcc/gcc-configure-runtime.inc | 1 + meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index cf99a81..473306a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -463,7 +463,7 @@ export CFLAGS = "${TARGET_CFLAGS}" export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" export BUILD_CXXFLAGS = "${BUILD_CFLAGS} -fpermissive" -export CXXFLAGS = "${TARGET_CXXFLAGS}" +export CXXFLAGS = "${TARGET_CXXFLAGS} ${CXXFLAGS_EXTRA}" export TARGET_CXXFLAGS = "${TARGET_CFLAGS} -fpermissive" export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ diff --git a/meta/conf/distro/include/poky-eglibc.inc b/meta/conf/distro/include/poky-eglibc.inc index 3d2c362..44a0146 100644 --- a/meta/conf/distro/include/poky-eglibc.inc +++ b/meta/conf/distro/include/poky-eglibc.inc @@ -19,7 +19,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "eglibc-initia TARGET_OS = "${GLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" LIBC_DEPENDENCIES = "libsegfault \ eglibc \ diff --git a/meta/conf/distro/include/poky-glibc.inc b/meta/conf/distro/include/poky-glibc.inc index 4be7122..d3f28c0 100644 --- a/meta/conf/distro/include/poky-glibc.inc +++ b/meta/conf/distro/include/poky-glibc.inc @@ -18,7 +18,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "glibc-initial TARGET_OS = "${GLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" LIBC_DEPENDENCIES = "\ libsegfault \ diff --git a/meta/conf/distro/include/poky-uclibc.inc b/meta/conf/distro/include/poky-uclibc.inc index def9dfe..13c17f9 100644 --- a/meta/conf/distro/include/poky-uclibc.inc +++ b/meta/conf/distro/include/poky-uclibc.inc @@ -15,7 +15,7 @@ USE_NLS_glib-2.0 = "yes" TARGET_OS = "${UCLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" IMAGE_LINGUAS = "" diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc index 6cc11e2..d4dfbc2 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc @@ -1,5 +1,6 @@ require gcc-configure-common.inc +CXXFLAGS_EXTA = "" EXTRA_OECONF_PATHS = " \ --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ --with-gxx-include-dir=${includedir}/c++/ \ diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 @ 2011-03-07 16:55 ` Nitin A Kamble 0 siblings, 0 replies; 19+ messages in thread From: Nitin A Kamble @ 2011-03-07 16:55 UTC (permalink / raw) To: poky, openembedded-core From: Nitin A Kamble <nitin.a.kamble@intel.com> [YOCTO #795] When we run library check of LSB on qemux86 and qemuppc, we got some failures about 'libstdc++.so.6'. Test environment: Platform: Qemu-x86, Qemu-ppc lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) Library check of LSB: 4.1.0-1 The error log: Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, char*) const ... found that some weak symbols ('W') change into local ('t') during link time and be stripped. According to compiling log, the option "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak symbols change into local. see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> --- meta/conf/bitbake.conf | 2 +- meta/conf/distro/include/poky-eglibc.inc | 2 +- meta/conf/distro/include/poky-glibc.inc | 2 +- meta/conf/distro/include/poky-uclibc.inc | 2 +- .../recipes-devtools/gcc/gcc-configure-runtime.inc | 1 + meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index cf99a81..473306a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -463,7 +463,7 @@ export CFLAGS = "${TARGET_CFLAGS}" export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" export BUILD_CXXFLAGS = "${BUILD_CFLAGS} -fpermissive" -export CXXFLAGS = "${TARGET_CXXFLAGS}" +export CXXFLAGS = "${TARGET_CXXFLAGS} ${CXXFLAGS_EXTRA}" export TARGET_CXXFLAGS = "${TARGET_CFLAGS} -fpermissive" export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ diff --git a/meta/conf/distro/include/poky-eglibc.inc b/meta/conf/distro/include/poky-eglibc.inc index 3d2c362..44a0146 100644 --- a/meta/conf/distro/include/poky-eglibc.inc +++ b/meta/conf/distro/include/poky-eglibc.inc @@ -19,7 +19,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "eglibc-initia TARGET_OS = "${GLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" LIBC_DEPENDENCIES = "libsegfault \ eglibc \ diff --git a/meta/conf/distro/include/poky-glibc.inc b/meta/conf/distro/include/poky-glibc.inc index 4be7122..d3f28c0 100644 --- a/meta/conf/distro/include/poky-glibc.inc +++ b/meta/conf/distro/include/poky-glibc.inc @@ -18,7 +18,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "glibc-initial TARGET_OS = "${GLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" LIBC_DEPENDENCIES = "\ libsegfault \ diff --git a/meta/conf/distro/include/poky-uclibc.inc b/meta/conf/distro/include/poky-uclibc.inc index def9dfe..13c17f9 100644 --- a/meta/conf/distro/include/poky-uclibc.inc +++ b/meta/conf/distro/include/poky-uclibc.inc @@ -15,7 +15,7 @@ USE_NLS_glib-2.0 = "yes" TARGET_OS = "${UCLIBCTARGETOS}" -CXXFLAGS += "-fvisibility-inlines-hidden" +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" IMAGE_LINGUAS = "" diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc index 6cc11e2..d4dfbc2 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc @@ -1,5 +1,6 @@ require gcc-configure-common.inc +CXXFLAGS_EXTA = "" EXTRA_OECONF_PATHS = " \ --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ --with-gxx-include-dir=${includedir}/c++/ \ diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb index 093f9bf..c1e680d 100644 --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb @@ -1,4 +1,4 @@ -PR = "r2" +PR = "r3" require gcc-${PV}.inc require gcc-configure-runtime.inc -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-07 16:55 ` Nitin A Kamble (?) @ 2011-03-07 17:14 ` Khem Raj 2011-03-08 21:21 ` Kamble, Nitin A -1 siblings, 1 reply; 19+ messages in thread From: Khem Raj @ 2011-03-07 17:14 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky, openembedded-core On Mon, Mar 7, 2011 at 8:55 AM, Nitin A Kamble <nitin.a.kamble@intel.com> wrote: > From: Nitin A Kamble <nitin.a.kamble@intel.com> > > [YOCTO #795] > > When we run library check of LSB on qemux86 and qemuppc, we got some failures > about 'libstdc++.so.6'. > > Test environment: > Platform: Qemu-x86, Qemu-ppc > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build server) > Library check of LSB: 4.1.0-1 > > The error log: > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in libstdc++.so.6 > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char const*, > char*) const > ... > > found that some weak symbols ('W') change into local ('t') during link time > and be stripped. According to compiling log, the option > "-fvisibility-inlines-hidden" is used for gcc. And this option caused some weak > symbols change into local. > you could use oe_filter_out functionality to strip out a given option and you wont need to touch so many parts. Just do something like CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', '${CXXFLAGS}', d)}" in gcc runtime recipe and you should be set Thanks -Khem > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more information on the bug. > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> > Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> > --- > meta/conf/bitbake.conf | 2 +- > meta/conf/distro/include/poky-eglibc.inc | 2 +- > meta/conf/distro/include/poky-glibc.inc | 2 +- > meta/conf/distro/include/poky-uclibc.inc | 2 +- > .../recipes-devtools/gcc/gcc-configure-runtime.inc | 1 + > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > 6 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index cf99a81..473306a 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -463,7 +463,7 @@ export CFLAGS = "${TARGET_CFLAGS}" > export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" > > export BUILD_CXXFLAGS = "${BUILD_CFLAGS} -fpermissive" > -export CXXFLAGS = "${TARGET_CXXFLAGS}" > +export CXXFLAGS = "${TARGET_CXXFLAGS} ${CXXFLAGS_EXTRA}" > export TARGET_CXXFLAGS = "${TARGET_CFLAGS} -fpermissive" > > export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ > diff --git a/meta/conf/distro/include/poky-eglibc.inc b/meta/conf/distro/include/poky-eglibc.inc > index 3d2c362..44a0146 100644 > --- a/meta/conf/distro/include/poky-eglibc.inc > +++ b/meta/conf/distro/include/poky-eglibc.inc > @@ -19,7 +19,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "eglibc-initia > > TARGET_OS = "${GLIBCTARGETOS}" > > -CXXFLAGS += "-fvisibility-inlines-hidden" > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > LIBC_DEPENDENCIES = "libsegfault \ > eglibc \ > diff --git a/meta/conf/distro/include/poky-glibc.inc b/meta/conf/distro/include/poky-glibc.inc > index 4be7122..d3f28c0 100644 > --- a/meta/conf/distro/include/poky-glibc.inc > +++ b/meta/conf/distro/include/poky-glibc.inc > @@ -18,7 +18,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc-initial-nativesdk ?= "glibc-initial > > TARGET_OS = "${GLIBCTARGETOS}" > > -CXXFLAGS += "-fvisibility-inlines-hidden" > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > LIBC_DEPENDENCIES = "\ > libsegfault \ > diff --git a/meta/conf/distro/include/poky-uclibc.inc b/meta/conf/distro/include/poky-uclibc.inc > index def9dfe..13c17f9 100644 > --- a/meta/conf/distro/include/poky-uclibc.inc > +++ b/meta/conf/distro/include/poky-uclibc.inc > @@ -15,7 +15,7 @@ USE_NLS_glib-2.0 = "yes" > > TARGET_OS = "${UCLIBCTARGETOS}" > > -CXXFLAGS += "-fvisibility-inlines-hidden" > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > IMAGE_LINGUAS = "" > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > index 6cc11e2..d4dfbc2 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > @@ -1,5 +1,6 @@ > require gcc-configure-common.inc > > +CXXFLAGS_EXTA = "" > EXTRA_OECONF_PATHS = " \ > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > --with-gxx-include-dir=${includedir}/c++/ \ > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > index 093f9bf..c1e680d 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc > -- > 1.7.3.4 > > _______________________________________________ > poky mailing list > poky@yoctoproject.org > https://lists.yoctoproject.org/listinfo/poky > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-07 17:14 ` Khem Raj @ 2011-03-08 21:21 ` Kamble, Nitin A 0 siblings, 0 replies; 19+ messages in thread From: Kamble, Nitin A @ 2011-03-08 21:21 UTC (permalink / raw) To: Khem Raj; +Cc: poky@yoctoproject.org, openembedded-core@lists.openembedded.org > -----Original Message----- > From: Khem Raj [mailto:raj.khem@gmail.com] > Sent: Monday, March 07, 2011 9:14 AM > To: Kamble, Nitin A > Cc: poky@yoctoproject.org; openembedded-core@lists.openembedded.org > Subject: Re: [poky] [PATCH 1/1] gcc-runtime: fix LSB library checks for > libstdc++.so.6 > > On Mon, Mar 7, 2011 at 8:55 AM, Nitin A Kamble > <nitin.a.kamble@intel.com> wrote: > > From: Nitin A Kamble <nitin.a.kamble@intel.com> > > > > [YOCTO #795] > > > > When we run library check of LSB on qemux86 and qemuppc, we got some > failures > > about 'libstdc++.so.6'. > > > > Test environment: > > Platform: Qemu-x86, Qemu-ppc > > lsb image: poky-image-lsb-qemux86-test.ext3(Feb 26th, auto-build > server) > > Library check of LSB: 4.1.0-1 > > > > The error log: > > Did not find _ZNKSt5ctypeIcE8do_widenEPKcS2_Pc (GLIBCXX_3.4) in > libstdc++.so.6 > > Unmangled symbol name: std::ctype<char>::do_widen(char const*, char > const*, > > char*) const > > ... > > > > found that some weak symbols ('W') change into local ('t') during > link time > > and be stripped. According to compiling log, the option > > "-fvisibility-inlines-hidden" is used for gcc. And this option caused > some weak > > symbols change into local. > > > > > you could use oe_filter_out functionality to strip out a given option > and you wont need to touch so many parts. Just do something like > > CXXFLAGS = "${@oe_filter_out('-fvisibility-inlines-hidden', > '${CXXFLAGS}', d)}" in gcc runtime recipe and you should be set > > Thanks > > -Khem Good to know another trick. Thanks Khem. Nitin > > > see http://bugzilla.pokylinux.org/show_bug.cgi?id=795 for more > information on the bug. > > > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> > > Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com> > > --- > > meta/conf/bitbake.conf | 2 +- > > meta/conf/distro/include/poky-eglibc.inc | 2 +- > > meta/conf/distro/include/poky-glibc.inc | 2 +- > > meta/conf/distro/include/poky-uclibc.inc | 2 +- > > .../recipes-devtools/gcc/gcc-configure-runtime.inc | 1 + > > meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb | 2 +- > > 6 files changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > > index cf99a81..473306a 100644 > > --- a/meta/conf/bitbake.conf > > +++ b/meta/conf/bitbake.conf > > @@ -463,7 +463,7 @@ export CFLAGS = "${TARGET_CFLAGS}" > > export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}" > > > > export BUILD_CXXFLAGS = "${BUILD_CFLAGS} -fpermissive" > > -export CXXFLAGS = "${TARGET_CXXFLAGS}" > > +export CXXFLAGS = "${TARGET_CXXFLAGS} ${CXXFLAGS_EXTRA}" > > export TARGET_CXXFLAGS = "${TARGET_CFLAGS} -fpermissive" > > > > export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \ > > diff --git a/meta/conf/distro/include/poky-eglibc.inc > b/meta/conf/distro/include/poky-eglibc.inc > > index 3d2c362..44a0146 100644 > > --- a/meta/conf/distro/include/poky-eglibc.inc > > +++ b/meta/conf/distro/include/poky-eglibc.inc > > @@ -19,7 +19,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc- > initial-nativesdk ?= "eglibc-initia > > > > TARGET_OS = "${GLIBCTARGETOS}" > > > > -CXXFLAGS += "-fvisibility-inlines-hidden" > > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > > > LIBC_DEPENDENCIES = "libsegfault \ > > eglibc \ > > diff --git a/meta/conf/distro/include/poky-glibc.inc > b/meta/conf/distro/include/poky-glibc.inc > > index 4be7122..d3f28c0 100644 > > --- a/meta/conf/distro/include/poky-glibc.inc > > +++ b/meta/conf/distro/include/poky-glibc.inc > > @@ -18,7 +18,7 @@ PREFERRED_PROVIDER_virtual/${SDK_PREFIX}libc- > initial-nativesdk ?= "glibc-initial > > > > TARGET_OS = "${GLIBCTARGETOS}" > > > > -CXXFLAGS += "-fvisibility-inlines-hidden" > > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > > > LIBC_DEPENDENCIES = "\ > > libsegfault \ > > diff --git a/meta/conf/distro/include/poky-uclibc.inc > b/meta/conf/distro/include/poky-uclibc.inc > > index def9dfe..13c17f9 100644 > > --- a/meta/conf/distro/include/poky-uclibc.inc > > +++ b/meta/conf/distro/include/poky-uclibc.inc > > @@ -15,7 +15,7 @@ USE_NLS_glib-2.0 = "yes" > > > > TARGET_OS = "${UCLIBCTARGETOS}" > > > > -CXXFLAGS += "-fvisibility-inlines-hidden" > > +CXXFLAGS_EXTRA += "-fvisibility-inlines-hidden" > > > > IMAGE_LINGUAS = "" > > > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > index 6cc11e2..d4dfbc2 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > @@ -1,5 +1,6 @@ > > require gcc-configure-common.inc > > > > +CXXFLAGS_EXTA = "" > > EXTRA_OECONF_PATHS = " \ > > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > > --with-gxx-include-dir=${includedir}/c++/ \ > > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > index 093f9bf..c1e680d 100644 > > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r2" > > +PR = "r3" > > > > require gcc-${PV}.inc > > require gcc-configure-runtime.inc > > -- > > 1.7.3.4 > > > > _______________________________________________ > > poky mailing list > > poky@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/poky > > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-07 16:55 ` Nitin A Kamble (?) (?) @ 2011-03-08 1:00 ` Lu Jingdong 2011-03-08 15:49 ` Kamble, Nitin A -1 siblings, 1 reply; 19+ messages in thread From: Lu Jingdong @ 2011-03-08 1:00 UTC (permalink / raw) To: Nitin A Kamble; +Cc: poky On 03/08/2011 12:55 AM, Nitin A Kamble wrote: > ... > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > index 6cc11e2..d4dfbc2 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > @@ -1,5 +1,6 @@ > require gcc-configure-common.inc > > +CXXFLAGS_EXTA = "" Maybe a little spell mistake, should be "EXTRA". :-) > EXTRA_OECONF_PATHS = " \ > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > --with-gxx-include-dir=${includedir}/c++/ \ > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > index 093f9bf..c1e680d 100644 > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > @@ -1,4 +1,4 @@ > -PR = "r2" > +PR = "r3" > > require gcc-${PV}.inc > require gcc-configure-runtime.inc -- Lu Jingdong jingdong.lu@windriver.com China, Wind River ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 2011-03-08 1:00 ` Lu Jingdong @ 2011-03-08 15:49 ` Kamble, Nitin A 0 siblings, 0 replies; 19+ messages in thread From: Kamble, Nitin A @ 2011-03-08 15:49 UTC (permalink / raw) To: Lu Jingdong; +Cc: poky@yoctoproject.org > -----Original Message----- > From: Lu Jingdong [mailto:jingdong.lu@windriver.com] > Sent: Monday, March 07, 2011 5:00 PM > To: Kamble, Nitin A > Cc: poky@yoctoproject.org > Subject: Re: [PATCH 1/1] gcc-runtime: fix LSB library checks for > libstdc++.so.6 > > On 03/08/2011 12:55 AM, Nitin A Kamble wrote: > > ... > > > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > index 6cc11e2..d4dfbc2 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc > > @@ -1,5 +1,6 @@ > > require gcc-configure-common.inc > > > > +CXXFLAGS_EXTA = "" > Maybe a little spell mistake, should be "EXTRA". :-) Jingdong, Good Catch. I will update the commit. Thanks, Nitin > > EXTRA_OECONF_PATHS = " \ > > --with-local-prefix=${STAGING_DIR_TARGET}${prefix} \ > > --with-gxx-include-dir=${includedir}/c++/ \ > > diff --git a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > index 093f9bf..c1e680d 100644 > > --- a/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > +++ b/meta/recipes-devtools/gcc/gcc-runtime_4.5.1.bb > > @@ -1,4 +1,4 @@ > > -PR = "r2" > > +PR = "r3" > > > > require gcc-${PV}.inc > > require gcc-configure-runtime.inc > > > -- > Lu Jingdong > jingdong.lu@windriver.com > China, Wind River ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2011-03-09 21:42 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-09 1:26 [PATCH 0/1] a bugfix for gcc-runtime recipe Nitin A Kamble 2011-03-09 1:26 ` Nitin A Kamble 2011-03-09 1:26 ` [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 Nitin A Kamble 2011-03-09 1:26 ` Nitin A Kamble 2011-03-09 4:54 ` Khem Raj 2011-03-09 4:54 ` Khem Raj 2011-03-09 19:58 ` Richard Purdie 2011-03-09 19:58 ` [OE-core] " Richard Purdie 2011-03-09 21:18 ` [poky] " Khem Raj 2011-03-09 21:18 ` [OE-core] " Khem Raj 2011-03-09 9:45 ` Lu Jingdong 2011-03-09 9:45 ` Lu Jingdong 2011-03-09 21:31 ` Kamble, Nitin A -- strict thread matches above, loose matches on Subject: below -- 2011-03-07 16:55 [PATCH 0/1] fix a LSB test issue Nitin A Kamble 2011-03-07 16:55 ` [PATCH 1/1] gcc-runtime: fix LSB library checks for libstdc++.so.6 Nitin A Kamble 2011-03-07 16:55 ` Nitin A Kamble 2011-03-07 17:14 ` Khem Raj 2011-03-08 21:21 ` Kamble, Nitin A 2011-03-08 1:00 ` Lu Jingdong 2011-03-08 15:49 ` Kamble, Nitin A
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.