[PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset

[PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset

[Iiro Valkonen]

Increase the sleep times after backup and reset, so that we can be sure they have been completed even when the mXT cycle time is set to maximum value (254ms).

Signed-off-by: Iiro Valkonen <iiro.valkonen@atmel.com>
---
 drivers/input/touchscreen/atmel_mxt_ts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 4012436..f8cd478 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -169,8 +169,8 @@
 /* Define for MXT_GEN_COMMAND */
 #define MXT_BOOT_VALUE		0xa5
 #define MXT_BACKUP_VALUE	0x55
-#define MXT_BACKUP_TIME		25	/* msec */
-#define MXT_RESET_TIME		65	/* msec */
+#define MXT_BACKUP_TIME		270	/* msec */
+#define MXT_RESET_TIME		350	/* msec */
 
 #define MXT_FWRESET_TIME	175	/* msec */
 
-- 
1.7.0.4

Re: [PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset

[Joonyoung Shim]

Hi, Iiro.

2011/3/17 Iiro Valkonen <iiro.valkonen@atmel.com>:
> Increase the sleep times after backup and reset, so that we can be sure they have been completed even when the mXT cycle time is set to maximum value (254ms).
>
> Signed-off-by: Iiro Valkonen <iiro.valkonen@atmel.com>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index 4012436..f8cd478 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -169,8 +169,8 @@
>  /* Define for MXT_GEN_COMMAND */
>  #define MXT_BOOT_VALUE         0xa5
>  #define MXT_BACKUP_VALUE       0x55
> -#define MXT_BACKUP_TIME                25      /* msec */
> -#define MXT_RESET_TIME         65      /* msec */
> +#define MXT_BACKUP_TIME                270     /* msec */
> +#define MXT_RESET_TIME         350     /* msec */

I wonder mXT cycle time is alterable and if reset and backup time is desided
by mXT cycle time, i think they can be used to variable.

-- 
- Joonyoung Shim
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset

[Iiro Valkonen]

On 03/21/2011 02:11 PM, Joonyoung Shim wrote:
>> -#define MXT_BACKUP_TIME                25      /* msec */
>> -#define MXT_RESET_TIME         65      /* msec */
>> +#define MXT_BACKUP_TIME                270     /* msec */
>> +#define MXT_RESET_TIME         350     /* msec */
> 
> I wonder mXT cycle time is alterable and if reset and backup time is desided
> by mXT cycle time, i think they can be used to variable.
> 

I agree, waiting for 270 + 350 ms might be overkill. The correct way to do this would be
to wait for the chip to indicate it has completed the backup and reset. I will send a new
patch that implements this.

BR,

-- 
Iiro