From: Huang Shijie <b32955@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] ARM: add GPMI support for imx23/imx28
Date: Fri, 18 Mar 2011 10:06:04 +0800 [thread overview]
Message-ID: <4D82BE0C.5050106@freescale.com> (raw)
In-Reply-To: <19841.58406.756435.967812@ipc1.ka-ro>
hi:
>>> IMO all the source code could be kept in one file (except for the
>>> include files of course) and the gpmi-nfc subdirectory removed.
>> I really can merge some files, but IMHO, it's not a good solution to
>> keep all in one file.
>>
>> The reasons are :
>> [1] The GPMI support the NAND boot mode,but the imx23 and imx28 is a
>> little different in
>> the NAND boot procedure due the different firmwares in the chips. If I
>> merge the rom-imx23.c
>> rom-imx28.c to one file, the code will very mess. ugly enough!
>>
> You can use platform_ids to differentiate between the versions and
> have separate functions for imx23 and imx28 where appropriate and
> select between those depending on the platform_id.
>
>
thanks a lot.
Best Regards.
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: add GPMI support for imx23/imx28
Date: Fri, 18 Mar 2011 10:06:04 +0800 [thread overview]
Message-ID: <4D82BE0C.5050106@freescale.com> (raw)
In-Reply-To: <19841.58406.756435.967812@ipc1.ka-ro>
hi:
>>> IMO all the source code could be kept in one file (except for the
>>> include files of course) and the gpmi-nfc subdirectory removed.
>> I really can merge some files, but IMHO, it's not a good solution to
>> keep all in one file.
>>
>> The reasons are :
>> [1] The GPMI support the NAND boot mode,but the imx23 and imx28 is a
>> little different in
>> the NAND boot procedure due the different firmwares in the chips. If I
>> merge the rom-imx23.c
>> rom-imx28.c to one file, the code will very mess. ugly enough!
>>
> You can use platform_ids to differentiate between the versions and
> have separate functions for imx23 and imx28 where appropriate and
> select between those depending on the platform_id.
>
>
thanks a lot.
Best Regards.
Huang Shijie
next prev parent reply other threads:[~2011-03-18 2:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 1:42 [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-03-16 1:42 ` [PATCH 1/7] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-03-16 10:13 ` Lothar Waßmann
[not found] ` <4D809453.4090603@freescale.com>
[not found] ` <19840.43943.592336.854865@ipc1.ka-ro>
2011-03-17 2:19 ` Huang Shijie
2011-03-17 2:19 ` Huang Shijie
2011-03-17 10:36 ` Lothar Waßmann
2011-03-17 10:36 ` Lothar Waßmann
2011-03-18 2:06 ` Huang Shijie [this message]
2011-03-18 2:06 ` Huang Shijie
2011-03-16 1:42 ` [PATCH 2/7] add the common code for GPMI driver Huang Shijie
2011-03-22 12:36 ` =?utf-8?Q?Lothar_Wa=C3=9Fmann?=
2011-03-23 3:41 ` Huang Shijie
2011-03-23 3:41 ` Huang Shijie
2011-03-16 1:42 ` [PATCH 3/7] add the database for the NANDs Huang Shijie
2011-03-16 1:42 ` [PATCH 4/7] add GPMI support for imx23 Huang Shijie
2011-03-16 1:42 ` [PATCH 5/7] add GPMI support for imx28 Huang Shijie
2011-03-22 12:46 ` Lothar Waßmann
2011-03-23 3:11 ` Huang Shijie
2011-03-23 3:11 ` Huang Shijie
2011-03-23 14:56 ` Lothar Waßmann
2011-03-23 14:56 ` Lothar Waßmann
2011-03-23 15:16 ` Florian Fainelli
2011-03-23 15:16 ` Florian Fainelli
2011-03-24 3:07 ` Huang Shijie
2011-03-24 3:07 ` Huang Shijie
2011-03-24 3:03 ` Huang Shijie
2011-03-24 3:03 ` Huang Shijie
2011-03-24 7:34 ` Lothar Waßmann
2011-03-24 7:34 ` Lothar Waßmann
2011-03-24 8:26 ` Jason Liu
2011-03-24 8:26 ` Jason Liu
2011-03-24 8:32 ` Wolfram Sang
2011-03-24 8:32 ` Wolfram Sang
2011-03-24 8:33 ` Lothar Waßmann
2011-03-24 8:33 ` Lothar Waßmann
2011-03-24 8:51 ` Huang Shijie
2011-03-24 8:51 ` Huang Shijie
2011-03-24 13:54 ` Florian Fainelli
2011-03-24 13:54 ` Florian Fainelli
2011-03-25 2:50 ` Huang Shijie
2011-03-25 2:50 ` Huang Shijie
2011-03-16 1:42 ` [PATCH 6/7] dmaengine: change the flags of request_irq() Huang Shijie
2011-03-16 10:13 ` Lothar Waßmann
2011-03-16 12:31 ` 答复: " Huang Shijie-B32955
2011-03-18 6:12 ` Huang Shijie
2011-03-16 1:42 ` [PATCH 7/7] MTD : add GPMI driver in the config and Makefile Huang Shijie
-- strict thread matches above, loose matches on Subject: below --
2011-03-16 1:55 [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-03-16 1:55 ` [PATCH 1/7] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-03-16 1:55 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D82BE0C.5050106@freescale.com \
--to=b32955@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.