[PATCH 0/1] msmtp: add link sendmail to pass LSB test

[PATCH 0/1] msmtp: add link sendmail to pass LSB test

[Kang Kai]

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test. 
msmtp has been added to replace sendmail.
    
Related to [YOCTO #520]

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: kangkai/distro01
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro01

Thanks,
    Kang Kai <kai.kang@windriver.com>
---


Kang Kai (1):
  msmtp: add link sendmail for lsb command check

 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

[PATCH 1/1] msmtp: add link sendmail for lsb command check

[Kang Kai]

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test.

Related to [YOCTO #520]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
index cb3d83c..5fc4060 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
@@ -6,7 +6,7 @@ SECTION = "console/network"
 PRIORITY = "required"
 LICENSE = "GPLv3"
 DEPENDS = "zlib gnutls"
-PR = "r0"
+PR = "r1"
 
 
 #COPYING or Licence
@@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
 SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
 
 inherit gettext autotools
+
+pkg_postinst_${PN} () {
+    if [ "x$D" != "x" ] ; then
+        exit 1
+    fi
+
+    if [ ! -e ${sbindir}/sendmail ]; then
+        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
+    fi
+}
-- 
1.7.1

Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check

[Richard Purdie]

On Fri, 2011-03-18 at 09:34 +0800, Kang Kai wrote:
> From: Kang Kai <kai.kang@windriver.com>
> 
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp in order to pass the test.
> 
> Related to [YOCTO #520]
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>

Shouldn't this be using the update-alternatives mechanism?

Cheers,

Richard

>  meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..5fc4060 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>  PRIORITY = "required"
>  LICENSE = "GPLv3"
>  DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
>  
> 
>  #COPYING or Licence
> @@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>  SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
>  
>  inherit gettext autotools
> +
> +pkg_postinst_${PN} () {
> +    if [ "x$D" != "x" ] ; then
> +        exit 1
> +    fi
> +
> +    if [ ! -e ${sbindir}/sendmail ]; then
> +        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
> +    fi
> +}

Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check

[Kang Kai]

On 2011年03月18日 09:44, Richard Purdie wrote:
> On Fri, 2011-03-18 at 09:34 +0800, Kang Kai wrote:
>> From: Kang Kai<kai.kang@windriver.com>
>>
>> LSB command check will test the exist of sendmail, so make sendmail
>> link to msmtp in order to pass the test.
>>
>> Related to [YOCTO #520]
>>
>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> Shouldn't this be using the update-alternatives mechanism?
Hi Richard,

I updated the patch, using update-alternatives to make links.
Please help me to check in next letter.

Thanks and Regards,
Kai
>>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
>>   1 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> index cb3d83c..5fc4060 100644
>> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> @@ -6,7 +6,7 @@ SECTION = "console/network"
>>   PRIORITY = "required"
>>   LICENSE = "GPLv3"
>>   DEPENDS = "zlib gnutls"
>> -PR = "r0"
>> +PR = "r1"
>>
>>
>>   #COPYING or Licence
>> @@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>>   SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
>>
>>   inherit gettext autotools
>> +
>> +pkg_postinst_${PN} () {
>> +    if [ "x$D" != "x" ] ; then
>> +        exit 1
>> +    fi
>> +
>> +    if [ ! -e ${sbindir}/sendmail ]; then
>> +        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
>> +    fi
>> +}
>

Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check

[Kang Kai]

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test.

Related to [YOCTO #520]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
  meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   10 +++++++++-
  1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb 
b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
index cb3d83c..b3500d0 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
@@ -6,7 +6,7 @@ SECTION = "console/network"
  PRIORITY = "required"
  LICENSE = "GPLv3"
  DEPENDS = "zlib gnutls"
-PR = "r0"
+PR = "r1"


  #COPYING or Licence
@@ -19,3 +19,11 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
  SRC_URI[sha256sum] = 
"269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"

  inherit gettext autotools
+
+pkg_postinst_${PN} () {
+    update-alternatives --install ${sbindir}/sendmail sendmail 
${bindir}/msmtp 100
+}
+
+pkg_prerm_${PN} () {
+    update-alternatives --remove sendmail ${bindir}/msmtp
+}
-- 
1.7.1

Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check

[Richard Purdie]

On Fri, 2011-03-18 at 17:00 +0800, Kang Kai wrote:
> From: Kang Kai <kai.kang@windriver.com>
> 
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp in order to pass the test.
> 
> Related to [YOCTO #520]
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   10 +++++++++-
>   1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb 
> b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..b3500d0 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>   PRIORITY = "required"
>   LICENSE = "GPLv3"
>   DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
> 
> 
>   #COPYING or Licence
> @@ -19,3 +19,11 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>   SRC_URI[sha256sum] = 
> "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
> 
>   inherit gettext autotools
> +
> +pkg_postinst_${PN} () {
> +    update-alternatives --install ${sbindir}/sendmail sendmail 
> ${bindir}/msmtp 100
> +}
> +
> +pkg_prerm_${PN} () {
> +    update-alternatives --remove sendmail ${bindir}/msmtp
> +}

Instead of doing this directly could you use the update-alternatives
class please? meta/recipes-connectivity/iproute2/iproute2.inc shows an
example of this. I think it should be something like:

inherit update-alternatives

ALTERNATIVE_NAME = "sendmail"
ALTERNATIVE_PATH = "${sbindir}/mstmp"
ALTERNATIVE_LINK = "${sbindir}/sendmail"
ALTERNATIVE_PRIORITY = "100"

Thanks,

Richard

[PATCH 1/1] msmtp: add link sendmail for lsb command check

[Kang Kai]

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp using update-alternatives class in order to pass the test.

Related to [YOCTO #520]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
index cb3d83c..d48881a 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
@@ -6,7 +6,7 @@ SECTION = "console/network"
 PRIORITY = "required"
 LICENSE = "GPLv3"
 DEPENDS = "zlib gnutls"
-PR = "r0"
+PR = "r1"
 
 
 #COPYING or Licence
@@ -18,4 +18,9 @@ SRC_URI = "http://sourceforge.net/projects/msmtp/files/msmtp/${PV}/${BPN}-${PV}.
 SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
 SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
 
-inherit gettext autotools
+inherit gettext autotools update-alternatives
+
+ALTERNATIVE_NAME = "sendmail"
+ALTERNATIVE_PATH = "${bindir}/msmtp"
+ALTERNATIVE_LINK = "${sbindir}/sendmail"
+ALTERNATIVE_PRIORITY = "100"
-- 
1.7.1

Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check

[Darren Hart]

On 03/20/2011 07:59 PM, Kang Kai wrote:
> From: Kang Kai<kai.kang@windriver.com>
>
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp using update-alternatives class in order to pass the test.
>
> Related to [YOCTO #520]
>
> Signed-off-by: Kang Kai<kai.kang@windriver.com>

Untested, but this looks like a reasonable thing to do to me, and it 
beats installing postfix or exim!

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |    9 +++++++--
>   1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..d48881a 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>   PRIORITY = "required"
>   LICENSE = "GPLv3"
>   DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
>
>
>   #COPYING or Licence
> @@ -18,4 +18,9 @@ SRC_URI = "http://sourceforge.net/projects/msmtp/files/msmtp/${PV}/${BPN}-${PV}.
>   SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>   SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
>
> -inherit gettext autotools
> +inherit gettext autotools update-alternatives
> +
> +ALTERNATIVE_NAME = "sendmail"
> +ALTERNATIVE_PATH = "${bindir}/msmtp"
> +ALTERNATIVE_LINK = "${sbindir}/sendmail"
> +ALTERNATIVE_PRIORITY = "100"

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel