All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] msmtp: add link sendmail to pass LSB test
@ 2011-03-18  1:34 Kang Kai
  2011-03-18  1:34 ` [PATCH 1/1] msmtp: add link sendmail for lsb command check Kang Kai
  0 siblings, 1 reply; 7+ messages in thread
From: Kang Kai @ 2011-03-18  1:34 UTC (permalink / raw)
  To: poky

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test. 
msmtp has been added to replace sendmail.
    
Related to [YOCTO #520]

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: kangkai/distro01
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro01

Thanks,
    Kang Kai <kai.kang@windriver.com>
---


Kang Kai (1):
  msmtp: add link sendmail for lsb command check

 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/1] msmtp: add link sendmail for lsb command check
  2011-03-18  1:34 [PATCH 0/1] msmtp: add link sendmail to pass LSB test Kang Kai
@ 2011-03-18  1:34 ` Kang Kai
  2011-03-18  1:44   ` Richard Purdie
  0 siblings, 1 reply; 7+ messages in thread
From: Kang Kai @ 2011-03-18  1:34 UTC (permalink / raw)
  To: poky

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test.

Related to [YOCTO #520]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
index cb3d83c..5fc4060 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
@@ -6,7 +6,7 @@ SECTION = "console/network"
 PRIORITY = "required"
 LICENSE = "GPLv3"
 DEPENDS = "zlib gnutls"
-PR = "r0"
+PR = "r1"
 
 
 #COPYING or Licence
@@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
 SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
 
 inherit gettext autotools
+
+pkg_postinst_${PN} () {
+    if [ "x$D" != "x" ] ; then
+        exit 1
+    fi
+
+    if [ ! -e ${sbindir}/sendmail ]; then
+        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
+    fi
+}
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check
  2011-03-18  1:34 ` [PATCH 1/1] msmtp: add link sendmail for lsb command check Kang Kai
@ 2011-03-18  1:44   ` Richard Purdie
  2011-03-18  9:00     ` Kang Kai
  2011-03-18  9:00     ` Kang Kai
  0 siblings, 2 replies; 7+ messages in thread
From: Richard Purdie @ 2011-03-18  1:44 UTC (permalink / raw)
  To: Kang Kai; +Cc: poky

On Fri, 2011-03-18 at 09:34 +0800, Kang Kai wrote:
> From: Kang Kai <kai.kang@windriver.com>
> 
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp in order to pass the test.
> 
> Related to [YOCTO #520]
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>

Shouldn't this be using the update-alternatives mechanism?

Cheers,

Richard

>  meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..5fc4060 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>  PRIORITY = "required"
>  LICENSE = "GPLv3"
>  DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
>  
> 
>  #COPYING or Licence
> @@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>  SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
>  
>  inherit gettext autotools
> +
> +pkg_postinst_${PN} () {
> +    if [ "x$D" != "x" ] ; then
> +        exit 1
> +    fi
> +
> +    if [ ! -e ${sbindir}/sendmail ]; then
> +        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
> +    fi
> +}




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check
  2011-03-18  1:44   ` Richard Purdie
@ 2011-03-18  9:00     ` Kang Kai
  2011-03-18  9:00     ` Kang Kai
  1 sibling, 0 replies; 7+ messages in thread
From: Kang Kai @ 2011-03-18  9:00 UTC (permalink / raw)
  To: Richard Purdie; +Cc: poky

On 2011年03月18日 09:44, Richard Purdie wrote:
> On Fri, 2011-03-18 at 09:34 +0800, Kang Kai wrote:
>> From: Kang Kai<kai.kang@windriver.com>
>>
>> LSB command check will test the exist of sendmail, so make sendmail
>> link to msmtp in order to pass the test.
>>
>> Related to [YOCTO #520]
>>
>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> Shouldn't this be using the update-alternatives mechanism?
Hi Richard,

I updated the patch, using update-alternatives to make links.
Please help me to check in next letter.

Thanks and Regards,
Kai
>>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   12 +++++++++++-
>>   1 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> index cb3d83c..5fc4060 100644
>> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
>> @@ -6,7 +6,7 @@ SECTION = "console/network"
>>   PRIORITY = "required"
>>   LICENSE = "GPLv3"
>>   DEPENDS = "zlib gnutls"
>> -PR = "r0"
>> +PR = "r1"
>>
>>
>>   #COPYING or Licence
>> @@ -19,3 +19,13 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>>   SRC_URI[sha256sum] = "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
>>
>>   inherit gettext autotools
>> +
>> +pkg_postinst_${PN} () {
>> +    if [ "x$D" != "x" ] ; then
>> +        exit 1
>> +    fi
>> +
>> +    if [ ! -e ${sbindir}/sendmail ]; then
>> +        ln -sf ${bindir}/msmtp ${sbindir}/sendmail
>> +    fi
>> +}
>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check
  2011-03-18  1:44   ` Richard Purdie
  2011-03-18  9:00     ` Kang Kai
@ 2011-03-18  9:00     ` Kang Kai
  2011-03-18  9:56       ` Richard Purdie
  1 sibling, 1 reply; 7+ messages in thread
From: Kang Kai @ 2011-03-18  9:00 UTC (permalink / raw)
  To: Richard Purdie; +Cc: poky

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test.

Related to [YOCTO #520]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
  meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   10 +++++++++-
  1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb 
b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
index cb3d83c..b3500d0 100644
--- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
+++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
@@ -6,7 +6,7 @@ SECTION = "console/network"
  PRIORITY = "required"
  LICENSE = "GPLv3"
  DEPENDS = "zlib gnutls"
-PR = "r0"
+PR = "r1"


  #COPYING or Licence
@@ -19,3 +19,11 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
  SRC_URI[sha256sum] = 
"269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"

  inherit gettext autotools
+
+pkg_postinst_${PN} () {
+    update-alternatives --install ${sbindir}/sendmail sendmail 
${bindir}/msmtp 100
+}
+
+pkg_prerm_${PN} () {
+    update-alternatives --remove sendmail ${bindir}/msmtp
+}
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check
  2011-03-18  9:00     ` Kang Kai
@ 2011-03-18  9:56       ` Richard Purdie
  0 siblings, 0 replies; 7+ messages in thread
From: Richard Purdie @ 2011-03-18  9:56 UTC (permalink / raw)
  To: Kang Kai; +Cc: poky

On Fri, 2011-03-18 at 17:00 +0800, Kang Kai wrote:
> From: Kang Kai <kai.kang@windriver.com>
> 
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp in order to pass the test.
> 
> Related to [YOCTO #520]
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   10 +++++++++-
>   1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb 
> b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..b3500d0 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>   PRIORITY = "required"
>   LICENSE = "GPLv3"
>   DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
> 
> 
>   #COPYING or Licence
> @@ -19,3 +19,11 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>   SRC_URI[sha256sum] = 
> "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
> 
>   inherit gettext autotools
> +
> +pkg_postinst_${PN} () {
> +    update-alternatives --install ${sbindir}/sendmail sendmail 
> ${bindir}/msmtp 100
> +}
> +
> +pkg_prerm_${PN} () {
> +    update-alternatives --remove sendmail ${bindir}/msmtp
> +}

Instead of doing this directly could you use the update-alternatives
class please? meta/recipes-connectivity/iproute2/iproute2.inc shows an
example of this. I think it should be something like:

inherit update-alternatives

ALTERNATIVE_NAME = "sendmail"
ALTERNATIVE_PATH = "${sbindir}/mstmp"
ALTERNATIVE_LINK = "${sbindir}/sendmail"
ALTERNATIVE_PRIORITY = "100"

Thanks,

Richard





^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 0/1] msmtp: add link sendmail to pass LSB test
@ 2011-03-21  2:59 Kang Kai
  0 siblings, 0 replies; 7+ messages in thread
From: Kang Kai @ 2011-03-21  2:59 UTC (permalink / raw)
  To: poky

From: Kang Kai <kai.kang@windriver.com>

LSB command check will test the exist of sendmail, so make sendmail
link to msmtp in order to pass the test. 
Update patch using update-alternatives class.
    
Related to [YOCTO #520]

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: kangkai/distro01
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro01

Thanks,
    Kang Kai <kai.kang@windriver.com>
---


Kang Kai (1):
  msmtp: add link sendmail for lsb command check

 meta/recipes-extended/msmtp/msmtp_1.4.23.bb |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-03-21  3:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-18  1:34 [PATCH 0/1] msmtp: add link sendmail to pass LSB test Kang Kai
2011-03-18  1:34 ` [PATCH 1/1] msmtp: add link sendmail for lsb command check Kang Kai
2011-03-18  1:44   ` Richard Purdie
2011-03-18  9:00     ` Kang Kai
2011-03-18  9:00     ` Kang Kai
2011-03-18  9:56       ` Richard Purdie
  -- strict thread matches above, loose matches on Subject: below --
2011-03-21  2:59 [PATCH 0/1] msmtp: add link sendmail to pass LSB test Kang Kai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.