Re: [PATCH] msm: board-msm8960: Add USB peripheral and OTG support

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 22-03-2011 11:51, Anji jonnala wrote:

> Signed-off-by: Anji jonnala <anjir-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
[...]

> diff --git a/arch/arm/mach-msm/devices-msm8960.c b/arch/arm/mach-msm/devices-msm8960.c
> index 894ff98..8baf4fa 100644
> --- a/arch/arm/mach-msm/devices-msm8960.c
> +++ b/arch/arm/mach-msm/devices-msm8960.c
[...]
> @@ -89,6 +90,52 @@ struct platform_device msm8960_device_uart_gsbi5 = {
>   	.resource	= resources_uart_gsbi5,
>   };
>
> +static struct resource resources_otg[] = {
> +	{
> +		.start	= MSM8960_HSUSB_PHYS,
> +		.end	= MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE,

    You forgot "- 1".

> +		.flags	= IORESOURCE_MEM,
> +	},
> +	{
> +		.start	= USB1_HS_IRQ,
> +		.end	= USB1_HS_IRQ,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +};
> +
> +struct platform_device msm_device_otg = {
> +	.name		= "msm_otg",
> +	.id		= -1,
> +	.num_resources	= ARRAY_SIZE(resources_otg),
> +	.resource	= resources_otg,
> +	.dev		= {
> +		.coherent_dma_mask	= 0xffffffff,
> +	},
> +};
> +
> +static struct resource resources_hsusb[] = {
> +	{
> +		.start	= MSM8960_HSUSB_PHYS,
> +		.end	= MSM8960_HSUSB_PHYS + MSM8960_HSUSB_SIZE,

    You forgot "- 1" here too.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html