* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-26 0:29 ` Omar Ramirez Luna
0 siblings, 0 replies; 18+ messages in thread
From: Omar Ramirez Luna @ 2011-03-26 0:29 UTC (permalink / raw)
To: linux-arm-kernel
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_base value (which
coincidentally points to MPU) and not with the actual source
of the error.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index 5f2da75..da917c2 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
/* No timeout error for debug sources */
}
- base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
/* identify the error source */
for (err_source = 0; !(status & (1 << err_source)); err_source++)
;
+
+ base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
+
error = omap3_l3_readll(base, L3_ERROR_LOG);
if (error) {
--
1.7.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-26 0:29 ` Omar Ramirez Luna
@ 2011-03-26 0:44 ` Ramirez Luna, Omar
-1 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-26 0:44 UTC (permalink / raw)
To: Tony Lindgren
Cc: Russell King, l-o, lak, sricharan, Santosh Shilimkar,
Felipe Balbi, Benoit Cousson, Omar Ramirez Luna
On Fri, Mar 25, 2011 at 7:29 PM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
s/err_base/err_source/
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-26 0:44 ` Ramirez Luna, Omar
0 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-26 0:44 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 25, 2011 at 7:29 PM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
s/err_base/err_source/
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-26 0:29 ` Omar Ramirez Luna
@ 2011-03-26 21:38 ` Sergei Shtylyov
-1 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2011-03-26 21:38 UTC (permalink / raw)
To: Omar Ramirez Luna
Cc: Tony Lindgren, Russell King, Benoit Cousson, Felipe Balbi,
sricharan, Santosh Shilimkar, l-o, lak
Hello.
On 26-03-2011 3:29, Omar Ramirez Luna wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
> ---
> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
> /* No timeout error for debug sources */
> }
>
> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> -
> /* identify the error source */
> for (err_source = 0; !(status& (1<< err_source)); err_source++)
> ;
> +
> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> +
What's the point of having () around rvalue? You could drop them, while at
it...
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-26 21:38 ` Sergei Shtylyov
0 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2011-03-26 21:38 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 26-03-2011 3:29, Omar Ramirez Luna wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
> ---
> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
> /* No timeout error for debug sources */
> }
>
> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> -
> /* identify the error source */
> for (err_source = 0; !(status& (1<< err_source)); err_source++)
> ;
> +
> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> +
What's the point of having () around rvalue? You could drop them, while at
it...
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-26 21:38 ` Sergei Shtylyov
@ 2011-03-28 1:49 ` Ramirez Luna, Omar
-1 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 1:49 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Tony Lindgren, Russell King, Benoit Cousson, Felipe Balbi,
sricharan, Santosh Shilimkar, l-o, lak
On Sat, Mar 26, 2011 at 4:38 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> On 26-03-2011 3:29, Omar Ramirez Luna wrote:
>
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>
>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
>> ---
>> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c
>> b/arch/arm/mach-omap2/omap_l3_smx.c
>> index 5f2da75..da917c2 100644
>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void
>> *_l3)
>> /* No timeout error for debug sources */
>> }
>>
>> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> -
>> /* identify the error source */
>> for (err_source = 0; !(status& (1<< err_source)); err_source++)
>> ;
>> +
>> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> +
>
> What's the point of having () around rvalue? You could drop them, while at
> it...
You're right, will do.
Regards,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 1:49 ` Ramirez Luna, Omar
0 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 1:49 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 26, 2011 at 4:38 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> On 26-03-2011 3:29, Omar Ramirez Luna wrote:
>
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>
>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
>> ---
>> ?arch/arm/mach-omap2/omap_l3_smx.c | ? ?5 +++--
>> ?1 files changed, 3 insertions(+), 2 deletions(-)
>
>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c
>> b/arch/arm/mach-omap2/omap_l3_smx.c
>> index 5f2da75..da917c2 100644
>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void
>> *_l3)
>> ? ? ? ? ? ? ? ?/* No timeout error for debug sources */
>> ? ? ? ?}
>>
>> - ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> -
>> ? ? ? ?/* identify the error source */
>> ? ? ? ?for (err_source = 0; !(status& ?(1<< ?err_source)); err_source++)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?;
>> +
>> + ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> +
>
> ? What's the point of having () around rvalue? You could drop them, while at
> it...
You're right, will do.
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-28 1:49 ` Ramirez Luna, Omar
@ 2011-03-28 8:27 ` Sergei Shtylyov
-1 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2011-03-28 8:27 UTC (permalink / raw)
To: Ramirez Luna, Omar
Cc: Sergei Shtylyov, Russell King, Benoit Cousson, Tony Lindgren,
Felipe Balbi, sricharan, Santosh Shilimkar, l-o, lak
Hello.
On 28-03-2011 5:49, Ramirez Luna, Omar wrote:
>>> If an error occurs in the L3 on any other initiator than MPU,
>>> the interrupt goes unhandled given that the 'base' register
>>> was calculated with the initialized err_base value (which
>>> coincidentally points to MPU) and not with the actual source
>>> of the error.
>>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
>>> ---
>>> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
>>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c
>>> b/arch/arm/mach-omap2/omap_l3_smx.c
>>> index 5f2da75..da917c2 100644
>>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void
>>> *_l3)
>>> /* No timeout error for debug sources */
>>> }
>>>
>>> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>>> -
>>> /* identify the error source */
>>> for (err_source = 0; !(status& (1<< err_source)); err_source++)
>>> ;
>>> +
>>> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>>> +
>> What's the point of having () around rvalue? You could drop them, while at
>> it...
> You're right, will do.
The same goes about 'l3->rt' and '*(omap3_l3_bases[int_type] + err_source)'...
> Regards,
> Omar
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 8:27 ` Sergei Shtylyov
0 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2011-03-28 8:27 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 28-03-2011 5:49, Ramirez Luna, Omar wrote:
>>> If an error occurs in the L3 on any other initiator than MPU,
>>> the interrupt goes unhandled given that the 'base' register
>>> was calculated with the initialized err_base value (which
>>> coincidentally points to MPU) and not with the actual source
>>> of the error.
>>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
>>> ---
>>> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
>>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c
>>> b/arch/arm/mach-omap2/omap_l3_smx.c
>>> index 5f2da75..da917c2 100644
>>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void
>>> *_l3)
>>> /* No timeout error for debug sources */
>>> }
>>>
>>> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>>> -
>>> /* identify the error source */
>>> for (err_source = 0; !(status& (1<< err_source)); err_source++)
>>> ;
>>> +
>>> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>>> +
>> What's the point of having () around rvalue? You could drop them, while at
>> it...
> You're right, will do.
The same goes about 'l3->rt' and '*(omap3_l3_bases[int_type] + err_source)'...
> Regards,
> Omar
WBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-26 0:29 ` Omar Ramirez Luna
@ 2011-03-28 1:30 ` Felipe Contreras
-1 siblings, 0 replies; 18+ messages in thread
From: Felipe Contreras @ 2011-03-28 1:30 UTC (permalink / raw)
To: Omar Ramirez Luna
Cc: Tony Lindgren, Russell King, l-o, lak, sricharan,
Santosh Shilimkar, Felipe Balbi, Benoit Cousson
On Sat, Mar 26, 2011 at 2:29 AM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
> /* No timeout error for debug sources */
> }
>
> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> -
> /* identify the error source */
> for (err_source = 0; !(status & (1 << err_source)); err_source++)
> ;
> +
> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> +
> error = omap3_l3_readll(base, L3_ERROR_LOG);
One extra space too much.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 1:30 ` Felipe Contreras
0 siblings, 0 replies; 18+ messages in thread
From: Felipe Contreras @ 2011-03-28 1:30 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 26, 2011 at 2:29 AM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> ?arch/arm/mach-omap2/omap_l3_smx.c | ? ?5 +++--
> ?1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
> ? ? ? ? ? ? ? ?/* No timeout error for debug sources */
> ? ? ? ?}
>
> - ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> -
> ? ? ? ?/* identify the error source */
> ? ? ? ?for (err_source = 0; !(status & (1 << err_source)); err_source++)
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?;
> +
> + ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> +
> ? ? ? ?error = omap3_l3_readll(base, L3_ERROR_LOG);
One extra space too much.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-28 1:30 ` Felipe Contreras
@ 2011-03-28 1:47 ` Ramirez Luna, Omar
-1 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 1:47 UTC (permalink / raw)
To: Felipe Contreras
Cc: Tony Lindgren, Russell King, l-o, lak, sricharan,
Santosh Shilimkar, Felipe Balbi, Benoit Cousson
On Sun, Mar 27, 2011 at 8:30 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> On Sat, Mar 26, 2011 at 2:29 AM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>> ---
>> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
>> index 5f2da75..da917c2 100644
>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
>> /* No timeout error for debug sources */
>> }
>>
>> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> -
>> /* identify the error source */
>> for (err_source = 0; !(status & (1 << err_source)); err_source++)
>> ;
>> +
>> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> +
>> error = omap3_l3_readll(base, L3_ERROR_LOG);
>
> One extra space too much.
Between base and error assignments? Yep, I can remove it.
Regards,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 1:47 ` Ramirez Luna, Omar
0 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 1:47 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Mar 27, 2011 at 8:30 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> On Sat, Mar 26, 2011 at 2:29 AM, Omar Ramirez Luna <omar.ramirez@ti.com> wrote:
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>> ---
>> ?arch/arm/mach-omap2/omap_l3_smx.c | ? ?5 +++--
>> ?1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
>> index 5f2da75..da917c2 100644
>> --- a/arch/arm/mach-omap2/omap_l3_smx.c
>> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
>> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
>> ? ? ? ? ? ? ? ?/* No timeout error for debug sources */
>> ? ? ? ?}
>>
>> - ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> -
>> ? ? ? ?/* identify the error source */
>> ? ? ? ?for (err_source = 0; !(status & (1 << err_source)); err_source++)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?;
>> +
>> + ? ? ? base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
>> +
>> ? ? ? ?error = omap3_l3_readll(base, L3_ERROR_LOG);
>
> One extra space too much.
Between base and error assignments? Yep, I can remove it.
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-26 0:29 ` Omar Ramirez Luna
@ 2011-03-28 5:38 ` Santosh Shilimkar
-1 siblings, 0 replies; 18+ messages in thread
From: Santosh Shilimkar @ 2011-03-28 5:38 UTC (permalink / raw)
To: Omar Ramirez Luna, Tony Lindgren
Cc: Russell King, l-o, lak, Sricharan R, Felipe Balbi, Benoit Cousson
> -----Original Message-----
> From: Omar Ramirez Luna [mailto:omar.ramirez@ti.com]
> Sent: Saturday, March 26, 2011 6:00 AM
> To: Tony Lindgren
> Cc: Russell King; l-o; lak; sricharan; Santosh Shilimkar; Felipe
> Balbi; Benoit Cousson; Omar Ramirez Luna
> Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
>
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Patch looks good. Did you observe this with DSP initiator??
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-
> omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq,
> void *_l3)
> /* No timeout error for debug sources */
> }
>
> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> -
> /* identify the error source */
> for (err_source = 0; !(status & (1 << err_source));
> err_source++)
> ;
> +
> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> +
> error = omap3_l3_readll(base, L3_ERROR_LOG);
>
> if (error) {
> --
> 1.7.1
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 5:38 ` Santosh Shilimkar
0 siblings, 0 replies; 18+ messages in thread
From: Santosh Shilimkar @ 2011-03-28 5:38 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Omar Ramirez Luna [mailto:omar.ramirez at ti.com]
> Sent: Saturday, March 26, 2011 6:00 AM
> To: Tony Lindgren
> Cc: Russell King; l-o; lak; sricharan; Santosh Shilimkar; Felipe
> Balbi; Benoit Cousson; Omar Ramirez Luna
> Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
>
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Patch looks good. Did you observe this with DSP initiator??
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-
> omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq,
> void *_l3)
> /* No timeout error for debug sources */
> }
>
> - base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> -
> /* identify the error source */
> for (err_source = 0; !(status & (1 << err_source));
> err_source++)
> ;
> +
> + base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> +
> error = omap3_l3_readll(base, L3_ERROR_LOG);
>
> if (error) {
> --
> 1.7.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
2011-03-28 5:38 ` Santosh Shilimkar
@ 2011-03-28 15:15 ` Ramirez Luna, Omar
-1 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 15:15 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: Tony Lindgren, Russell King, l-o, lak, Sricharan R, Felipe Balbi,
Benoit Cousson, Sergei Shtylyov
Hi,
On Mon, Mar 28, 2011 at 12:38 AM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>
> Patch looks good. Did you observe this with DSP initiator??
Yes, when loading a base image for the DSP, I got an: In-band Error
Error seen by IVA_SS at address 0; after this fix.
I was planning to remove the duplicated "Error" print too.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Thanks, I'll add it in my next version when I make the changes
affecting only these lines.
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
@ 2011-03-28 15:15 ` Ramirez Luna, Omar
0 siblings, 0 replies; 18+ messages in thread
From: Ramirez Luna, Omar @ 2011-03-28 15:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Mar 28, 2011 at 12:38 AM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
>> If an error occurs in the L3 on any other initiator than MPU,
>> the interrupt goes unhandled given that the 'base' register
>> was calculated with the initialized err_base value (which
>> coincidentally points to MPU) and not with the actual source
>> of the error.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>
> Patch looks good. Did you observe this with DSP initiator??
Yes, when loading a base image for the DSP, I got an: In-band Error
Error seen by IVA_SS at address 0; after this fix.
I was planning to remove the duplicated "Error" print too.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Thanks, I'll add it in my next version when I make the changes
affecting only these lines.
Regards,
Omar
^ permalink raw reply [flat|nested] 18+ messages in thread