From: Huang Shijie <b32955@freescale.com>
To: <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux@arm.linux.org.uk,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org,
David.Woodhouse@intel.com
Subject: Re: [PATCH 5/7] add GPMI support for imx28
Date: Thu, 31 Mar 2011 18:09:05 +0800 [thread overview]
Message-ID: <4D9452C1.4020200@freescale.com> (raw)
In-Reply-To: <1301564849.2828.26.camel@localhost>
Hi:
> On Wed, 2011-03-16 at 09:55 +0800, Huang Shijie wrote:
>> +#define BF_BCH_CTRL_RSVD5(v) \
>> + (((v)<< 23)& BM_BCH_CTRL_RSVD5)
> Many lines where you used "\" fit 80 lines. Just do not use tabs between
> name and value (which is ugly, imo), use a space and then it fits 80
> lines. This neater than splitting things on 2 lines.
>
Please check the latest version of the driver.
The code has been remove in new version.
Best Regards
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] add GPMI support for imx28
Date: Thu, 31 Mar 2011 18:09:05 +0800 [thread overview]
Message-ID: <4D9452C1.4020200@freescale.com> (raw)
In-Reply-To: <1301564849.2828.26.camel@localhost>
Hi:
> On Wed, 2011-03-16 at 09:55 +0800, Huang Shijie wrote:
>> +#define BF_BCH_CTRL_RSVD5(v) \
>> + (((v)<< 23)& BM_BCH_CTRL_RSVD5)
> Many lines where you used "\" fit 80 lines. Just do not use tabs between
> name and value (which is ugly, imo), use a space and then it fits 80
> lines. This neater than splitting things on 2 lines.
>
Please check the latest version of the driver.
The code has been remove in new version.
Best Regards
Huang Shijie
next prev parent reply other threads:[~2011-03-31 10:09 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 1:55 [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 1/7] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 2/7] add the common code for GPMI driver Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 3/7] add the database for the NANDs Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-23 15:29 ` Florian Fainelli
2011-03-23 15:29 ` Florian Fainelli
2011-03-24 2:27 ` Huang Shijie
2011-03-24 2:27 ` Huang Shijie
2011-03-24 13:50 ` Florian Fainelli
2011-03-24 13:50 ` Florian Fainelli
2011-03-25 2:47 ` Huang Shijie
2011-03-25 2:47 ` Huang Shijie
2011-03-25 6:48 ` Lothar Waßmann
2011-03-25 6:48 ` Lothar Waßmann
2011-03-25 6:59 ` Huang Shijie
2011-03-25 6:59 ` Huang Shijie
2011-03-31 9:54 ` Artem Bityutskiy
2011-03-31 9:54 ` Artem Bityutskiy
2011-03-31 10:09 ` Huang Shijie
2011-03-31 10:09 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 4/7] add GPMI support for imx23 Huang Shijie
2011-07-08 16:42 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 5/7] add GPMI support for imx28 Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-31 9:47 ` Artem Bityutskiy
2011-03-31 9:47 ` Artem Bityutskiy
2011-03-31 10:09 ` Huang Shijie [this message]
2011-03-31 10:09 ` Huang Shijie
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-16 1:55 ` [PATCH 6/7] dmaengine: change the flags of request_irq() Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 7/7] MTD : add GPMI driver in the config and Makefile Huang Shijie
2011-03-16 1:55 ` Huang Shijie
2011-03-31 9:44 ` Artem Bityutskiy
2011-03-31 9:44 ` Artem Bityutskiy
2011-03-16 7:12 ` [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Artem Bityutskiy
2011-03-16 7:12 ` Artem Bityutskiy
2011-03-16 7:30 ` Huang Shijie-B32955
2011-03-16 7:30 ` Huang Shijie-B32955
2011-03-22 10:23 ` Huang Shijie
2011-03-22 10:23 ` Huang Shijie
-- strict thread matches above, loose matches on Subject: below --
2011-03-16 1:42 Huang Shijie
2011-03-16 1:42 ` [PATCH 5/7] add GPMI support for imx28 Huang Shijie
2011-03-22 12:46 ` Lothar Waßmann
2011-03-23 3:11 ` Huang Shijie
2011-03-23 3:11 ` Huang Shijie
2011-03-23 14:56 ` Lothar Waßmann
2011-03-23 14:56 ` Lothar Waßmann
2011-03-23 15:16 ` Florian Fainelli
2011-03-23 15:16 ` Florian Fainelli
2011-03-24 3:07 ` Huang Shijie
2011-03-24 3:07 ` Huang Shijie
2011-03-24 3:03 ` Huang Shijie
2011-03-24 3:03 ` Huang Shijie
2011-03-24 7:34 ` Lothar Waßmann
2011-03-24 7:34 ` Lothar Waßmann
2011-03-24 8:26 ` Jason Liu
2011-03-24 8:26 ` Jason Liu
2011-03-24 8:32 ` Wolfram Sang
2011-03-24 8:32 ` Wolfram Sang
2011-03-24 8:33 ` Lothar Waßmann
2011-03-24 8:33 ` Lothar Waßmann
2011-03-24 8:51 ` Huang Shijie
2011-03-24 8:51 ` Huang Shijie
2011-03-24 13:54 ` Florian Fainelli
2011-03-24 13:54 ` Florian Fainelli
2011-03-25 2:50 ` Huang Shijie
2011-03-25 2:50 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9452C1.4020200@freescale.com \
--to=b32955@freescale.com \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.