From: Bryan Huntsman <bryanh@codeaurora.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Neil Leeder <nleeder@codeaurora.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jean Pihet <jean.pihet@newoldbits.com>,
Sheetal Sahasrabudhe <sheetals@codeaurora.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-arm-kernel@lists.infradead.org, jamie.iles@picochip.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: accessing vfpinstr macros from outside vfp directory
Date: Fri, 01 Apr 2011 14:54:35 -0700 [thread overview]
Message-ID: <4D96499B.5070402@codeaurora.org> (raw)
In-Reply-To: <1301678843.17592.5.camel@e102144-lin.cambridge.arm.com>
On 04/01/11 10:27, Will Deacon wrote:
> Neil,
>
> On Tue, 2011-03-29 at 22:04 +0100, Neil Leeder wrote:
>> Any opinions on what would be the best thing to do here? Choices appear to be:
>>
>> 1) allow the relative include path of ../vfp/vfpinstr.h
>> 2) move the definitions of fmrx, fmxr from vfp/vfpinstr.h to include/asm/vfp.h
>> 3) move vfp/vfpinstr.h to include/asm
>> 4) other...?
>>
>> If it helps, I can create a patch for whichever is considered the preferred solution.
>>
>
> I personally don't find option (1) that offensive - Bryan seemed to
> differ though so perhaps option (2) would keep him happy?
>
> I don't think option (3) is sensible given that the majority of the
> header file is private to /vfp.
>
> Will
I raised it as a question. If that's the only sane thing to do here,
then do it. Since no one else seems to have chimed in on (2) or (3),
I'm fine with the patch as-is.
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: bryanh@codeaurora.org (Bryan Huntsman)
To: linux-arm-kernel@lists.infradead.org
Subject: accessing vfpinstr macros from outside vfp directory
Date: Fri, 01 Apr 2011 14:54:35 -0700 [thread overview]
Message-ID: <4D96499B.5070402@codeaurora.org> (raw)
In-Reply-To: <1301678843.17592.5.camel@e102144-lin.cambridge.arm.com>
On 04/01/11 10:27, Will Deacon wrote:
> Neil,
>
> On Tue, 2011-03-29 at 22:04 +0100, Neil Leeder wrote:
>> Any opinions on what would be the best thing to do here? Choices appear to be:
>>
>> 1) allow the relative include path of ../vfp/vfpinstr.h
>> 2) move the definitions of fmrx, fmxr from vfp/vfpinstr.h to include/asm/vfp.h
>> 3) move vfp/vfpinstr.h to include/asm
>> 4) other...?
>>
>> If it helps, I can create a patch for whichever is considered the preferred solution.
>>
>
> I personally don't find option (1) that offensive - Bryan seemed to
> differ though so perhaps option (2) would keep him happy?
>
> I don't think option (3) is sensible given that the majority of the
> header file is private to /vfp.
>
> Will
I raised it as a question. If that's the only sane thing to do here,
then do it. Since no one else seems to have chimed in on (2) or (3),
I'm fine with the patch as-is.
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-01 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 21:04 accessing vfpinstr macros from outside vfp directory Neil Leeder
2011-03-29 21:04 ` Neil Leeder
2011-04-01 17:27 ` Will Deacon
2011-04-01 17:27 ` Will Deacon
2011-04-01 21:54 ` Bryan Huntsman [this message]
2011-04-01 21:54 ` Bryan Huntsman
2011-04-03 12:24 ` Will Deacon
2011-04-03 12:24 ` Will Deacon
2011-04-04 14:16 ` Neil Leeder
2011-04-04 14:16 ` Neil Leeder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D96499B.5070402@codeaurora.org \
--to=bryanh@codeaurora.org \
--cc=jamie.iles@picochip.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=nleeder@codeaurora.org \
--cc=sheetals@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.