Re: [RFC PATCH 08/20] include: add set preferred ue mode api

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

Hi Vijay,

On 04/11/2011 05:20 AM, Vijay Nayani wrote:
> ---
>  include/modem.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/modem.h b/include/modem.h
> index 5a34370..e416f50 100644
> --- a/include/modem.h
> +++ b/include/modem.h
> @@ -51,6 +51,8 @@ void ofono_modem_reset(struct ofono_modem *modem);
>  void ofono_modem_set_powered(struct ofono_modem *modem, ofono_bool_t powered);
>  ofono_bool_t ofono_modem_get_powered(struct ofono_modem *modem);
>  
> +void ofono_modem_set_preferred_ue_mode(struct ofono_modem *modem, int mode);
> +

Are you assuming that the UE mode cannot be changed? If so, doesn't this
map to +CEMODE AT command? Doesn't it allow a set operation to change
the UE mode?

>  ofono_bool_t ofono_modem_get_online(struct ofono_modem *modem);
>  
>  ofono_bool_t ofono_modem_get_emergency_mode(struct ofono_modem *modem);

Regards,
-Denis