From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 09/20] modem: add preferred ue mode handling
Date: Mon, 11 Apr 2011 14:36:03 -0500 [thread overview]
Message-ID: <4DA35823.7070803@gmail.com> (raw)
In-Reply-To: <1302517218-2147-10-git-send-email-vijay.nayani@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
Hi Vijay,
> +static const char *preferred_ue_mode_to_string(int mode)
> +{
> + switch (mode) {
> + case PREFERRED_UE_MODE_PS_DATA_CENTRIC:
> + return "PS mode 2";
> + case PREFERRED_UE_MODE_CS_PS_VOICE_CENTRIC:
> + return "PS/CS mode 1";
> + case PREFERRED_UE_MODE_CS_PS_DATA_CENTRIC:
> + return "PS/CS mode 2";
> + case PREFERRED_UE_MODE_PS_VOICE_CENTRIC:
> + return "PS mode 1";
> + }
> +
> + return "unknown";
> +}
> +
These values are really not telling anyone anything. How do you
envision the upper layers using this information?
Regards,
-Denis
next prev parent reply other threads:[~2011-04-11 19:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 10:19 [RFC PATCH 00/20] *** LTE support with CSFB voice solution *** Vijay Nayani
2011-04-11 10:19 ` [RFC PATCH 01/20] include: add generalised packet headers Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 02/20] build: " Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 03/20] gprs: move bearer_to_string to common file Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 04/20] build: add generalised packet files Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 05/20] atmodem: add generalised packet source Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 06/20] phonesim: use generalised packet source files Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 07/20] common: add preferred_ue_mode enum Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 08/20] include: add set preferred ue mode api Vijay Nayani
2011-04-11 19:34 ` Denis Kenzior
2011-04-12 10:10 ` Vijay.Nayani
2011-04-12 13:52 ` Denis Kenzior
2011-04-11 10:20 ` [RFC PATCH 09/20] modem: add preferred ue mode handling Vijay Nayani
2011-04-11 19:36 ` Denis Kenzior [this message]
2011-04-12 11:42 ` Vijay.Nayani
2011-04-12 13:59 ` Denis Kenzior
2011-04-11 10:20 ` [RFC PATCH 10/20] doc: add PreferredMode property to modem Vijay Nayani
2011-04-11 19:27 ` Denis Kenzior
2011-04-12 11:51 ` Vijay.Nayani
2011-04-12 14:02 ` Denis Kenzior
2011-04-11 10:20 ` [RFC PATCH 11/20] modem: generalise feature map table Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 12/20] packet: add context type default Vijay Nayani
2011-04-11 19:40 ` Denis Kenzior
2011-04-12 2:49 ` Marcel Holtmann
2011-04-11 10:20 ` [RFC PATCH 13/20] include: add get technology api Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 14/20] packet: add get technology api implementation Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 15/20] include: add default context param and api Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 16/20] packet: add default context implementation Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 17/20] atmodem: add lte specific functions Vijay Nayani
2011-04-11 19:54 ` Denis Kenzior
2011-04-12 10:11 ` Vijay.Nayani
2011-04-12 13:56 ` Denis Kenzior
2011-04-12 3:43 ` Marcel Holtmann
2011-04-12 12:48 ` Vijay.Nayani
2011-04-12 14:07 ` Denis Kenzior
2011-04-11 10:20 ` [RFC PATCH 18/20] phonesim: Add cemode query implementation Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 19/20] phonesim: atoms creation based on UE mode Vijay Nayani
2011-04-11 10:20 ` [RFC PATCH 20/20] modem: Add netreg watch for tech switch Vijay Nayani
2011-04-11 19:57 ` Denis Kenzior
2011-04-12 10:19 ` Vijay.Nayani
2011-04-12 13:58 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA35823.7070803@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.