Re: [RFC PATCH 12/20] packet: add context type default

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Hi Vijay,

On 04/11/2011 05:20 AM, Vijay Nayani wrote:
> OFONO_PACKET_CONTEXT_TYPE_DEFAULT is added to
> ofono_packet_context_type and conversion functions
> are updated for the same.
> ---
>  include/packet-context.h |    1 +
>  src/packet.c             |    7 +++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/include/packet-context.h b/include/packet-context.h
> index 44fd69f..02a5c42 100644
> --- a/include/packet-context.h
> +++ b/include/packet-context.h
> @@ -47,6 +47,7 @@ enum ofono_packet_context_type {
>  	OFONO_PACKET_CONTEXT_TYPE_MMS,
>  	OFONO_PACKET_CONTEXT_TYPE_WAP,
>  	OFONO_PACKET_CONTEXT_TYPE_IMS,
> +	OFONO_PACKET_CONTEXT_TYPE_DEFAULT,
>  };
>  

My understanding was that whether an EPS bearer is 'default' has no
bearing on what context type (e.g. ims, internet, mms) it actually is.
I remember there was a conversation on how a 'default' context is
chosen, but I already forgot most of it.

To me it makes no sense that a default context is going to be anything
other than internet or ims.  The fact that it is a 'default' context
doesn't really help the upper layers in any way.  Especially ConnMan
needs to know whether this context can be used for internet access or not.

Regards,
-Denis