From: viresh kumar <viresh.kumar@st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
amitgoel <amit.goel@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>
Subject: Re: [PATCH] dmaengine: implement pause and resume for dw_dmac
Date: Tue, 19 Apr 2011 11:34:23 +0530 [thread overview]
Message-ID: <4DAD25E7.4030602@st.com> (raw)
In-Reply-To: <4DAD1DA5.7010801@st.com>
On 04/19/2011 10:59 AM, viresh kumar wrote:
> On 04/19/2011 06:01 AM, Linus Walleij wrote:
>> > It seems that the SPEAr needs this.
>> >
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Thanks for sending this.
> Actually i wasn't sure that disabling channel will simply pause it, and not
> finish the transfer. So, didn't went for this change.
>
>> > ---
>> > drivers/dma/dw_dmac.c | 22 ++++++++++++++++++++--
>> > drivers/dma/dw_dmac_regs.h | 1 +
>> > 2 files changed, 21 insertions(+), 2 deletions(-)
Moreover, dwc_tx_status() must be updated to add following code:
if (dwc->paused)
return DMA_PAUSED;
Will do that while sending it in my patchset.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@st.com (viresh kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: implement pause and resume for dw_dmac
Date: Tue, 19 Apr 2011 11:34:23 +0530 [thread overview]
Message-ID: <4DAD25E7.4030602@st.com> (raw)
In-Reply-To: <4DAD1DA5.7010801@st.com>
On 04/19/2011 10:59 AM, viresh kumar wrote:
> On 04/19/2011 06:01 AM, Linus Walleij wrote:
>> > It seems that the SPEAr needs this.
>> >
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Thanks for sending this.
> Actually i wasn't sure that disabling channel will simply pause it, and not
> finish the transfer. So, didn't went for this change.
>
>> > ---
>> > drivers/dma/dw_dmac.c | 22 ++++++++++++++++++++--
>> > drivers/dma/dw_dmac_regs.h | 1 +
>> > 2 files changed, 21 insertions(+), 2 deletions(-)
Moreover, dwc_tx_status() must be updated to add following code:
if (dwc->paused)
return DMA_PAUSED;
Will do that while sending it in my patchset.
--
viresh
next prev parent reply other threads:[~2011-04-19 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 0:31 [PATCH] dmaengine: implement pause and resume for dw_dmac Linus Walleij
2011-04-19 0:31 ` Linus Walleij
2011-04-19 0:31 ` Linus Walleij
2011-04-19 5:29 ` viresh kumar
2011-04-19 5:29 ` viresh kumar
2011-04-19 6:04 ` viresh kumar [this message]
2011-04-19 6:04 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD25E7.4030602@st.com \
--to=viresh.kumar@st.com \
--cc=amit.goel@st.com \
--cc=armando.visconti@st.com \
--cc=dan.j.williams@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shiraz.hashim@st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.