* Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
[not found] <E1QFme6-0000lI-Pf@domain.hid>
@ 2011-04-29 18:38 ` Gilles Chanteperdrix
2011-04-30 10:47 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Gilles Chanteperdrix @ 2011-04-29 18:38 UTC (permalink / raw)
To: xenomai@xenomai.org
GIT version control wrote:
> Module: xenomai-jki
> Branch: for-upstream
> Commit: 852c130d16410a597536c39d06b6abd1c9c6c822
> URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822
>
> Author: Jan Kiszka <jan.kiszka@domain.hid>
> Date: Fri Apr 29 14:12:13 2011 +0200
>
> x86: Fix return type of DO_SYSCALL_INNER macro
>
> gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter
> its value' with -Wconversion as DO_SYSCALL treats the return value of
> DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
Should not it be aligned the other way around? Using longs everywhere?
In case a syscall returns a pointer?
--
Gilles.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
2011-04-29 18:38 ` [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro Gilles Chanteperdrix
@ 2011-04-30 10:47 ` Jan Kiszka
2011-04-30 11:05 ` Gilles Chanteperdrix
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2011-04-30 10:47 UTC (permalink / raw)
To: Gilles Chanteperdrix; +Cc: xenomai@xenomai.org
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On 2011-04-29 20:38, Gilles Chanteperdrix wrote:
> GIT version control wrote:
>> Module: xenomai-jki
>> Branch: for-upstream
>> Commit: 852c130d16410a597536c39d06b6abd1c9c6c822
>> URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822
>>
>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>> Date: Fri Apr 29 14:12:13 2011 +0200
>>
>> x86: Fix return type of DO_SYSCALL_INNER macro
>>
>> gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter
>> its value' with -Wconversion as DO_SYSCALL treats the return value of
>> DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>
> Should not it be aligned the other way around? Using longs everywhere?
> In case a syscall returns a pointer?
Maybe. But let's do this when we have a use case. Lots of arch macros,
inline functions, and core code would have to be touched.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro
2011-04-30 10:47 ` Jan Kiszka
@ 2011-04-30 11:05 ` Gilles Chanteperdrix
0 siblings, 0 replies; 3+ messages in thread
From: Gilles Chanteperdrix @ 2011-04-30 11:05 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai@xenomai.org
Jan Kiszka wrote:
> On 2011-04-29 20:38, Gilles Chanteperdrix wrote:
>> GIT version control wrote:
>>> Module: xenomai-jki
>>> Branch: for-upstream
>>> Commit: 852c130d16410a597536c39d06b6abd1c9c6c822
>>> URL: http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=852c130d16410a597536c39d06b6abd1c9c6c822
>>>
>>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>>> Date: Fri Apr 29 14:12:13 2011 +0200
>>>
>>> x86: Fix return type of DO_SYSCALL_INNER macro
>>>
>>> gcc will complain about 'conversion to ‘int’ from ‘long int’ may alter
>>> its value' with -Wconversion as DO_SYSCALL treats the return value of
>>> DO_SYSCALL_INNER as int. Align DO_SYSCALL_INNER to its user.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>> Should not it be aligned the other way around? Using longs everywhere?
>> In case a syscall returns a pointer?
>
> Maybe. But let's do this when we have a use case. Lots of arch macros,
> inline functions, and core code would have to be touched.
Right, sorry for the noise.
--
Gilles.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-30 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1QFme6-0000lI-Pf@domain.hid>
2011-04-29 18:38 ` [Xenomai-core] [Xenomai-git] Jan Kiszka : x86: Fix return type of DO_SYSCALL_INNER macro Gilles Chanteperdrix
2011-04-30 10:47 ` Jan Kiszka
2011-04-30 11:05 ` Gilles Chanteperdrix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.