Re: [PATCH v2] Import Linux headers for KVM and vhost

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2011-05-03 22:22, Peter Maydell wrote:
> On 3 May 2011 17:48, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> +++ b/scripts/update-linux-headers.sh
>> @@ -0,0 +1,47 @@
>> +#!/bin/sh
> 
> No -e ?
> 
>> +rm -rf $output/include/linux/*
> 
> Given that updating the kernel headers will blow away large
> subsets of include/ like this, maybe we should use a less generic
> name than "include", so it's clear that it's just a set of
> automatically maintained and updated files, rather than
> a good place to put random QEMU header files?
> 
> kernel-headers/ seems like an obvious choice.
> 
> Is it worth having a README in the directory saying "don't
> edit these, they are copies of the kernel headers, they can
> be updated with <whatever>", or is that unnecessary?
> 

No, these suggestion all make sense. I've incorporated them.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux