From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and vhost
Date: Tue, 03 May 2011 17:32:59 +0200 [thread overview]
Message-ID: <4DC0202B.5020407@siemens.com> (raw)
In-Reply-To: <20110503151234.GA13171@lst.de>
On 2011-05-03 17:12, Christoph Hellwig wrote:
> On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
>> This helps reducing our build-time checks for feature support in the
>> available Linux kernel headers. And it helps users that do not have
>> sufficiently recent headers installed on their build machine.
>>
>> Header upstate is triggered via 'make update-linux-headers', optionally
>> specifying a kernel directory as source via 'LINUX='.
>
> Why not make it a shell scripts? It's not like it's part of the build
> system. I also think the source tree argument should be mandatory instead
> of grabbing random headers.
Yes, makes sense. I just adopted the kvm-kmod style here which I'm used to.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and vhost
Date: Tue, 03 May 2011 17:32:59 +0200 [thread overview]
Message-ID: <4DC0202B.5020407@siemens.com> (raw)
In-Reply-To: <20110503151234.GA13171@lst.de>
On 2011-05-03 17:12, Christoph Hellwig wrote:
> On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
>> This helps reducing our build-time checks for feature support in the
>> available Linux kernel headers. And it helps users that do not have
>> sufficiently recent headers installed on their build machine.
>>
>> Header upstate is triggered via 'make update-linux-headers', optionally
>> specifying a kernel directory as source via 'LINUX='.
>
> Why not make it a shell scripts? It's not like it's part of the build
> system. I also think the source tree argument should be mandatory instead
> of grabbing random headers.
Yes, makes sense. I just adopted the kvm-kmod style here which I'm used to.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-05-03 15:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:05 [RFC][PATCH] Import Linux headers for KVM and vhost Jan Kiszka
2011-05-03 14:05 ` [Qemu-devel] " Jan Kiszka
2011-05-03 15:12 ` Christoph Hellwig
2011-05-03 15:12 ` Christoph Hellwig
2011-05-03 15:32 ` Jan Kiszka [this message]
2011-05-03 15:32 ` Jan Kiszka
2011-05-03 15:41 ` Arnd Bergmann
2011-05-03 15:41 ` [Qemu-devel] " Arnd Bergmann
2011-05-03 16:48 ` [PATCH v2] " Jan Kiszka
2011-05-03 16:48 ` [Qemu-devel] " Jan Kiszka
2011-05-03 16:55 ` Avi Kivity
2011-05-03 16:55 ` [Qemu-devel] " Avi Kivity
2011-05-03 17:09 ` Jan Kiszka
2011-05-03 17:09 ` [Qemu-devel] " Jan Kiszka
2011-05-03 17:13 ` Avi Kivity
2011-05-03 17:13 ` [Qemu-devel] " Avi Kivity
2011-05-03 17:32 ` Edgar E. Iglesias
2011-05-03 17:32 ` [Qemu-devel] " Edgar E. Iglesias
2011-05-03 17:39 ` Jan Kiszka
2011-05-03 17:39 ` [Qemu-devel] " Jan Kiszka
2011-05-03 17:57 ` Scott Wood
2011-05-03 17:57 ` Scott Wood
2011-05-03 19:26 ` Arnd Bergmann
2011-05-03 19:26 ` Arnd Bergmann
2011-05-03 17:30 ` Peter Maydell
2011-05-03 17:30 ` Peter Maydell
2011-05-03 17:42 ` Jan Kiszka
2011-05-03 17:42 ` [Qemu-devel] " Jan Kiszka
2011-05-03 17:45 ` Anthony Liguori
2011-05-03 17:45 ` Anthony Liguori
2011-05-03 17:55 ` Jan Kiszka
2011-05-03 17:55 ` [Qemu-devel] " Jan Kiszka
2011-05-03 17:59 ` Anthony Liguori
2011-05-03 17:59 ` Anthony Liguori
2011-05-03 21:37 ` Michael S. Tsirkin
2011-05-03 21:37 ` [Qemu-devel] " Michael S. Tsirkin
2011-05-04 8:55 ` Jan Kiszka
2011-05-04 8:55 ` [Qemu-devel] " Jan Kiszka
2011-05-09 3:24 ` Rusty Russell
2011-05-09 3:24 ` [Qemu-devel] " Rusty Russell
2011-05-03 20:22 ` Peter Maydell
2011-05-03 20:22 ` Peter Maydell
2011-05-04 10:28 ` Jan Kiszka
2011-05-04 10:28 ` [Qemu-devel] " Jan Kiszka
2011-05-04 17:58 ` Andreas Färber
2011-05-04 18:01 ` Jan Kiszka
2011-05-04 18:01 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC0202B.5020407@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.