From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFO empty
Date: Tue, 10 May 2011 15:56:15 +0400 [thread overview]
Message-ID: <4DC927DF.1060808@ru.mvista.com> (raw)
In-Reply-To: <1304957497-22814-1-git-send-email-nicolas.ferre@atmel.com>
Hello.
On 09-05-2011 20:11, Nicolas Ferre wrote:
> The addition of the pause feature to atc_control an active wait was introduced
> to check the FIFO empty event.
Couldn't parse this -- did you forget "with"at the start of the statement?
> This event was not always happening and
> a timout contition was needed.
> But, in some cases, this event depend on the peripheral connected to the
> channel that is paused: FIFO becomes empty if the peripheral consumes data.
> The timeout is pretty difficult to evaluate. Moreover, this check is not
> needed.
> In conclusion, it seems sensible to entirely remove the checking of
> "FIFO empty" status when pausing.
> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFO empty
Date: Tue, 10 May 2011 15:56:15 +0400 [thread overview]
Message-ID: <4DC927DF.1060808@ru.mvista.com> (raw)
In-Reply-To: <1304957497-22814-1-git-send-email-nicolas.ferre@atmel.com>
Hello.
On 09-05-2011 20:11, Nicolas Ferre wrote:
> The addition of the pause feature to atc_control an active wait was introduced
> to check the FIFO empty event.
Couldn't parse this -- did you forget "with"at the start of the statement?
> This event was not always happening and
> a timout contition was needed.
> But, in some cases, this event depend on the peripheral connected to the
> channel that is paused: FIFO becomes empty if the peripheral consumes data.
> The timeout is pretty difficult to evaluate. Moreover, this check is not
> needed.
> In conclusion, it seems sensible to entirely remove the checking of
> "FIFO empty" status when pausing.
> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
WBR, Sergei
next prev parent reply other threads:[~2011-05-10 11:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 18:14 [PATCH 1/2] dmaengine: at_hdmac: set residue as total len in atc_tx_status Nicolas Ferre
2011-05-04 18:14 ` Nicolas Ferre
2011-05-04 18:14 ` [PATCH 2/2] dmaengine: at_hdmac: implement pause and resume in atc_control Nicolas Ferre
2011-05-04 18:14 ` Nicolas Ferre
2011-05-07 18:05 ` Linus Walleij
2011-05-07 18:05 ` Linus Walleij
2011-05-06 17:56 ` [PATCH v2 1/3] dmaengine: at_hdmac: set residue as total len in atc_tx_status Nicolas Ferre
2011-05-06 17:56 ` Nicolas Ferre
2011-05-06 17:56 ` [PATCH v2 2/3] dmaengine: at_hdmac: implement pause and resume in atc_control Nicolas Ferre
2011-05-06 17:56 ` Nicolas Ferre
2011-05-06 16:56 ` Nicolas Ferre
2011-05-06 16:56 ` Nicolas Ferre
2011-05-09 16:11 ` [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFO empty Nicolas Ferre
2011-05-09 16:11 ` Nicolas Ferre
2011-05-10 11:56 ` Sergei Shtylyov [this message]
2011-05-10 11:56 ` Sergei Shtylyov
2011-05-10 12:05 ` Nicolas Ferre
2011-05-10 12:05 ` Nicolas Ferre
2011-05-11 16:53 ` Koul, Vinod
2011-05-11 16:53 ` Koul, Vinod
2011-05-12 8:28 ` Koul, Vinod
2011-05-12 8:28 ` Koul, Vinod
2011-05-12 9:20 ` Nicolas Ferre
2011-05-12 9:20 ` Nicolas Ferre
2011-05-06 17:56 ` [PATCH v2 3/3] dmaengine: at_hdmac: use descriptor chaining help function Nicolas Ferre
2011-05-06 17:56 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC927DF.1060808@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.