From: Liam Girdwood <lrg@ti.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Taylor Hutt <thutt@chromium.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] Max98095: Move existing NULL check before pointer dereference.
Date: Wed, 18 May 2011 10:32:39 +0100 [thread overview]
Message-ID: <4DD39237.5040905@ti.com> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40DDDA179DA@ITSVLEX06.it.maxim-ic.internal>
On 18/05/11 02:28, Peter Hsiang wrote:
> On Tue, May 17, 2011, Taylor Hutt wrote:
>
>> Visual inspection shows that max98095_put_eq_enum() and
>> max98095_put_bq_enum() each have a possible NULL deref of 'pdata'.
>>
>> This change moves the NULL check above the use.
>>
>> BUG=none
>> TEST=Visual inspection
>
> Mark, this patch looks good.
> Thank you Taylor.
>
Acked-by: Liam Girdwood <lrg@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@ti.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: Taylor Hutt <thutt@chromium.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] Max98095: Move existing NULL check before pointer dereference.
Date: Wed, 18 May 2011 10:32:39 +0100 [thread overview]
Message-ID: <4DD39237.5040905@ti.com> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40DDDA179DA@ITSVLEX06.it.maxim-ic.internal>
On 18/05/11 02:28, Peter Hsiang wrote:
> On Tue, May 17, 2011, Taylor Hutt wrote:
>
>> Visual inspection shows that max98095_put_eq_enum() and
>> max98095_put_bq_enum() each have a possible NULL deref of 'pdata'.
>>
>> This change moves the NULL check above the use.
>>
>> BUG=none
>> TEST=Visual inspection
>
> Mark, this patch looks good.
> Thank you Taylor.
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-05-18 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 1:03 [PATCH] Max98095: Move existing NULL check before pointer dereference Taylor Hutt
2011-05-18 1:28 ` Peter Hsiang
2011-05-18 1:28 ` Peter Hsiang
2011-05-18 7:06 ` Mark Brown
2011-05-18 13:53 ` Peter Hsiang
2011-05-18 9:32 ` Liam Girdwood [this message]
2011-05-18 9:32 ` [alsa-devel] " Liam Girdwood
2011-05-18 16:38 ` Mark Brown
2011-05-18 16:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD39237.5040905@ti.com \
--to=lrg@ti.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=thutt@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.