Re: [RFC v1] Add declarations for hierarchical memory region API

[Avi Kivity <avi@redhat.com>]

On 05/20/2011 08:59 PM, Blue Swirl wrote:
> On Thu, May 19, 2011 at 5:12 PM, Avi Kivity<avi@redhat.com>  wrote:
> >  The memory API separates the attributes of a memory region (its size, how
> >  reads or writes are handled, dirty logging, and coalescing) from where it
> >  is mapped and whether it is enabled.  This allows a device to configure
> >  a memory region once, then hand it off to its parent bus to map it according
> >  to the bus configuration.
> >
> >  Hierarchical registration also allows a device to compose a region out of
> >  a number of sub-regions with different properties; for example some may be
> >  RAM while others may be MMIO.
> >
> >  +/* Destroy a memory region.  The memory becomes inaccessible. */
> >  +void memory_region_destroy(MemoryRegion *mr);
>
> Doesn't the lower priority region become accessible instead in some cases?

If we require that _add_subregion() and _del_subregion() be paired, then no.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.