* V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression
@ 2011-05-30 12:33 Santosh Shilimkar
2011-05-31 6:46 ` T Krishnamoorthy, Balaji
0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shilimkar @ 2011-05-30 12:33 UTC (permalink / raw)
To: l-o; +Cc: Krishnamoorthy, Balaji T
While trying out V3.0-rc1, I noticed couple of regressions. Am
posting this in case anybody come across same issues.
1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error
continuously.
Balaji is planning post right fix for the same, but just
in case you get around this issue,
diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
index b2f30be..94ae400 100644
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device
*dev, int slot,
int power_on, int vdd)
{
u32 reg;
+ unsigned long timeout;
if (power_on) {
reg = omap4_ctrl_pad_readl(control_pbias_offset);
@@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct
device *dev, int slot,
OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
omap4_ctrl_pad_writel(reg, control_pbias_offset);
/* 4 microsec delay for comparator to generate an error*/
- udelay(4);
+ timeout = jiffies + msecs_to_jiffies(500);
+ do {
+ reg = omap4_ctrl_pad_readl(control_pbias_offset);
+ if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
+ break;
+ mdelay(1);
+ } while (!time_after(jiffies, timeout));
+
reg = omap4_ctrl_pad_readl(control_pbias_offset);
if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
pr_err("Pbias Voltage is not same as LDO\n");
2. can't open /dev/ttyO2: No such file or directory
This is not obvious console entry missing problem in FS.
Need to look at this further.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression
2011-05-30 12:33 V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression Santosh Shilimkar
@ 2011-05-31 6:46 ` T Krishnamoorthy, Balaji
2011-05-31 7:08 ` Santosh Shilimkar
0 siblings, 1 reply; 3+ messages in thread
From: T Krishnamoorthy, Balaji @ 2011-05-31 6:46 UTC (permalink / raw)
To: Santosh Shilimkar; +Cc: l-o
On Mon, May 30, 2011 at 6:03 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> While trying out V3.0-rc1, I noticed couple of regressions. Am
> posting this in case anybody come across same issues.
>
> 1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error
> continuously.
>
> Balaji is planning post right fix for the same, but just
> in case you get around this issue,
>
Hi Santosh,
You can find MMC pbias fix here
http://www.spinics.net/lists/linux-omap/msg51735.html
> diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
> index b2f30be..94ae400 100644
> --- a/arch/arm/mach-omap2/hsmmc.c
> +++ b/arch/arm/mach-omap2/hsmmc.c
> @@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device
> *dev, int slot,
> int power_on, int vdd)
> {
> u32 reg;
> + unsigned long timeout;
>
> if (power_on) {
> reg = omap4_ctrl_pad_readl(control_pbias_offset);
> @@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct device
> *dev, int slot,
> OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
> omap4_ctrl_pad_writel(reg, control_pbias_offset);
> /* 4 microsec delay for comparator to generate an error*/
> - udelay(4);
> + timeout = jiffies + msecs_to_jiffies(500);
> + do {
> + reg = omap4_ctrl_pad_readl(control_pbias_offset);
> + if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
> + break;
> + mdelay(1);
> + } while (!time_after(jiffies, timeout));
> +
> reg = omap4_ctrl_pad_readl(control_pbias_offset);
> if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
> pr_err("Pbias Voltage is not same as LDO\n");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression
2011-05-31 6:46 ` T Krishnamoorthy, Balaji
@ 2011-05-31 7:08 ` Santosh Shilimkar
0 siblings, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2011-05-31 7:08 UTC (permalink / raw)
To: T Krishnamoorthy, Balaji; +Cc: l-o
On 5/31/2011 12:16 PM, T Krishnamoorthy, Balaji wrote:
> On Mon, May 30, 2011 at 6:03 PM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
>> While trying out V3.0-rc1, I noticed couple of regressions. Am
>> posting this in case anybody come across same issues.
>>
>> 1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error
>> continuously.
>>
>> Balaji is planning post right fix for the same, but just
>> in case you get around this issue,
>>
>
> Hi Santosh,
> You can find MMC pbias fix here
> http://www.spinics.net/lists/linux-omap/msg51735.html
>
Thanks Balaji.
Regards
Santosh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-31 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-30 12:33 V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression Santosh Shilimkar
2011-05-31 6:46 ` T Krishnamoorthy, Balaji
2011-05-31 7:08 ` Santosh Shilimkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.