From: Avi Kivity <avi@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
aik@ozlabs.ru, joro@8bytes.org, seabios@seabios.org,
qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com,
yamahata@valinux.co.jp, paul@codesourcery.com,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
dwg@au1.ibm.com, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface
Date: Wed, 01 Jun 2011 17:29:56 +0300 [thread overview]
Message-ID: <4DE64CE4.7030300@redhat.com> (raw)
In-Reply-To: <4DE64646.3010505@twiddle.net>
On 06/01/2011 05:01 PM, Richard Henderson wrote:
> > + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write);
>
> I see you didn't take my suggestion for using an opaque callback pointer.
> Really and truly, I won't be able to use this as-is for Alpha.
>
Rather than opaques, please pass the DMA engine itself and use
container_of().
We should be removing opaques, not adding them.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
aik@ozlabs.ru, joro@8bytes.org, seabios@seabios.org,
qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com,
yamahata@valinux.co.jp, kevin@koconnor.net,
paul@codesourcery.com,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
dwg@au1.ibm.com, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface
Date: Wed, 01 Jun 2011 17:29:56 +0300 [thread overview]
Message-ID: <4DE64CE4.7030300@redhat.com> (raw)
In-Reply-To: <4DE64646.3010505@twiddle.net>
On 06/01/2011 05:01 PM, Richard Henderson wrote:
> > + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write);
>
> I see you didn't take my suggestion for using an opaque callback pointer.
> Really and truly, I won't be able to use this as-is for Alpha.
>
Rather than opaques, please pass the DMA engine itself and use
container_of().
We should be removing opaques, not adding them.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-01 14:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 1:38 [RFC PATCH 00/13] AMD IOMMU emulation patches, another try Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 01/13] Generic DMA memory access interface Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 14:01 ` Richard Henderson
2011-06-01 14:01 ` Richard Henderson
2011-06-01 14:29 ` Avi Kivity [this message]
2011-06-01 14:29 ` Avi Kivity
2011-06-01 15:16 ` Richard Henderson
2011-06-01 15:16 ` Richard Henderson
2011-06-02 10:22 ` David Gibson
2011-06-02 10:22 ` David Gibson
2011-06-01 14:52 ` Eduard - Gabriel Munteanu
2011-06-01 14:52 ` Eduard - Gabriel Munteanu
2011-06-01 15:09 ` Richard Henderson
2011-06-01 15:09 ` Richard Henderson
2011-06-01 15:35 ` Eduard - Gabriel Munteanu
2011-06-01 15:35 ` Eduard - Gabriel Munteanu
2011-06-01 15:45 ` Richard Henderson
2011-06-01 15:45 ` Richard Henderson
2011-06-02 9:38 ` David Gibson
2011-06-02 9:38 ` David Gibson
2011-06-01 1:38 ` [RFC PATCH 02/13] pci: add IOMMU support via the generic DMA layer Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 03/13] AMD IOMMU emulation Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 04/13] ide: use the DMA memory access interface for PCI IDE controllers Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 05/13] rtl8139: use the DMA memory access interface Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 06/13] eepro100: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 07/13] ac97: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 08/13] es1370: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 09/13] e1000: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 10/13] lsi53c895a: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 11/13] pcnet: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 12/13] usb-uhci: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 13/13] usb-ohci: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 18:49 ` [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try Richard Henderson
2011-06-01 18:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE64CE4.7030300@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dwg@au1.ibm.com \
--cc=eduard.munteanu@linux360.ro \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.