From: Richard Henderson <rth@twiddle.net>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: mst@redhat.com, aliguori@us.ibm.com, david@gibson.dropbear.id.au,
kvm@vger.kernel.org, aik@ozlabs.ru, joro@8bytes.org,
seabios@seabios.org, qemu-devel@nongnu.org, agraf@suse.de,
blauwirbel@gmail.com, yamahata@valinux.co.jp, kevin@koconnor.net,
avi@redhat.com, dwg@au1.ibm.com, paul@codesourcery.com
Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface
Date: Wed, 01 Jun 2011 08:45:56 -0700 [thread overview]
Message-ID: <4DE65EB4.1070104@twiddle.net> (raw)
In-Reply-To: <20110601153510.GA3339@localhost>
On 06/01/2011 08:35 AM, Eduard - Gabriel Munteanu wrote:
> Maybe it's not nice, but you're missing the fact upcasting gives you
> some type safety. With opaques you have none.
Lol. Do you understand what container_of does?
This is not dynamic_cast<> with RTTI.
You can put any type name in there that you like,
so long as it has a field name to match. The type
of the field you give doesn't even have to match
the type of the pointer that you pass in.
Type safety this is not.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
aik@ozlabs.ru, joro@8bytes.org, seabios@seabios.org,
qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com,
yamahata@valinux.co.jp, paul@codesourcery.com,
kevin@koconnor.net, avi@redhat.com, dwg@au1.ibm.com,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface
Date: Wed, 01 Jun 2011 08:45:56 -0700 [thread overview]
Message-ID: <4DE65EB4.1070104@twiddle.net> (raw)
In-Reply-To: <20110601153510.GA3339@localhost>
On 06/01/2011 08:35 AM, Eduard - Gabriel Munteanu wrote:
> Maybe it's not nice, but you're missing the fact upcasting gives you
> some type safety. With opaques you have none.
Lol. Do you understand what container_of does?
This is not dynamic_cast<> with RTTI.
You can put any type name in there that you like,
so long as it has a field name to match. The type
of the field you give doesn't even have to match
the type of the pointer that you pass in.
Type safety this is not.
r~
next prev parent reply other threads:[~2011-06-01 15:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 1:38 [RFC PATCH 00/13] AMD IOMMU emulation patches, another try Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 01/13] Generic DMA memory access interface Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 14:01 ` Richard Henderson
2011-06-01 14:01 ` Richard Henderson
2011-06-01 14:29 ` Avi Kivity
2011-06-01 14:29 ` Avi Kivity
2011-06-01 15:16 ` Richard Henderson
2011-06-01 15:16 ` Richard Henderson
2011-06-02 10:22 ` David Gibson
2011-06-02 10:22 ` David Gibson
2011-06-01 14:52 ` Eduard - Gabriel Munteanu
2011-06-01 14:52 ` Eduard - Gabriel Munteanu
2011-06-01 15:09 ` Richard Henderson
2011-06-01 15:09 ` Richard Henderson
2011-06-01 15:35 ` Eduard - Gabriel Munteanu
2011-06-01 15:35 ` Eduard - Gabriel Munteanu
2011-06-01 15:45 ` Richard Henderson [this message]
2011-06-01 15:45 ` Richard Henderson
2011-06-02 9:38 ` David Gibson
2011-06-02 9:38 ` David Gibson
2011-06-01 1:38 ` [RFC PATCH 02/13] pci: add IOMMU support via the generic DMA layer Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 03/13] AMD IOMMU emulation Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 04/13] ide: use the DMA memory access interface for PCI IDE controllers Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 05/13] rtl8139: use the DMA memory access interface Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 06/13] eepro100: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 07/13] ac97: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 08/13] es1370: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 09/13] e1000: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 10/13] lsi53c895a: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 11/13] pcnet: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 12/13] usb-uhci: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [RFC PATCH 13/13] usb-ohci: " Eduard - Gabriel Munteanu
2011-06-01 1:38 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2011-06-01 18:49 ` [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try Richard Henderson
2011-06-01 18:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE65EB4.1070104@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dwg@au1.ibm.com \
--cc=eduard.munteanu@linux360.ro \
--cc=joro@8bytes.org \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.