* Re: [PATCH] skip modem port checking when create NDIS gprs context
2011-06-03 9:14 [PATCH] skip modem port checking when create NDIS gprs context Caiwen Zhang
@ 2011-06-02 21:04 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-06-02 21:04 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
Hi Caiwen,
On 06/03/2011 04:14 AM, Caiwen Zhang wrote:
> When create NDIS gprs context, It doesn't depend on modem port,
> don't need to check modem port.
>
> ---
> plugins/huawei.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
Patch has been applied with a slightly modified commit message. Thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] skip modem port checking when create NDIS gprs context
@ 2011-06-03 9:14 Caiwen Zhang
2011-06-02 21:04 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Caiwen Zhang @ 2011-06-03 9:14 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
When create NDIS gprs context, It doesn't depend on modem port,
don't need to check modem port.
---
plugins/huawei.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 639ae0d..6a71305 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -716,16 +716,15 @@ static void huawei_post_online(struct ofono_modem *modem)
ofono_ussd_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
"atmodem", data->pcui);
- if ((data->sim_state == HUAWEI_SIM_STATE_VALID ||
- data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) &&
- data->modem != NULL) {
+ if (data->sim_state == HUAWEI_SIM_STATE_VALID ||
+ data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) {
data->gprs = ofono_gprs_create(modem, OFONO_VENDOR_HUAWEI,
"atmodem", data->pcui);
if (data->ndis == TRUE)
data->gc = ofono_gprs_context_create(modem, 0,
"huaweimodem", data->pcui);
- else
+ else if (data->modem != NULL)
data->gc = ofono_gprs_context_create(modem, 0,
"atmodem", data->modem);
--
1.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-03 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-03 9:14 [PATCH] skip modem port checking when create NDIS gprs context Caiwen Zhang
2011-06-02 21:04 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.