[PATCH] skip modem port checking when create NDIS gprs context

[PATCH] skip modem port checking when create NDIS gprs context

[Caiwen Zhang]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

When create NDIS gprs context, It doesn't depend on modem port,
don't need to check modem port.

---
 plugins/huawei.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/plugins/huawei.c b/plugins/huawei.c
index 639ae0d..6a71305 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -716,16 +716,15 @@ static void huawei_post_online(struct ofono_modem *modem)
 	ofono_ussd_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
 						"atmodem", data->pcui);
 
-	if ((data->sim_state == HUAWEI_SIM_STATE_VALID ||
-			data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) &&
-			data->modem != NULL) {
+	if (data->sim_state == HUAWEI_SIM_STATE_VALID ||
+			data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) {
 		data->gprs = ofono_gprs_create(modem, OFONO_VENDOR_HUAWEI,
 						"atmodem", data->pcui);
 
 		if (data->ndis == TRUE)
 			data->gc = ofono_gprs_context_create(modem, 0,
 						"huaweimodem", data->pcui);
-		else
+		else if (data->modem != NULL)
 			data->gc = ofono_gprs_context_create(modem, 0,
 						"atmodem", data->modem);
 
-- 
1.7.5

Re: [PATCH] skip modem port checking when create NDIS gprs context

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi Caiwen,

On 06/03/2011 04:14 AM, Caiwen Zhang wrote:
> When create NDIS gprs context, It doesn't depend on modem port,
> don't need to check modem port.
> 
> ---
>  plugins/huawei.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 

Patch has been applied with a slightly modified commit message.  Thanks.

Regards,
-Denis