From: Andy Lutomirski <luto@MIT.EDU>
To: "wanlong.gao" <wanlong.gao@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Maarten Lankhorst <m.b.lankhorst@gmail.com>,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
Date: Mon, 13 Jun 2011 02:55:37 +0000 [thread overview]
Message-ID: <4DF57C29.4070601@mit.edu> (raw)
In-Reply-To: <1307875953.1859.6.camel@Tux>
On 06/12/2011 06:52 AM, wanlong.gao wrote:
> <snip>
>
> Hi Maarten:
> It registered efifb_device but try to unregistered efifb_driver,
> so I think you should fix it like this?
>
> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
> ---
> drivers/video/efifb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
> */
> ret = platform_driver_probe(&efifb_driver, efifb_probe);
> if (ret) {
> - platform_device_unregister(&efifb_driver);
> + platform_device_unregister(&efifb_device);
> return ret;
> }
>
Acked-by: Andy Lutomirski <luto@mit.edu>
That's my bug. Sorry. I'm not sure why it compiled, though.
--Andy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@MIT.EDU>
To: "wanlong.gao" <wanlong.gao@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Maarten Lankhorst <m.b.lankhorst@gmail.com>,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
Date: Sun, 12 Jun 2011 22:55:37 -0400 [thread overview]
Message-ID: <4DF57C29.4070601@mit.edu> (raw)
In-Reply-To: <1307875953.1859.6.camel@Tux>
On 06/12/2011 06:52 AM, wanlong.gao wrote:
> <snip>
>
> Hi Maarten:
> It registered efifb_device but try to unregistered efifb_driver,
> so I think you should fix it like this?
>
> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
> ---
> drivers/video/efifb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
> */
> ret = platform_driver_probe(&efifb_driver, efifb_probe);
> if (ret) {
> - platform_device_unregister(&efifb_driver);
> + platform_device_unregister(&efifb_device);
> return ret;
> }
>
Acked-by: Andy Lutomirski <luto@mit.edu>
That's my bug. Sorry. I'm not sure why it compiled, though.
--Andy
next prev parent reply other threads:[~2011-06-13 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 8:45 [PATCH] efifb: Fix call to wrong unregister function Maarten Lankhorst
2011-06-12 8:45 ` Maarten Lankhorst
2011-06-12 10:52 ` wanlong.gao
2011-06-12 10:52 ` wanlong.gao
2011-06-12 17:48 ` [PATCH] " Maarten Lankhorst
2011-06-12 17:48 ` Maarten Lankhorst
2011-06-12 23:36 ` Wanlong Gao
2011-06-12 23:36 ` Wanlong Gao
2011-06-13 2:55 ` Andy Lutomirski [this message]
2011-06-13 2:55 ` Andy Lutomirski
2011-06-13 7:51 ` Maarten Lankhorst
2011-06-13 7:51 ` Maarten Lankhorst
2011-06-14 7:33 ` Paul Mundt
2011-06-14 7:33 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF57C29.4070601@mit.edu \
--to=luto@mit.edu \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=pjones@redhat.com \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.