From: Kevin Wolf <kwolf@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Riku Voipio <riku.voipio@iki.fi>,
Richard Henderson <rth@twiddle.net>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Stefan Weil <weil@mail.berlios.de>,
Jan Kiszka <jan.kiszka@siemens.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Aurelien Jarno <aurelien@aurel32.net>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
Isaku Yamahata <yamahata@valinux.co.jp>,
kvm@vger.kernel.org
Subject: Re: [PATCH 06/10] kvm: remove unused variables
Date: Wed, 15 Jun 2011 09:38:39 +0200 [thread overview]
Message-ID: <4DF8617F.20700@redhat.com> (raw)
In-Reply-To: <b8c61957187f86291291abfaed88f44ac8d41b95.1308072799.git.mst@redhat.com>
Am 14.06.2011 19:36, schrieb Michael S. Tsirkin:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio-pci.h | 8 +++++---
> target-i386/kvm.c | 3 +--
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h
> index a4b5fd3..b518917 100644
> --- a/hw/virtio-pci.h
> +++ b/hw/virtio-pci.h
> @@ -37,7 +37,9 @@ typedef struct {
> bool ioeventfd_started;
> } VirtIOPCIProxy;
>
> -extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev,
> - uint16_t vendor, uint16_t device,
> - uint16_t class_code, uint8_t pif);
> +void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev);
> +
> +/* Virtio ABI version, if we increment this, we break the guest driver. */
> +#define VIRTIO_PCI_ABI_VERSION 0
> +
> #endif
Is this hunk there intentionally?
Kevin
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index faedc6c..58a70bc 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -970,7 +970,7 @@ static int kvm_get_xsave(CPUState *env)
> #ifdef KVM_CAP_XSAVE
> struct kvm_xsave* xsave;
> int ret, i;
> - uint16_t cwd, swd, twd, fop;
> + uint16_t cwd, swd, twd;
>
> if (!kvm_has_xsave()) {
> return kvm_get_fpu(env);
> @@ -986,7 +986,6 @@ static int kvm_get_xsave(CPUState *env)
> cwd = (uint16_t)xsave->region[0];
> swd = (uint16_t)(xsave->region[0] >> 16);
> twd = (uint16_t)xsave->region[1];
> - fop = (uint16_t)(xsave->region[1] >> 16);
> env->fpstt = (swd >> 11) & 7;
> env->fpus = swd;
> env->fpuc = cwd;
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Isaku Yamahata <yamahata@valinux.co.jp>,
Jan Kiszka <jan.kiszka@siemens.com>,
Paul Brook <paul@codesourcery.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>,
Blue Swirl <blauwirbel@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables
Date: Wed, 15 Jun 2011 09:38:39 +0200 [thread overview]
Message-ID: <4DF8617F.20700@redhat.com> (raw)
In-Reply-To: <b8c61957187f86291291abfaed88f44ac8d41b95.1308072799.git.mst@redhat.com>
Am 14.06.2011 19:36, schrieb Michael S. Tsirkin:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio-pci.h | 8 +++++---
> target-i386/kvm.c | 3 +--
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h
> index a4b5fd3..b518917 100644
> --- a/hw/virtio-pci.h
> +++ b/hw/virtio-pci.h
> @@ -37,7 +37,9 @@ typedef struct {
> bool ioeventfd_started;
> } VirtIOPCIProxy;
>
> -extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev,
> - uint16_t vendor, uint16_t device,
> - uint16_t class_code, uint8_t pif);
> +void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev);
> +
> +/* Virtio ABI version, if we increment this, we break the guest driver. */
> +#define VIRTIO_PCI_ABI_VERSION 0
> +
> #endif
Is this hunk there intentionally?
Kevin
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index faedc6c..58a70bc 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -970,7 +970,7 @@ static int kvm_get_xsave(CPUState *env)
> #ifdef KVM_CAP_XSAVE
> struct kvm_xsave* xsave;
> int ret, i;
> - uint16_t cwd, swd, twd, fop;
> + uint16_t cwd, swd, twd;
>
> if (!kvm_has_xsave()) {
> return kvm_get_fpu(env);
> @@ -986,7 +986,6 @@ static int kvm_get_xsave(CPUState *env)
> cwd = (uint16_t)xsave->region[0];
> swd = (uint16_t)(xsave->region[0] >> 16);
> twd = (uint16_t)xsave->region[1];
> - fop = (uint16_t)(xsave->region[1] >> 16);
> env->fpstt = (swd >> 11) & 7;
> env->fpus = swd;
> env->fpuc = cwd;
next prev parent reply other threads:[~2011-06-15 7:36 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 17:35 [PATCH 00/10] qemu: remove set but unused variables Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 01/10] ppce500: move device/vendor/class id to qdev Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 22:42 ` Isaku Yamahata
2011-06-14 22:42 ` [Qemu-devel] " Isaku Yamahata
2011-06-14 17:35 ` [PATCH 02/10] usb-ehci: " Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 03/10] usb-ehci: remove unused variables Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 6:45 ` Gerd Hoffmann
2011-06-15 6:45 ` [Qemu-devel] " Gerd Hoffmann
2011-06-14 17:35 ` [PATCH 04/10] lsi53c895a: " Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 9:23 ` Stefan Hajnoczi
2011-06-15 9:23 ` [Qemu-devel] " Stefan Hajnoczi
2011-06-14 17:35 ` [PATCH 05/10] wdt: " Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 22:47 ` Isaku Yamahata
2011-06-14 22:47 ` [Qemu-devel] " Isaku Yamahata
2011-06-14 17:36 ` [PATCH 06/10] kvm: " Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 7:38 ` Kevin Wolf [this message]
2011-06-15 7:38 ` Kevin Wolf
2011-06-15 8:25 ` Michael S. Tsirkin
2011-06-15 8:25 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 8:42 ` Jan Kiszka
2011-06-15 8:42 ` [Qemu-devel] " Jan Kiszka
2011-06-15 12:44 ` Chris Krumme
2011-06-15 12:44 ` Chris Krumme
2011-06-15 18:29 ` Michael S. Tsirkin
2011-06-15 18:29 ` Michael S. Tsirkin
2011-06-14 17:36 ` [PATCH 07/10] alpha/translate: remve " Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-14 17:47 ` [Qemu-devel] " Richard Henderson
2011-06-14 17:36 ` [PATCH 08/10] alpha: remove unused variable Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-14 17:47 ` [Qemu-devel] " Richard Henderson
2011-06-23 11:47 ` Peter Maydell
2011-06-23 15:25 ` Richard Henderson
2011-06-14 17:36 ` [PATCH 09/10] exec: " Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-26 11:08 ` Michael S. Tsirkin
2011-06-26 11:08 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-26 14:32 ` Stefan Hajnoczi
2011-06-26 14:32 ` [Qemu-devel] " Stefan Hajnoczi
2011-06-14 17:36 ` [PATCH 10/10] linux-user: remove unused variables Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 8:35 ` Alexander Graf
2011-06-15 8:35 ` [Qemu-devel] " Alexander Graf
2011-06-15 8:55 ` Michael S. Tsirkin
2011-06-15 8:55 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 14:32 ` Richard Henderson
2011-06-15 14:32 ` [Qemu-devel] " Richard Henderson
2011-06-15 18:40 ` Michael S. Tsirkin
2011-06-15 18:40 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 23:42 ` Peter Maydell
2011-06-15 16:51 ` Peter Maydell
2011-06-15 16:51 ` Peter Maydell
2011-06-26 11:11 ` Michael S. Tsirkin
2011-06-26 11:11 ` [Qemu-devel] " Michael S. Tsirkin
2011-06-27 9:06 ` Peter Maydell
2011-06-27 9:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8617F.20700@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=weil@mail.berlios.de \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.