All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>, Kevin Wolf <kwolf@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	Richard Henderson <rth@twiddle.net>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org,
	Alex Williamson <alex.williamson@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Stefan Weil <weil@mail.berlios.de>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Isaku Yamahata <yamahata@valinux.co.jp>,
	kvm@vger.kernel.org
Subject: [PATCH 00/10] qemu: remove set but unused variables
Date: Tue, 14 Jun 2011 20:35:09 +0300	[thread overview]
Message-ID: <cover.1308072799.git.mst@redhat.com> (raw)

Switched to FC15 and qemu build with -Werror fails. The reason
is that with gcc 4.6.0, -Werror makes the build fail on
variables that are set but never used.
XXX: In function ‘xxx’:
XXX:XXX:XX: error: variable ‘xx’ set but not used
[-Werror=unused-but-set-variable]

The following patchset removes such variables
from the codebase.

Note: the warning could actually point to a
bug in code. Pls review carefully.

Build tested only.

-- 
MST


Michael S. Tsirkin (10):
  ppce500: move device/vendor/class id to qdev
  usb-ehci: move device/vendor/class id to qdev
  usb-ehci: remove unused variables
  lsi53c895a: remove unused variables
  wdt: remove unused variables
  kvm: remove unused variables
  alpha/translate: remve unused variables
  alpha: remove unused variable
  exec: remove unused variable
  linux-user: remove unused variables

 exec.c                   |    4 ++++
 hw/lsi53c895a.c          |    2 --
 hw/ppce500_pci.c         |   13 +++----------
 hw/usb-ehci.c            |   19 +++++--------------
 hw/virtio-pci.h          |    8 +++++---
 hw/wdt_i6300esb.c        |    3 ---
 linux-user/flatload.c    |   10 ++++++----
 linux-user/linuxload.c   |   25 +------------------------
 linux-user/main.c        |    6 +++---
 linux-user/signal.c      |    5 -----
 linux-user/syscall.c     |    6 ------
 target-alpha/translate.c |   10 +++++++---
 target-i386/kvm.c        |    3 +--
 13 files changed, 35 insertions(+), 79 deletions(-)

-- 
1.7.5.53.gc233e

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Riku Voipio <riku.voipio@iki.fi>, Christoph Hellwig <hch@lst.de>,
	Blue Swirl <blauwirbel@gmail.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Isaku Yamahata <yamahata@valinux.co.jp>,
	Paul Brook <paul@codesourcery.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 00/10] qemu: remove set but unused variables
Date: Tue, 14 Jun 2011 20:35:09 +0300	[thread overview]
Message-ID: <cover.1308072799.git.mst@redhat.com> (raw)

Switched to FC15 and qemu build with -Werror fails. The reason
is that with gcc 4.6.0, -Werror makes the build fail on
variables that are set but never used.
XXX: In function ‘xxx’:
XXX:XXX:XX: error: variable ‘xx’ set but not used
[-Werror=unused-but-set-variable]

The following patchset removes such variables
from the codebase.

Note: the warning could actually point to a
bug in code. Pls review carefully.

Build tested only.

-- 
MST


Michael S. Tsirkin (10):
  ppce500: move device/vendor/class id to qdev
  usb-ehci: move device/vendor/class id to qdev
  usb-ehci: remove unused variables
  lsi53c895a: remove unused variables
  wdt: remove unused variables
  kvm: remove unused variables
  alpha/translate: remve unused variables
  alpha: remove unused variable
  exec: remove unused variable
  linux-user: remove unused variables

 exec.c                   |    4 ++++
 hw/lsi53c895a.c          |    2 --
 hw/ppce500_pci.c         |   13 +++----------
 hw/usb-ehci.c            |   19 +++++--------------
 hw/virtio-pci.h          |    8 +++++---
 hw/wdt_i6300esb.c        |    3 ---
 linux-user/flatload.c    |   10 ++++++----
 linux-user/linuxload.c   |   25 +------------------------
 linux-user/main.c        |    6 +++---
 linux-user/signal.c      |    5 -----
 linux-user/syscall.c     |    6 ------
 target-alpha/translate.c |   10 +++++++---
 target-i386/kvm.c        |    3 +--
 13 files changed, 35 insertions(+), 79 deletions(-)

-- 
1.7.5.53.gc233e

             reply	other threads:[~2011-06-14 17:35 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 17:35 Michael S. Tsirkin [this message]
2011-06-14 17:35 ` [Qemu-devel] [PATCH 00/10] qemu: remove set but unused variables Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 01/10] ppce500: move device/vendor/class id to qdev Michael S. Tsirkin
2011-06-14 17:35   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 22:42   ` Isaku Yamahata
2011-06-14 22:42     ` [Qemu-devel] " Isaku Yamahata
2011-06-14 17:35 ` [PATCH 02/10] usb-ehci: " Michael S. Tsirkin
2011-06-14 17:35   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 03/10] usb-ehci: remove unused variables Michael S. Tsirkin
2011-06-14 17:35   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15  6:45   ` Gerd Hoffmann
2011-06-15  6:45     ` [Qemu-devel] " Gerd Hoffmann
2011-06-14 17:35 ` [PATCH 04/10] lsi53c895a: " Michael S. Tsirkin
2011-06-14 17:35   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15  9:23   ` Stefan Hajnoczi
2011-06-15  9:23     ` [Qemu-devel] " Stefan Hajnoczi
2011-06-14 17:35 ` [PATCH 05/10] wdt: " Michael S. Tsirkin
2011-06-14 17:35   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 22:47   ` Isaku Yamahata
2011-06-14 22:47     ` [Qemu-devel] " Isaku Yamahata
2011-06-14 17:36 ` [PATCH 06/10] kvm: " Michael S. Tsirkin
2011-06-14 17:36   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15  7:38   ` Kevin Wolf
2011-06-15  7:38     ` [Qemu-devel] " Kevin Wolf
2011-06-15  8:25     ` Michael S. Tsirkin
2011-06-15  8:25       ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15  8:42       ` Jan Kiszka
2011-06-15  8:42         ` [Qemu-devel] " Jan Kiszka
2011-06-15 12:44   ` Chris Krumme
2011-06-15 12:44     ` Chris Krumme
2011-06-15 18:29     ` Michael S. Tsirkin
2011-06-15 18:29       ` Michael S. Tsirkin
2011-06-14 17:36 ` [PATCH 07/10] alpha/translate: remve " Michael S. Tsirkin
2011-06-14 17:36   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:47   ` Richard Henderson
2011-06-14 17:47     ` [Qemu-devel] " Richard Henderson
2011-06-14 17:36 ` [PATCH 08/10] alpha: remove unused variable Michael S. Tsirkin
2011-06-14 17:36   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-14 17:47   ` Richard Henderson
2011-06-14 17:47     ` [Qemu-devel] " Richard Henderson
2011-06-23 11:47     ` Peter Maydell
2011-06-23 15:25       ` Richard Henderson
2011-06-14 17:36 ` [PATCH 09/10] exec: " Michael S. Tsirkin
2011-06-14 17:36   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-26 11:08   ` Michael S. Tsirkin
2011-06-26 11:08     ` [Qemu-devel] " Michael S. Tsirkin
2011-06-26 14:32     ` Stefan Hajnoczi
2011-06-26 14:32       ` [Qemu-devel] " Stefan Hajnoczi
2011-06-14 17:36 ` [PATCH 10/10] linux-user: remove unused variables Michael S. Tsirkin
2011-06-14 17:36   ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15  8:35   ` Alexander Graf
2011-06-15  8:35     ` [Qemu-devel] " Alexander Graf
2011-06-15  8:55     ` Michael S. Tsirkin
2011-06-15  8:55       ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 14:32     ` Richard Henderson
2011-06-15 14:32       ` [Qemu-devel] " Richard Henderson
2011-06-15 18:40       ` Michael S. Tsirkin
2011-06-15 18:40         ` [Qemu-devel] " Michael S. Tsirkin
2011-06-15 23:42       ` Peter Maydell
2011-06-15 16:51     ` Peter Maydell
2011-06-15 16:51       ` Peter Maydell
2011-06-26 11:11   ` Michael S. Tsirkin
2011-06-26 11:11     ` [Qemu-devel] " Michael S. Tsirkin
2011-06-27  9:06     ` Peter Maydell
2011-06-27  9:13       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1308072799.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=aurelien@aurel32.net \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=hch@lst.de \
    --cc=jan.kiszka@siemens.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=weil@mail.berlios.de \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.