From: Wayne Boyer <wayneb@linux.vnet.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: Brian King <brking@linux.vnet.ibm.com>,
kernel-janitors@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/ipr.c: reorder error handling code to include
Date: Mon, 20 Jun 2011 16:47:24 +0000 [thread overview]
Message-ID: <4DFF799C.9000102@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1106151050430.10106@ask.diku.dk>
On 06/15/2011 01:50 AM, Julia Lawall wrote:
> On Tue, 14 Jun 2011, Brian King wrote:
>
>> On 06/09/2011 10:51 AM, Wayne Boyer wrote:
>>> On 05/31/2011 07:16 AM, Julia Lawall wrote:
>>>> From: Julia Lawall <julia@diku.dk>
>>>>
>>>> The out_msi_disable label should be before cleanup_nomem to additionally
>>>> benefit from the call to iounmap.
>>>
>>> Yes, this is a problem. I propose the following patch instead.
>>
>> By removing the out_msi_disable label, if you fail initialization later
>> on and goto cleanup_nomem, you will end up leaving MSI enabled when you exit
>> with this patch.
>
> I agree.
>
> julia
>
I also agree. Please disregard my patch.
--
Wayne Boyer
IBM - Beaverton, Oregon
LTC S/W Development
(503) 578-5236, T/L 775-5236
WARNING: multiple messages have this Message-ID (diff)
From: Wayne Boyer <wayneb@linux.vnet.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: Brian King <brking@linux.vnet.ibm.com>,
kernel-janitors@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap
Date: Mon, 20 Jun 2011 09:47:24 -0700 [thread overview]
Message-ID: <4DFF799C.9000102@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1106151050430.10106@ask.diku.dk>
On 06/15/2011 01:50 AM, Julia Lawall wrote:
> On Tue, 14 Jun 2011, Brian King wrote:
>
>> On 06/09/2011 10:51 AM, Wayne Boyer wrote:
>>> On 05/31/2011 07:16 AM, Julia Lawall wrote:
>>>> From: Julia Lawall <julia@diku.dk>
>>>>
>>>> The out_msi_disable label should be before cleanup_nomem to additionally
>>>> benefit from the call to iounmap.
>>>
>>> Yes, this is a problem. I propose the following patch instead.
>>
>> By removing the out_msi_disable label, if you fail initialization later
>> on and goto cleanup_nomem, you will end up leaving MSI enabled when you exit
>> with this patch.
>
> I agree.
>
> julia
>
I also agree. Please disregard my patch.
--
Wayne Boyer
IBM - Beaverton, Oregon
LTC S/W Development
(503) 578-5236, T/L 775-5236
next prev parent reply other threads:[~2011-06-20 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 14:16 [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Julia Lawall
2011-05-31 14:16 ` Julia Lawall
2011-06-01 15:02 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include Brian King
2011-06-01 15:02 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Brian King
2011-06-09 15:51 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include Wayne Boyer
2011-06-09 15:51 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Wayne Boyer
2011-06-14 16:09 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include Brian King
2011-06-14 16:09 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Brian King
2011-06-15 8:50 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to Julia Lawall
2011-06-15 8:50 ` [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Julia Lawall
2011-06-20 16:47 ` Wayne Boyer [this message]
2011-06-20 16:47 ` Wayne Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF799C.9000102@linux.vnet.ibm.com \
--to=wayneb@linux.vnet.ibm.com \
--cc=JBottomley@parallels.com \
--cc=brking@linux.vnet.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.