All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Cong Wang <amwang@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	Johannes Weiner <jweiner@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never
Date: Mon, 20 Jun 2011 13:50:00 -0400	[thread overview]
Message-ID: <4DFF8848.2060802@redhat.com> (raw)
In-Reply-To: <4DFF84BB.3050209@redhat.com>

On 06/20/2011 01:34 PM, Cong Wang wrote:

> Even if it is really 10K, why not save it since it doesn't
> much effort to make this. ;) Not only memory, but also time,
> this could also save a little time to initialize the kernel.
>
> For me, the more serious thing is the logic, there is
> no way to totally disable it as long as I have THP in .config
> currently. This is why I said the design is broken.

There are many things you cannot totally disable as long
as they are enabled in the .config.  Think about things
like swap, or tmpfs - neither of which you are going to
use in the crashdump kernel.

I believe we need to keep the kernel optimized for common
use and convenience.

Crashdump is very much a corner case.  Yes, using less
memory in crashdump is worthwhile, but lets face it -
the big memory user there is likely to be the struct page
array, with everything else down in the noise...

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Cong Wang <amwang@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	Johannes Weiner <jweiner@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never
Date: Mon, 20 Jun 2011 13:50:00 -0400	[thread overview]
Message-ID: <4DFF8848.2060802@redhat.com> (raw)
In-Reply-To: <4DFF84BB.3050209@redhat.com>

On 06/20/2011 01:34 PM, Cong Wang wrote:

> Even if it is really 10K, why not save it since it doesn't
> much effort to make this. ;) Not only memory, but also time,
> this could also save a little time to initialize the kernel.
>
> For me, the more serious thing is the logic, there is
> no way to totally disable it as long as I have THP in .config
> currently. This is why I said the design is broken.

There are many things you cannot totally disable as long
as they are enabled in the .config.  Think about things
like swap, or tmpfs - neither of which you are going to
use in the crashdump kernel.

I believe we need to keep the kernel optimized for common
use and convenience.

Crashdump is very much a corner case.  Yes, using less
memory in crashdump is worthwhile, but lets face it -
the big memory user there is likely to be the struct page
array, with everything else down in the noise...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-20 17:50 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 16:34 [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never Amerigo Wang
2011-06-20 16:34 ` Amerigo Wang
2011-06-20 16:34 ` [PATCH 2/3] mm: make the threshold of enabling THP configurable Amerigo Wang
2011-06-20 16:34   ` Amerigo Wang
2011-06-20 16:59   ` Dave Hansen
2011-06-20 16:59     ` Dave Hansen
2011-06-20 17:23     ` Cong Wang
2011-06-20 17:23       ` Cong Wang
2011-06-20 16:59   ` Mel Gorman
2011-06-20 16:59     ` Mel Gorman
2011-06-20 17:16     ` Cong Wang
2011-06-20 17:16       ` Cong Wang
2011-06-21  9:36       ` Mel Gorman
2011-06-21  9:36         ` Mel Gorman
2011-06-22  2:41         ` Cong Wang
2011-06-22  2:41           ` Cong Wang
2011-06-22  9:16           ` Mel Gorman
2011-06-22  9:16             ` Mel Gorman
2011-06-22 10:46             ` Cong Wang
2011-06-22 10:46               ` Cong Wang
2011-06-22 11:15               ` Mel Gorman
2011-06-22 11:15                 ` Mel Gorman
2011-06-22 12:34                 ` Cong Wang
2011-06-22 12:34                   ` Cong Wang
2011-06-20 16:34 ` [PATCH 3/3] mm: print information when THP is disabled automatically Amerigo Wang
2011-06-20 16:34   ` Amerigo Wang
2011-06-20 16:54   ` Andrea Arcangeli
2011-06-20 16:54     ` Andrea Arcangeli
2011-06-20 17:25     ` Cong Wang
2011-06-20 17:25       ` Cong Wang
2011-06-20 17:01   ` Mel Gorman
2011-06-20 17:01     ` Mel Gorman
2011-06-20 17:26     ` Cong Wang
2011-06-20 17:26       ` Cong Wang
2011-06-20 19:37       ` Andrea Arcangeli
2011-06-20 19:37         ` Andrea Arcangeli
2011-06-21  9:40       ` Mel Gorman
2011-06-21  9:40         ` Mel Gorman
2011-06-20 16:50 ` [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never Andrea Arcangeli
2011-06-20 16:50   ` Andrea Arcangeli
2011-06-20 16:55   ` Rik van Riel
2011-06-20 16:55     ` Rik van Riel
2011-06-20 17:01   ` Cong Wang
2011-06-20 17:01     ` Cong Wang
2011-06-20 19:43     ` Andrea Arcangeli
2011-06-20 19:43       ` Andrea Arcangeli
2011-06-21  3:15       ` Cong Wang
2011-06-21  3:15         ` Cong Wang
2011-06-20 16:58 ` Mel Gorman
2011-06-20 16:58   ` Mel Gorman
2011-06-20 17:07   ` Cong Wang
2011-06-20 17:07     ` Cong Wang
2011-06-20 17:10     ` Rik van Riel
2011-06-20 17:10       ` Rik van Riel
2011-06-20 17:19       ` Cong Wang
2011-06-20 17:19         ` Cong Wang
2011-06-20 17:28         ` Rik van Riel
2011-06-20 17:28           ` Rik van Riel
2011-06-20 17:34           ` Cong Wang
2011-06-20 17:34             ` Cong Wang
2011-06-20 17:50             ` Rik van Riel [this message]
2011-06-20 17:50               ` Rik van Riel
2011-06-20 18:25               ` Vivek Goyal
2011-06-20 18:25                 ` Vivek Goyal
2011-06-20 19:21                 ` Andrea Arcangeli
2011-06-20 19:21                   ` Andrea Arcangeli
2011-06-21  4:08                   ` Cong Wang
2011-06-21  4:08                     ` Cong Wang
2011-06-21 14:43                     ` Andrea Arcangeli
2011-06-21 14:43                       ` Andrea Arcangeli
2011-06-22  2:56                       ` Cong Wang
2011-06-22  2:56                         ` Cong Wang
2011-06-22 14:22                         ` Andrea Arcangeli
2011-06-22 14:22                           ` Andrea Arcangeli
2011-06-21 20:01                     ` Rik van Riel
2011-06-21 20:01                       ` Rik van Riel
2011-06-21  3:28               ` Cong Wang
2011-06-21  3:28                 ` Cong Wang
2011-06-20 17:58             ` Eric B Munson
2011-06-21  3:36               ` Cong Wang
2011-06-21  3:36                 ` Cong Wang
2011-06-20 17:59           ` Vivek Goyal
2011-06-20 17:59             ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFF8848.2060802@redhat.com \
    --to=riel@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=jweiner@redhat.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.