All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Jean-François Moine" <moinejf@free.fr>,
	"open list:MEDIA INPUT INFRA..." <linux-media@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] pwc: precedence bug in pwc_init_controls()
Date: Sun, 24 Jul 2011 15:22:39 +0000	[thread overview]
Message-ID: <4E2C38BF.80901@redhat.com> (raw)
In-Reply-To: <20110723185303.GA3711@shale.localdomain>

Hi,

Thanks I've added your patch to my gspca/pwc tree and
send an updated pull request to Mauro including your patch.

Regards,

Hans


On 07/23/2011 08:53 PM, Dan Carpenter wrote:
> '!' has higher precedence than'&' so we need parenthesis here.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
> index e9a0e94..8c70e64 100644
> --- a/drivers/media/video/pwc/pwc-v4l.c
> +++ b/drivers/media/video/pwc/pwc-v4l.c
> @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
>   	if (pdev->restore_factory)
>   		pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
>
> -	if (!pdev->features&  FEATURE_MOTOR_PANTILT)
> +	if (!(pdev->features&  FEATURE_MOTOR_PANTILT))
>   		return hdl->error;
>
>   	/* Motor pan / tilt / reset */

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Jean-François Moine" <moinejf@free.fr>,
	"open list:MEDIA INPUT INFRA..." <linux-media@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] pwc: precedence bug in pwc_init_controls()
Date: Sun, 24 Jul 2011 17:22:39 +0200	[thread overview]
Message-ID: <4E2C38BF.80901@redhat.com> (raw)
In-Reply-To: <20110723185303.GA3711@shale.localdomain>

Hi,

Thanks I've added your patch to my gspca/pwc tree and
send an updated pull request to Mauro including your patch.

Regards,

Hans


On 07/23/2011 08:53 PM, Dan Carpenter wrote:
> '!' has higher precedence than'&' so we need parenthesis here.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
> index e9a0e94..8c70e64 100644
> --- a/drivers/media/video/pwc/pwc-v4l.c
> +++ b/drivers/media/video/pwc/pwc-v4l.c
> @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
>   	if (pdev->restore_factory)
>   		pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
>
> -	if (!pdev->features&  FEATURE_MOTOR_PANTILT)
> +	if (!(pdev->features&  FEATURE_MOTOR_PANTILT))
>   		return hdl->error;
>
>   	/* Motor pan / tilt / reset */

  reply	other threads:[~2011-07-24 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23 18:53 [patch] [media] pwc: precedence bug in pwc_init_controls() Dan Carpenter
2011-07-23 18:53 ` Dan Carpenter
2011-07-24 15:22 ` Hans de Goede [this message]
2011-07-24 15:22   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2C38BF.80901@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=error27@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=moinejf@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.