* [patch] [media] pwc: precedence bug in pwc_init_controls()
@ 2011-07-23 18:53 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-07-23 18:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans de Goede, Hans Verkuil, Jean-François Moine,
open list:MEDIA INPUT INFRA..., kernel-janitors
'!' has higher precedence than '&' so we need parenthesis here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
index e9a0e94..8c70e64 100644
--- a/drivers/media/video/pwc/pwc-v4l.c
+++ b/drivers/media/video/pwc/pwc-v4l.c
@@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
if (pdev->restore_factory)
pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
- if (!pdev->features & FEATURE_MOTOR_PANTILT)
+ if (!(pdev->features & FEATURE_MOTOR_PANTILT))
return hdl->error;
/* Motor pan / tilt / reset */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] [media] pwc: precedence bug in pwc_init_controls()
@ 2011-07-23 18:53 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-07-23 18:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans de Goede, Hans Verkuil, Jean-François Moine,
open list:MEDIA INPUT INFRA..., kernel-janitors
'!' has higher precedence than '&' so we need parenthesis here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
index e9a0e94..8c70e64 100644
--- a/drivers/media/video/pwc/pwc-v4l.c
+++ b/drivers/media/video/pwc/pwc-v4l.c
@@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
if (pdev->restore_factory)
pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
- if (!pdev->features & FEATURE_MOTOR_PANTILT)
+ if (!(pdev->features & FEATURE_MOTOR_PANTILT))
return hdl->error;
/* Motor pan / tilt / reset */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] [media] pwc: precedence bug in pwc_init_controls()
2011-07-23 18:53 ` Dan Carpenter
@ 2011-07-24 15:22 ` Hans de Goede
-1 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2011-07-24 15:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Hans Verkuil, Jean-François Moine,
open list:MEDIA INPUT INFRA..., kernel-janitors
Hi,
Thanks I've added your patch to my gspca/pwc tree and
send an updated pull request to Mauro including your patch.
Regards,
Hans
On 07/23/2011 08:53 PM, Dan Carpenter wrote:
> '!' has higher precedence than'&' so we need parenthesis here.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
> index e9a0e94..8c70e64 100644
> --- a/drivers/media/video/pwc/pwc-v4l.c
> +++ b/drivers/media/video/pwc/pwc-v4l.c
> @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
> if (pdev->restore_factory)
> pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
>
> - if (!pdev->features& FEATURE_MOTOR_PANTILT)
> + if (!(pdev->features& FEATURE_MOTOR_PANTILT))
> return hdl->error;
>
> /* Motor pan / tilt / reset */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] [media] pwc: precedence bug in pwc_init_controls()
@ 2011-07-24 15:22 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2011-07-24 15:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Hans Verkuil, Jean-François Moine,
open list:MEDIA INPUT INFRA..., kernel-janitors
Hi,
Thanks I've added your patch to my gspca/pwc tree and
send an updated pull request to Mauro including your patch.
Regards,
Hans
On 07/23/2011 08:53 PM, Dan Carpenter wrote:
> '!' has higher precedence than'&' so we need parenthesis here.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c
> index e9a0e94..8c70e64 100644
> --- a/drivers/media/video/pwc/pwc-v4l.c
> +++ b/drivers/media/video/pwc/pwc-v4l.c
> @@ -338,7 +338,7 @@ int pwc_init_controls(struct pwc_device *pdev)
> if (pdev->restore_factory)
> pdev->restore_factory->flags = V4L2_CTRL_FLAG_UPDATE;
>
> - if (!pdev->features& FEATURE_MOTOR_PANTILT)
> + if (!(pdev->features& FEATURE_MOTOR_PANTILT))
> return hdl->error;
>
> /* Motor pan / tilt / reset */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-24 15:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-23 18:53 [patch] [media] pwc: precedence bug in pwc_init_controls() Dan Carpenter
2011-07-23 18:53 ` Dan Carpenter
2011-07-24 15:22 ` Hans de Goede
2011-07-24 15:22 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.