All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vasiliy Kulikov <segoon@openwall.com>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Richard Weinberger <richard@nod.at>, Ingo Molnar <mingo@elte.hu>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	"Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: [kernel-hardening] Re: [PATCH] shm: fix a race between shm_exit() and shm_init()
Date: Thu, 04 Aug 2011 09:26:34 +0100	[thread overview]
Message-ID: <4E3A57BA.2040907@arm.com> (raw)
In-Reply-To: <CA+55aFzw-K6XvDzTwHRyqQWdkDO8Zqz8Ak1qgNTzf6a3L9=80A@mail.gmail.com>

On 04/08/11 01:35, Linus Torvalds wrote:
> On Wed, Aug 3, 2011 at 12:30 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>
>> driver_init() is called from do_basic_setup(), before any initcall...
> 
> Ok, thanks everybody. I think the proper fix is the attached patch.
> It's crazy to have usermode helpers enabled early during boot when
> init etc haven't even been set up.
> 
> So does this finally fix the problem (I realize that there are other
> patches floating around that *also* fix it, so please test this
> without those other patches).

This patch alone doesn't cure the problem... However, if combined with
the pure_initcall patch, it boots correctly.

I'll try to gather some traces later today.

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vasiliy Kulikov <segoon@openwall.com>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Richard Weinberger <richard@nod.at>, Ingo Molnar <mingo@elte.hu>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	"Paul E. McKenney" <paul.mckenney@linaro.org>
Subject: Re: [PATCH] shm: fix a race between shm_exit() and shm_init()
Date: Thu, 04 Aug 2011 09:26:34 +0100	[thread overview]
Message-ID: <4E3A57BA.2040907@arm.com> (raw)
In-Reply-To: <CA+55aFzw-K6XvDzTwHRyqQWdkDO8Zqz8Ak1qgNTzf6a3L9=80A@mail.gmail.com>

On 04/08/11 01:35, Linus Torvalds wrote:
> On Wed, Aug 3, 2011 at 12:30 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>
>> driver_init() is called from do_basic_setup(), before any initcall...
> 
> Ok, thanks everybody. I think the proper fix is the attached patch.
> It's crazy to have usermode helpers enabled early during boot when
> init etc haven't even been set up.
> 
> So does this finally fix the problem (I realize that there are other
> patches floating around that *also* fix it, so please test this
> without those other patches).

This patch alone doesn't cure the problem... However, if combined with
the pure_initcall patch, it boots correctly.

I'll try to gather some traces later today.

	M.
-- 
Jazz is not dead. It just smells funny...


  parent reply	other threads:[~2011-08-04  8:26 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 18:01 [kernel-hardening] initcall dependency problem (ns vs. threads) Vasiliy Kulikov
2011-08-01 18:01 ` Vasiliy Kulikov
2011-08-01 18:20 ` [kernel-hardening] " Andrew Morton
2011-08-01 18:20   ` Andrew Morton
2011-08-01 18:34   ` [kernel-hardening] " Vasiliy Kulikov
2011-08-01 19:03   ` Vasiliy Kulikov
2011-08-01 19:07     ` Andrew Morton
2011-08-01 19:22       ` Vasiliy Kulikov
2011-08-02  0:01     ` Linus Torvalds
2011-08-02 12:45       ` [kernel-hardening] [PATCH] shm: fix a race between shm_exit() and shm_init() Vasiliy Kulikov
2011-08-02 12:45         ` Vasiliy Kulikov
2011-08-02 12:51         ` [kernel-hardening] " Manuel Lauss
2011-08-02 12:51           ` Manuel Lauss
2011-08-02 13:23         ` [kernel-hardening] " Richard Weinberger
2011-08-02 13:23           ` Richard Weinberger
2011-08-02 13:29         ` [kernel-hardening] " Marc Zyngier
2011-08-02 13:29           ` Marc Zyngier
2011-08-02 20:33         ` [kernel-hardening] " Andrew Morton
2011-08-02 20:33           ` Andrew Morton
2011-08-02 20:55         ` [kernel-hardening] " Andrew Morton
2011-08-02 20:55           ` Andrew Morton
2011-08-03  5:30           ` [kernel-hardening] " Manuel Lauss
2011-08-03  5:30             ` Manuel Lauss
2011-08-03  8:05           ` [kernel-hardening] " Marc Zyngier
2011-08-03  8:05             ` Marc Zyngier
2011-08-03  8:19             ` [kernel-hardening] " Linus Torvalds
2011-08-03  8:19               ` Linus Torvalds
2011-08-03 10:04               ` [kernel-hardening] " Manuel Lauss
2011-08-03 10:04                 ` Manuel Lauss
2011-08-03 10:30               ` [kernel-hardening] " Marc Zyngier
2011-08-03 10:30                 ` Marc Zyngier
2011-08-03 13:13                 ` Thadeu Lima de Souza Cascardo
2011-08-03 13:33                   ` Kay Sievers
2011-08-03 13:45                     ` Richard Weinberger
2011-08-04  0:35                 ` [kernel-hardening] " Linus Torvalds
2011-08-04  0:35                   ` Linus Torvalds
2011-08-04  0:50                   ` [kernel-hardening] " Andrew Morton
2011-08-04  0:50                     ` Andrew Morton
2011-08-04  1:01                     ` [kernel-hardening] " Linus Torvalds
2011-08-04  1:01                       ` Linus Torvalds
2011-08-04  1:15                       ` [kernel-hardening] " Kay Sievers
2011-08-04  1:15                         ` Kay Sievers
2011-08-04  8:26                   ` Marc Zyngier [this message]
2011-08-04  8:26                     ` Marc Zyngier
2011-08-03  7:43         ` [kernel-hardening] " Linus Torvalds
2011-08-03  7:43           ` Linus Torvalds
2011-08-03  7:50           ` [kernel-hardening] " Manuel Lauss
2011-08-03  7:50             ` Manuel Lauss
2011-08-03  8:00             ` [kernel-hardening] " Manuel Lauss
2011-08-03  8:00               ` Manuel Lauss
2011-08-03 19:33           ` [kernel-hardening] " Andrew Morton
2011-08-03 19:33             ` Andrew Morton
2011-08-03 19:52             ` [kernel-hardening] " Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3A57BA.2040907@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.lauss@googlemail.com \
    --cc=mingo@elte.hu \
    --cc=paul.mckenney@linaro.org \
    --cc=richard@nod.at \
    --cc=segoon@openwall.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.