From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <jweiner@redhat.com>
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Minchan Kim <minchan.kim@gmail.com>, Jan Kara <jack@suse.cz>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include __GFP_OTHER_NODE
Date: Fri, 05 Aug 2011 10:16:29 -0400 [thread overview]
Message-ID: <4E3BFB3D.1050405@redhat.com> (raw)
In-Reply-To: <1311625159-13771-2-git-send-email-jweiner@redhat.com>
On 07/25/2011 04:19 PM, Johannes Weiner wrote:
> From: Johannes Weiner<hannes@cmpxchg.org>
>
> __GFP_OTHER_NODE is used for NUMA allocations on behalf of other
> nodes. It's supposed to be passed through from the page allocator to
> zone_statistics(), but it never gets there as gfp_allowed_mask is not
> wide enough and masks out the flag early in the allocation path.
>
> The result is an accounting glitch where successful NUMA allocations
> by-agent are not properly attributed as local.
>
> Increase __GFP_BITS_SHIFT so that it includes __GFP_OTHER_NODE.
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <jweiner@redhat.com>
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Minchan Kim <minchan.kim@gmail.com>, Jan Kara <jack@suse.cz>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include __GFP_OTHER_NODE
Date: Fri, 05 Aug 2011 10:16:29 -0400 [thread overview]
Message-ID: <4E3BFB3D.1050405@redhat.com> (raw)
In-Reply-To: <1311625159-13771-2-git-send-email-jweiner@redhat.com>
On 07/25/2011 04:19 PM, Johannes Weiner wrote:
> From: Johannes Weiner<hannes@cmpxchg.org>
>
> __GFP_OTHER_NODE is used for NUMA allocations on behalf of other
> nodes. It's supposed to be passed through from the page allocator to
> zone_statistics(), but it never gets there as gfp_allowed_mask is not
> wide enough and masks out the flag early in the allocation path.
>
> The result is an accounting glitch where successful NUMA allocations
> by-agent are not properly attributed as local.
>
> Increase __GFP_BITS_SHIFT so that it includes __GFP_OTHER_NODE.
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-05 14:17 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 20:19 [patch 0/5] mm: per-zone dirty limiting Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-25 20:19 ` [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include __GFP_OTHER_NODE Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-25 20:52 ` Andi Kleen
2011-07-25 20:52 ` Andi Kleen
2011-07-25 22:56 ` Minchan Kim
2011-07-25 22:56 ` Minchan Kim
2011-07-26 13:51 ` Mel Gorman
2011-07-26 13:51 ` Mel Gorman
2011-07-27 12:50 ` Michal Hocko
2011-07-27 12:50 ` Michal Hocko
2011-08-05 14:16 ` Rik van Riel [this message]
2011-08-05 14:16 ` Rik van Riel
2011-07-25 20:19 ` [patch 2/5] mm: writeback: make determine_dirtyable_memory static again Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-26 13:53 ` Mel Gorman
2011-07-26 13:53 ` Mel Gorman
2011-07-27 12:59 ` Michal Hocko
2011-07-27 12:59 ` Michal Hocko
2011-08-05 14:38 ` Rik van Riel
2011-08-05 14:38 ` Rik van Riel
2011-07-25 20:19 ` [patch 3/5] mm: writeback: remove seriously stale comment on dirty limits Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-27 13:38 ` Michal Hocko
2011-07-27 13:38 ` Michal Hocko
2011-08-05 14:45 ` Rik van Riel
2011-08-05 14:45 ` Rik van Riel
2011-07-25 20:19 ` [patch 4/5] mm: writeback: throttle __GFP_WRITE on per-zone " Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-25 20:37 ` Andi Kleen
2011-07-25 20:37 ` Andi Kleen
2011-07-25 23:40 ` Minchan Kim
2011-07-25 23:40 ` Minchan Kim
2011-08-03 19:06 ` Johannes Weiner
2011-08-03 19:06 ` Johannes Weiner
2011-07-26 14:42 ` Mel Gorman
2011-07-26 14:42 ` Mel Gorman
2011-08-03 20:21 ` Johannes Weiner
2011-08-03 20:21 ` Johannes Weiner
2011-07-27 14:24 ` Michal Hocko
2011-07-27 14:24 ` Michal Hocko
2011-08-03 20:25 ` Johannes Weiner
2011-08-03 20:25 ` Johannes Weiner
2011-08-04 7:27 ` Michal Hocko
2011-08-04 7:27 ` Michal Hocko
2011-07-25 20:19 ` [patch 5/5] mm: filemap: horrid hack to pass __GFP_WRITE for most page cache writers Johannes Weiner
2011-07-25 20:19 ` Johannes Weiner
2011-07-26 0:16 ` [patch 0/5] mm: per-zone dirty limiting Minchan Kim
2011-07-26 0:16 ` Minchan Kim
2011-07-26 15:47 ` Mel Gorman
2011-07-26 15:47 ` Mel Gorman
2011-07-26 18:05 ` Johannes Weiner
2011-07-26 18:05 ` Johannes Weiner
2011-07-26 21:54 ` Mel Gorman
2011-07-26 21:54 ` Mel Gorman
2011-07-29 11:05 ` Mel Gorman
2011-07-29 11:05 ` Mel Gorman
2011-08-02 12:17 ` Johannes Weiner
2011-08-02 12:17 ` Johannes Weiner
2011-08-03 13:18 ` Mel Gorman
2011-08-03 13:18 ` Mel Gorman
2011-09-20 12:19 ` Johannes Weiner
2011-09-20 12:19 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3BFB3D.1050405@redhat.com \
--to=riel@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jweiner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.