Re: [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API
Date: Tue, 09 Aug 2011 12:26:18 +0300	[thread overview]
Message-ID: <4E40FD3A.70208@redhat.com> (raw)
In-Reply-To: <CAFEAcA-K+1Rmdu+EmyH8fP_8FEVi8fTAm=J6Mpp=ddb_Wp3CUQ@mail.gmail.com>

On 08/09/2011 12:23 PM, Peter Maydell wrote:
> On 9 August 2011 10:02, Avi Kivity<avi@redhat.com>  wrote:
> >  +static const MemoryRegionOps omap_gpmc_ops = {
> >  +    .read = omap_gpmc_read,
> >  +    .write = omap_gpmc_write,
> >  +    .endianness = DEVICE_NATIVE_ENDIAN,
> >  +    .valid = {
> >  +        .min_access_size = 4,
> >  +        .max_access_size = 4,
> >  +    },
> >    };
>
> Does this give debug trace output for missized accesses?

Only after we implement and configure a debug policy in memory.c

> That's the main point of the badread/badwrite functions...

These are broken now, aren't they?

-- 
error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)

From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API
Date: Tue, 09 Aug 2011 12:26:18 +0300	[thread overview]
Message-ID: <4E40FD3A.70208@redhat.com> (raw)
In-Reply-To: <CAFEAcA-K+1Rmdu+EmyH8fP_8FEVi8fTAm=J6Mpp=ddb_Wp3CUQ@mail.gmail.com>

On 08/09/2011 12:23 PM, Peter Maydell wrote:
> On 9 August 2011 10:02, Avi Kivity<avi@redhat.com>  wrote:
> >  +static const MemoryRegionOps omap_gpmc_ops = {
> >  +    .read = omap_gpmc_read,
> >  +    .write = omap_gpmc_write,
> >  +    .endianness = DEVICE_NATIVE_ENDIAN,
> >  +    .valid = {
> >  +        .min_access_size = 4,
> >  +        .max_access_size = 4,
> >  +    },
> >    };
>
> Does this give debug trace output for missized accesses?

Only after we implement and configure a debug policy in memory.c

> That's the main point of the badread/badwrite functions...

These are broken now, aren't they?

-- 
error compiling committee.c: too many arguments to function

next prev parent reply	other threads:[~2011-08-09  9:26 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 17:06 [PATCH 00/24] Memory API batch 4: more conversions Avi Kivity
2011-08-08 17:06 ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 01/24] apb_pci: convert to memory API Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 02/24] apic: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 03/24] arm_gic: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 04/24] arm_sysctl: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 05/24] arm_timer: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 06/24] armv7m: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 07/24] gt64xxx.c: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 08/24] tusb6010: move declarations to new file tusb6010.h Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-09  7:51   ` Peter Maydell
2011-08-09  7:51     ` [Qemu-devel] " Peter Maydell
2011-08-09  9:02     ` [PATCH v1.1 " Avi Kivity
2011-08-09  9:02       ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:43   ` Peter Maydell
2011-08-09  6:34     ` Avi Kivity
2011-08-09  7:37       ` Peter Maydell
2011-08-09  7:41         ` Avi Kivity
2011-08-09  8:07           ` Peter Maydell
2011-08-09  8:44             ` Avi Kivity
2011-08-09  8:56               ` Avi Kivity
2011-08-09  8:56                 ` [Qemu-devel] " Avi Kivity
2011-08-09  9:02                 ` [PATCH v1.1 " Avi Kivity
2011-08-09  9:02                   ` [Qemu-devel] " Avi Kivity
2011-08-09  9:23                   ` Peter Maydell
2011-08-09  9:23                     ` [Qemu-devel] " Peter Maydell
2011-08-09  9:26                     ` Avi Kivity [this message]
2011-08-09  9:26                       ` Avi Kivity
2011-08-09  9:41                       ` Peter Maydell
2011-08-09 12:56                         ` Avi Kivity
2011-08-09 13:06                         ` [PATCH v1.2 " Avi Kivity
2011-08-09 13:06                           ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 10/24] onenand: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 11/24] pcie_host: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 12/24] ppc405_uc: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 13/24] ppc4xx_sdram: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:06 ` [PATCH 14/24] stellaris_enet: " Avi Kivity
2011-08-08 17:06   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 15/24] sysbus: add a variant of sysbus_init_mmio_cb with an unmap callback Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 16/24] sh_pci: convert to memory API Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 17/24] arm11mpcore: use sysbus_init_mmio_cb2 Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-12 13:23   ` Peter Maydell
2011-08-14 18:45     ` Avi Kivity
2011-08-14 18:45       ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 18/24] versatile_pci: convert to memory API Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-11 16:20   ` Peter Maydell
2011-08-11 16:20     ` [Qemu-devel] " Peter Maydell
2011-08-11 16:26     ` Avi Kivity
2011-08-11 16:29     ` [PATCH v1.1 " Avi Kivity
2011-08-11 16:29       ` [Qemu-devel] " Avi Kivity
2011-08-11 21:53       ` Peter Maydell
2011-08-11 21:53         ` [Qemu-devel] " Peter Maydell
2011-08-14 18:31         ` Avi Kivity
2011-08-14 18:31           ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 19/24] ppce500_pci: convert to sysbus_init_mmio_cb2() Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 20/24] sysbus: remove sysbus_init_mmio_cb() Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 21/24] isa: add isa_address_space() Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-10 16:24   ` Richard Henderson
2011-08-10 16:26     ` Richard Henderson
2011-08-10 16:35       ` Avi Kivity
2011-08-10 16:38         ` Avi Kivity
2011-08-10 18:44       ` Avi Kivity
2011-08-10 16:32     ` Avi Kivity
2011-08-08 17:07 ` [PATCH 22/24] pci: add pci_address_space() Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 23/24] vga: drop get_system_memory() from vga devices and derivatives Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity
2011-08-08 17:07 ` [PATCH 24/24] 440fx: fix PAM, PCI holes Avi Kivity
2011-08-08 17:07   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E40FD3A.70208@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.