All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Robin Holt <holt@sgi.com>
Cc: netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	U Bhaskar-B22300 <B22300@freescale.com>,
	socketcan-core@lists.berlios.de,
	Scott Wood <scottwood@freescale.com>,
	PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.
Date: Fri, 12 Aug 2011 14:22:56 +0200	[thread overview]
Message-ID: <4E451B20.2070207@grandegger.com> (raw)
In-Reply-To: <1313138752-24006-6-git-send-email-holt@sgi.com>

On 08/12/2011 10:45 AM, Robin Holt wrote:
> If our CAN device's device tree node has a clock-frequency property,
> then use that value for the can devices clock frequency.  If not, fall
> back to asking the platform/mach code for the clock frequency associated
> with the flexcan device.
> 
> Signed-off-by: Robin Holt <holt@sgi.com>
> To: Kumar Gala <galak@kernel.crashing.org>
> To: Wolfgang Grandegger <wg@grandegger.com>,
> To: Marc Kleine-Budde <mkl@pengutronix.de>,
> To: U Bhaskar-B22300 <B22300@freescale.com>
> To: Scott Wood <scottwood@freescale.com>
> To: Grant Likely <grant.likely@secretlab.ca>
> Cc: socketcan-core@lists.berlios.de,
> Cc: netdev@vger.kernel.org,
> Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
> Cc: devicetree-discuss@lists.ozlabs.org

Acked-by: Wolfgang Grandegger <wg@grandegger.com>

>From the Socket-CAN point of view, this and the other patches can go in.
Thanks for your effort.

Wolfgang.

WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
Cc: Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	Kumar Gala
	<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.
Date: Fri, 12 Aug 2011 14:22:56 +0200	[thread overview]
Message-ID: <4E451B20.2070207@grandegger.com> (raw)
In-Reply-To: <1313138752-24006-6-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>

On 08/12/2011 10:45 AM, Robin Holt wrote:
> If our CAN device's device tree node has a clock-frequency property,
> then use that value for the can devices clock frequency.  If not, fall
> back to asking the platform/mach code for the clock frequency associated
> with the flexcan device.
> 
> Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
> To: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
> To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>,
> To: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
> To: U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> To: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
> Cc: PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org

Acked-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

>From the Socket-CAN point of view, this and the other patches can go in.
Thanks for your effort.

Wolfgang.

  reply	other threads:[~2011-08-12 12:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12  8:45 [PATCH v12 0/6] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-12  8:45 ` Robin Holt
2011-08-12  8:45 ` [PATCH v12 1/6] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45 ` [PATCH v12 2/6] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45 ` [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-15 15:03   ` Robin Holt
2011-08-15 15:03     ` Robin Holt
2011-08-15 15:13     ` Grant Likely
2011-08-15 15:13       ` Grant Likely
2011-08-15 15:25       ` Robin Holt
2011-08-15 15:25         ` Robin Holt
2011-08-15 16:13     ` Marc Kleine-Budde
2011-08-15 16:13       ` Marc Kleine-Budde
2011-08-12  8:45 ` [PATCH v12 4/6] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45 ` [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12  8:45   ` Robin Holt
2011-08-12 12:22   ` Wolfgang Grandegger [this message]
2011-08-12 12:22     ` Wolfgang Grandegger
2011-08-12  8:45 ` [PATCH v12 6/6] powerpc: Add flexcan device support for p1010rdb Robin Holt
2011-08-12  8:45   ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E451B20.2070207@grandegger.com \
    --to=wg@grandegger.com \
    --cc=B22300@freescale.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=holt@sgi.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=scottwood@freescale.com \
    --cc=socketcan-core@lists.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.