From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
Date: Sun, 14 Aug 2011 23:39:43 -0700 [thread overview]
Message-ID: <4E48BF2F.7080901@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]
The following changes since commit 3b6ffe50300f13240e1b46420ad05da1116df410:
hw/scsi-bus.c: Fix use of uninitialised variable (2011-08-14 19:34:25 +0000)
are available in the git repository at:
git://git.kiszka.org/qemu.git queues/slirp
Jan Kiszka (1):
slirp: Fix bit field types in IP header structs
slirp/ip.h | 8 ++++----
slirp/tcp.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
---
slirp: Fix bit field types in IP header structs
-mms-bitfields prevents that the bitfields in current IP header structs
are packed into a single byte as it is required. Fix this by using
uint8_t as backing type.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
slirp/ip.h | 8 ++++----
slirp/tcp.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/slirp/ip.h b/slirp/ip.h
index 48ea38e..72dbe9a 100644
--- a/slirp/ip.h
+++ b/slirp/ip.h
@@ -74,10 +74,10 @@ typedef uint32_t n_long; /* long as received from the net */
*/
struct ip {
#ifdef HOST_WORDS_BIGENDIAN
- u_int ip_v:4, /* version */
+ uint8_t ip_v:4, /* version */
ip_hl:4; /* header length */
#else
- u_int ip_hl:4, /* header length */
+ uint8_t ip_hl:4, /* header length */
ip_v:4; /* version */
#endif
uint8_t ip_tos; /* type of service */
@@ -140,10 +140,10 @@ struct ip_timestamp {
uint8_t ipt_len; /* size of structure (variable) */
uint8_t ipt_ptr; /* index of current entry */
#ifdef HOST_WORDS_BIGENDIAN
- u_int ipt_oflw:4, /* overflow counter */
+ uint8_t ipt_oflw:4, /* overflow counter */
ipt_flg:4; /* flags, see below */
#else
- u_int ipt_flg:4, /* flags, see below */
+ uint8_t ipt_flg:4, /* flags, see below */
ipt_oflw:4; /* overflow counter */
#endif
union ipt_timestamp {
diff --git a/slirp/tcp.h b/slirp/tcp.h
index 9d06836..b3817cb 100644
--- a/slirp/tcp.h
+++ b/slirp/tcp.h
@@ -51,10 +51,10 @@ struct tcphdr {
tcp_seq th_seq; /* sequence number */
tcp_seq th_ack; /* acknowledgement number */
#ifdef HOST_WORDS_BIGENDIAN
- u_int th_off:4, /* data offset */
+ uint8_t th_off:4, /* data offset */
th_x2:4; /* (unused) */
#else
- u_int th_x2:4, /* (unused) */
+ uint8_t th_x2:4, /* (unused) */
th_off:4; /* data offset */
#endif
uint8_t th_flags;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next reply other threads:[~2011-08-15 6:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 6:39 Jan Kiszka [this message]
2011-08-20 20:00 ` [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields Stefan Weil
2011-08-23 10:49 ` TeLeMan
2011-08-24 9:11 ` Jan Kiszka
2011-08-25 1:14 ` TeLeMan
2011-08-25 11:04 ` Jan Kiszka
2011-08-25 12:02 ` TeLeMan
2011-08-25 12:38 ` Jan Kiszka
2011-08-25 13:02 ` Avi Kivity
2011-08-25 13:07 ` Anthony Liguori
2011-08-25 13:09 ` Jan Kiszka
2011-08-25 13:17 ` Avi Kivity
2011-08-25 13:15 ` Avi Kivity
2011-08-25 13:19 ` Jan Kiszka
2011-08-25 13:21 ` Avi Kivity
2011-08-25 13:06 ` Anthony Liguori
2011-08-25 13:13 ` Jan Kiszka
2011-08-25 13:22 ` Avi Kivity
2011-08-25 13:36 ` Peter Maydell
2011-08-25 13:39 ` Avi Kivity
2011-08-25 13:28 ` Anthony Liguori
2011-08-25 13:32 ` Jan Kiszka
2011-08-25 14:03 ` Stefan Weil
2011-08-25 14:23 ` Anthony Liguori
2011-08-25 17:15 ` Jan Kiszka
2011-08-21 19:49 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E48BF2F.7080901@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.