All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
Date: Thu, 25 Aug 2011 08:06:12 -0500	[thread overview]
Message-ID: <4E5648C4.3000604@us.ibm.com> (raw)
In-Reply-To: <4E564254.2080204@web.de>

On 08/25/2011 07:38 AM, Jan Kiszka wrote:
> On 2011-08-25 14:02, TeLeMan wrote:
>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<jan.kiszka@web.de>  wrote:
>>> What a mess. Do we really have to go through all 257 packed data structs
>>> in QEMU and add these MS compat bits to all potentially affected ones?
>> I prefer to detect -mms-bitfields and remove it in configure.
>
> /me too - if that is possible, ie. if the glib bits we are using doesn't
> require us to apply that mode. Can anyone comment on this?

So why can't we just #pragma guard all of the slirp bits?  Why are we 
doing it on a per data structure basis?

Regards,

Anthony Liguori

>
> Jan
>

  parent reply	other threads:[~2011-08-25 13:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15  6:39 [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields Jan Kiszka
2011-08-20 20:00 ` Stefan Weil
2011-08-23 10:49   ` TeLeMan
2011-08-24  9:11     ` Jan Kiszka
2011-08-25  1:14       ` TeLeMan
2011-08-25 11:04         ` Jan Kiszka
2011-08-25 12:02           ` TeLeMan
2011-08-25 12:38             ` Jan Kiszka
2011-08-25 13:02               ` Avi Kivity
2011-08-25 13:07                 ` Anthony Liguori
2011-08-25 13:09                   ` Jan Kiszka
2011-08-25 13:17                     ` Avi Kivity
2011-08-25 13:15                   ` Avi Kivity
2011-08-25 13:19                     ` Jan Kiszka
2011-08-25 13:21                       ` Avi Kivity
2011-08-25 13:06               ` Anthony Liguori [this message]
2011-08-25 13:13                 ` Jan Kiszka
2011-08-25 13:22                   ` Avi Kivity
2011-08-25 13:36                     ` Peter Maydell
2011-08-25 13:39                       ` Avi Kivity
2011-08-25 13:28                   ` Anthony Liguori
2011-08-25 13:32                     ` Jan Kiszka
2011-08-25 14:03                       ` Stefan Weil
2011-08-25 14:23                         ` Anthony Liguori
2011-08-25 17:15                         ` Jan Kiszka
2011-08-21 19:49 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5648C4.3000604@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=geleman@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.